public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
* [Bug breakpoints/21969] watchpoint break not triggered on reverse continue [not found] <bug-21969-4717@http.sourceware.org/bugzilla/> @ 2023-09-13 15:50 ` ssbssa at sourceware dot org 2023-12-06 12:47 ` cvs-commit at gcc dot gnu.org 2023-12-06 12:48 ` ssbssa at sourceware dot org 2 siblings, 0 replies; 3+ messages in thread From: ssbssa at sourceware dot org @ 2023-09-13 15:50 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=21969 Hannes Domani <ssbssa at sourceware dot org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ssbssa at sourceware dot org Version|8.0 |7.10 -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug breakpoints/21969] watchpoint break not triggered on reverse continue [not found] <bug-21969-4717@http.sourceware.org/bugzilla/> 2023-09-13 15:50 ` [Bug breakpoints/21969] watchpoint break not triggered on reverse continue ssbssa at sourceware dot org @ 2023-12-06 12:47 ` cvs-commit at gcc dot gnu.org 2023-12-06 12:48 ` ssbssa at sourceware dot org 2 siblings, 0 replies; 3+ messages in thread From: cvs-commit at gcc dot gnu.org @ 2023-12-06 12:47 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=21969 --- Comment #2 from Sourceware Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Hannes Domani <ssbssa@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=288363c1737f93e2f7cb8c06026c11a5ff77fb58 commit 288363c1737f93e2f7cb8c06026c11a5ff77fb58 Author: Hannes Domani <ssbssa@yahoo.de> Date: Wed Dec 6 13:45:51 2023 +0100 Fix hardware watchpoints in replay mode Changes introduced by commit 9e8915c6cee5c37637521b424d723e990e06d597 caused a regression that meant hardware watchpoint stops would not trigger in reverse execution or replay mode. This was documented in PR breakpoints/21969. The problem is that record_check_stopped_by_breakpoint always overwrites record_full_stop_reason, thus loosing the TARGET_STOPPED_BY_WATCHPOINT value which would be checked afterwards. This commit fixes that by not overwriting the stop-reason in record_full_stop_reason if we're not stopped at a breakpoint. And the test for hw watchpoints in gdb.reverse/watch-reverse.exp actually tested sw watchpoints again, since "set can-use-hw-watchpoints 1" doesn't convert enabled watchpoints to use hardware. This is fixed by disabling said watchpoint while enabling hw watchpoints. The same is not done for gdb.reverse/watch-precsave.exp, since it's not possible to use hw watchpoints in restored recordings anyways. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=21969 Approved-by: Guinevere Larsen <blarsen@redhat.com> -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug breakpoints/21969] watchpoint break not triggered on reverse continue [not found] <bug-21969-4717@http.sourceware.org/bugzilla/> 2023-09-13 15:50 ` [Bug breakpoints/21969] watchpoint break not triggered on reverse continue ssbssa at sourceware dot org 2023-12-06 12:47 ` cvs-commit at gcc dot gnu.org @ 2023-12-06 12:48 ` ssbssa at sourceware dot org 2 siblings, 0 replies; 3+ messages in thread From: ssbssa at sourceware dot org @ 2023-12-06 12:48 UTC (permalink / raw) To: gdb-prs https://sourceware.org/bugzilla/show_bug.cgi?id=21969 Hannes Domani <ssbssa at sourceware dot org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |15.1 Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Hannes Domani <ssbssa at sourceware dot org> --- Fixed. -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-06 12:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-21969-4717@http.sourceware.org/bugzilla/>
2023-09-13 15:50 ` [Bug breakpoints/21969] watchpoint break not triggered on reverse continue ssbssa at sourceware dot org
2023-12-06 12:47 ` cvs-commit at gcc dot gnu.org
2023-12-06 12:48 ` ssbssa at sourceware dot org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).