[Bug tui/30580] New: [gdb/tui] !HAVE_WBORDER and border-kind ascii and space

[Bug tui/30580] New: [gdb/tui] !HAVE_WBORDER and border-kind ascii and space

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30580

            Bug ID: 30580
           Summary: [gdb/tui] !HAVE_WBORDER and border-kind ascii and
                    space
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tui
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

The TUI sources contain a HAVE_WBORDER ifdef:
...
$ find gdb* -type f | xargs grep HAVE_WBORDER
gdb/config.in:#undef HAVE_WBORDER
gdb/tui/tui-wingeneral.c:#ifdef HAVE_WBORDER
...

I simulated the !HAVE_WBORDER case using:
...
-#ifdef HAVE_WBORDER
+#if 0
...
and realized that border-kind ascii and space still use the acs corners, which
looks funny.

With space border-kind:
...
┌                                  ┐

 [ No Source Available ]            

└                                  ┘
...

With ascii border-kind:
...
┌----------------------------------┐
|                                  |
|[ No Source Available ]           |
|                                  |
└----------------------------------┘
...

With the space border-kind there's a clear style break.

With the ascii border-kind, things look funny because the top corner elements
do not connect to the neighboring hline and vline elements, while the bottom
corner elements do connect to the neighboring vline elements, but not the hline
ones (at least, in my xterm).

Maybe the ascii and space border-kind values should be eliminated for the
!HAVE_WBORDER case.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tui/30580] [gdb/tui] !HAVE_WBORDER and border-kind ascii and space

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30580

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at sourceware dot org

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
I wonder if there is any system curses without wborder.
Maybe the check and define can just be removed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tui/30580] [gdb/tui] !HAVE_WBORDER and border-kind ascii and space

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30580

--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
This ( https://sourceware.org/pipermail/gdb-patches/2004-September/037743.html
) suggests it was introduced for Ultrix.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tui/30580] [gdb/tui] !HAVE_WBORDER and border-kind ascii and space

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30580

--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
Ultrix seems like it is beyond obsolete.
I think dropping this is fine, and if it turns out to matter,
we can see if they will just use ncurses instead.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tui/30580] [gdb/tui] !HAVE_WBORDER and border-kind ascii and space

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30580

--- Comment #4 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom Tromey from comment #3)
> Ultrix seems like it is beyond obsolete.
> I think dropping this is fine, and if it turns out to matter,
> we can see if they will just use ncurses instead.

https://sourceware.org/pipermail/gdb-patches/2023-July/200833.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tui/30580] [gdb/tui] !HAVE_WBORDER and border-kind ascii and space

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30580

--- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a839dbdce5d923dd28027ae2dba01f88104b7926

commit a839dbdce5d923dd28027ae2dba01f88104b7926
Author: Tom de Vries <tdevries@suse.de>
Date:   Wed Jul 12 16:27:40 2023 +0200

    [gdb/tui] Assume HAVE_WBORDER

    The tui border-kind setting allows values acs, ascii and space.

    The values ascii and space however don't work well with !HAVE_WBORDER.

    Fix this by removing the !HAVE_WBORDER case, which was introduced for
Ultrix
    support, which is now obsolete.

    Tested on x86_64-linux.

    PR tui/30580
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30580

    Approved-By: Tom Tromey <tom@tromey.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tui/30580] [gdb/tui] !HAVE_WBORDER and border-kind ascii and space

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=30580

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |14.1

--- Comment #6 from Tom de Vries <vries at gcc dot gnu.org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.