[Bug symtab/31041] New: some symtab code incorrectly uses perror_with_name

[Bug symtab/31041] New: some symtab code incorrectly uses perror_with_name

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31041

            Bug ID: 31041
           Summary: some symtab code incorrectly uses perror_with_name
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: symtab
          Assignee: unassigned at sourceware dot org
          Reporter: tromey at sourceware dot org
  Target Milestone: ---

I found this in coffread.c:

  val = bfd_seek (objfile->obfd.get (), symtab_offset, 0);
  if (val < 0)
    perror_with_name (objfile_name (objfile));

This is calling a BFD function but expecting an error
in errno.  Instead it should inspect the BFD error.

There is similar code in dbxread.c and xcoffread.c.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/31041] some symtab code incorrectly uses perror_with_name

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31041

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
Only the coffread problem remains.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/31041] some symtab code incorrectly uses perror_with_name

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31041

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |tromey at sourceware dot org

--- Comment #2 from Tom Tromey <tromey at sourceware dot org> ---
https://sourceware.org/pipermail/gdb-patches/2026-January/223863.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/31041] some symtab code incorrectly uses perror_with_name

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31041

--- Comment #3 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7a5af285bb7ce4cf6bbf0d82b26be700dbabba91

commit 7a5af285bb7ce4cf6bbf0d82b26be700dbabba91
Author: Tom Tromey <tromey@adacore.com>
Date:   Thu Jan 8 14:11:08 2026 -0700

    Fix error case in coffread.c

    coffread.c is the last spot (that I know of) that incorrectly calls
    perror_with_name when a BFD function fails.  The issue here is that
    perror_with_name examines errno, but BFD failures do not set this.
    This patch changes this to use error and bfd_errmsg.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31041
    Approved-By: Simon Marchi <simon.marchi@efficios.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/31041] some symtab code incorrectly uses perror_with_name

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31041

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |18.1
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.