[Bug sim/31181] sim: cris: decode unused base_insn variable warnings

["hp at sourceware dot org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=31181

--- Comment #7 from Hans-Peter Nilsson <hp at sourceware dot org> ---
(In reply to Tom Tromey from comment #6)
> I tend to think the cris one is a bug in cgen.

I won't comment on the bugginess part, but it's a valid view, and certainly so
if cgen strives to generate warning-free code.

> In particular /gen-extract-case does:
> 
>    (if (> (length (sfmt-iflds sfmt)) 0)
>        (string-append
> 	"    CGEN_INSN_WORD insn = "
> 	(if (adata-integral-insn? CURRENT-ARCH)
> 	    "entire_insn;\n"
> 	    "base_insn;\n"))
>        "")
> 
> ... but I think in this case, because the ifield
> is constant, later code doesn't emit any use of 'insn'.

IOW, but more precise about the location, thanks.
(And actually "more correct", as I looked at /gen-decode-fn.)

To wit along my suggestion above, hacked (or solved) by adding "(void) insn;"
as another parameter to the string-append call (if I RTF-guile-M correctly). 
Plus at least the suggested comment to aid casual readers.

-- 
You are receiving this mail because:
You are on the CC list for the bug.