public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "vapier at gentoo dot org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug sim/31181] sim: cris: decode unused base_insn variable warnings
Date: Tue, 19 Dec 2023 10:09:04 +0000	[thread overview]
Message-ID: <bug-31181-4717-rAdUMTcZ24@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-31181-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=31181

--- Comment #2 from Mike Frysinger <vapier at gentoo dot org> ---
i'd be inclined to agree if things were more widespread, but these 5 are the
only unused variable warnings left in the sim tree at this point.  i'm not
super keen on adding -Wno-error=xxx to makefiles because we should test the
flag is supported by the compiler before adding it, and that makes the build
logic quite a bit more complicated.

also, in the process of cleaning the sim code of unused variable warnings, it's
uncovered a few actual bugs where people made thinkos/typos in the code -- they
intended to use a particular var after setting it up, but then omitted it or
used a very similarly named var.  that scenario can come up in the generated
code logic too, although it hasn't as of yet.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2023-12-19 10:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-19  2:34 [Bug sim/31181] New: " vapier at gentoo dot org
2023-12-19  3:13 ` [Bug sim/31181] " hp at sourceware dot org
2023-12-19 10:09 ` vapier at gentoo dot org [this message]
2023-12-19 23:35 ` hp at sourceware dot org
2023-12-20  3:19 ` vapier at gentoo dot org
2023-12-20 15:58 ` hp at sourceware dot org
2023-12-21  1:10 ` tromey at sourceware dot org
2023-12-21  1:50 ` hp at sourceware dot org
2023-12-21  4:12 ` vapier at gentoo dot org
2023-12-21 15:59 ` hp at sourceware dot org
2023-12-21 17:22 ` vapier at gentoo dot org
2023-12-21 17:32 ` hp at sourceware dot org
2023-12-21 17:41 ` hp at sourceware dot org
2023-12-22  1:19 ` vapier at gentoo dot org
2023-12-22 15:47 ` vapier at gentoo dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-31181-4717-rAdUMTcZ24@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).