[Bug sim/31181] sim: cris: decode unused base_insn variable warnings

["hp at sourceware dot org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=31181

--- Comment #3 from Hans-Peter Nilsson <hp at sourceware dot org> ---
(In reply to Mike Frysinger from comment #2)
> i'd be inclined to agree if things were more widespread, but these 5 are the
> only unused variable warnings left in the sim tree at this point.  i'm not
> super keen on adding -Wno-error=xxx to makefiles because we should test the
> flag is supported by the compiler before adding it, and that makes the build
> logic quite a bit more complicated.
> 
> also, in the process of cleaning the sim code of unused variable warnings,
> it's uncovered a few actual bugs where people made thinkos/typos in the code
> -- they intended to use a particular var after setting it up, but then
> omitted it or used a very similarly named var.  that scenario can come up in
> the generated code logic too, although it hasn't as of yet.

My point is that *these two files* would be the only files that got
-Wno-error=unused-variable.  You say, you've looked for, but not found, a
bug-reason why the warnings appear, in this generated code, presumably
including looking at the generator.  I don't see the point in going deeper, but
feel free.

-- 
You are receiving this mail because:
You are on the CC list for the bug.