[Bug sim/31181] sim: cris: decode unused base_insn variable warnings

["vapier at gentoo dot org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=31181

--- Comment #10 from Mike Frysinger <vapier at gentoo dot org> ---
(In reply to Hans-Peter Nilsson from comment #9)
> That last line seems superfluous and should yield errors.  (Accidentally
> quoted an untested diff?)

yeah i didn't delete my partial comment ... already fixed it when i posted to
the cgen mailing list

> Beware that (IIRC) not
> all compilers (old gcc, perhaps *cough* clang) support the same *location*
> for the attribute (here, before the type).  The canonical position is after;
> "before the ';'".

ok, easy enough to update

> > +        "CGEN_INSN_WORD insn = "
> >          (if (adata-integral-insn? CURRENT-ARCH)
> >              "entire_insn;\n"
> >              "base_insn;\n"))
> 
> I don't know whether the "adata-integral-insn?" predicate has bearing on
> whether insn can be "unused". Still: besides the superfluous line, I'd say
> time to post it for review, with a link to this PR.

i have no idea about adata-integral-insn here.  i went with it because all the
unused warnings are coming from insn=base_insn, not insn=entire_insn, and
adata-integral-insn controls whether it's entire_insn or base_insn.

i'll cc you on the v2 patch on the cgen list.

-- 
You are receiving this mail because:
You are on the CC list for the bug.