public inbox for gdb@sourceware.org
 help / color / mirror / Atom feed
From: "Martin Liška" <mliska@suse.cz>
To: Tom Tromey <tom@tromey.com>
Cc: "H.J. Lu" <hjl.tools@gmail.com>, Simon Marchi <simark@simark.ca>,
	GDB <gdb@sourceware.org>, Binutils <binutils@sourceware.org>
Subject: Re: Auto update ChangeLog for binutils+gdb commits?
Date: Fri, 29 May 2020 15:56:50 +0200	[thread overview]
Message-ID: <12ea10a1-59c1-5858-4619-ed3b40121d30@suse.cz> (raw)
In-Reply-To: <87o8q6c3m9.fsf@tromey.com>

On 5/29/20 2:44 PM, Tom Tromey wrote:
> Martin> For generation of ChangeLog template, you can use:
> Martin> https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=contrib/mklog.py;h=243edbb15c522169709902b27a8558c6e0755107;hb=HEAD
> 
> Can it be used without manual intervention?
> Or do I still have to edit in all the function names?

One only needs to describe what's purpose of a change.

> Could you run it on some recent gdb commits and show the output?

Sure:

$ git format-patch -1 2b2558bfacba3813863da6728c021eb89fa34677 && ~/Programming/gcc/contrib/mklog.py 00*
0001-Move-DWARF-constant-stringifying-code-to-new-file.patch

ChangeLog:

	* gdb/ChangeLog:
	* gdb/Makefile.in:
	* gdb/dwarf2/read.c (dwarf_tag_name):
	(dwarf_attr_name):
	(dwarf_form_name):
	(dwarf_bool_name):
	(dwarf_type_encoding_name):
	(dwarf_unknown):
	* gdb/dwarf2/stringify.c: New file.
	* gdb/dwarf2/stringify.h: New file.

> 
> Martin> About the merges: it's a pain to make a backport (a.k.a) as you're very likely
> Martin> conflict in ChangeLog entries. Having the ChangeLog entries in message one
> Martin> can do simple git cherry-pick and it's done.
> 
> This is emphatically not the case for me.
> 
> Martin> About the date-updating: it's also pain to always update a timestamp before
> Martin> a patch is installed.
> 
> What I'm saying is that it isn't a pain.  It's a single command before
> pushing.  I can't remember the last time the scripts failed but it's
> surely been more than 5 years.
> 
> I write a lot of patches in gdb and I have already filed off as many
> annoying parts as I could -- which is why my default stance is not to
> want to change.  Changing implies that maybe I'd have to redo this work.

Sure. You're a skilled GDB developer with long experience. But for newcomers or
people without the scripts, this can simplify their workflow.

Martin

> 
> Tom
> 


  reply	other threads:[~2020-05-29 13:56 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-26 17:07 Auto generate ChangeLog for binutils commits? H.J. Lu
2020-05-27 14:10 ` Simon Marchi
2020-05-27 14:20   ` H.J. Lu
2020-05-27 14:29     ` Simon Marchi
2020-05-27 15:10       ` Auto update ChangeLog for binutils+gdb commits? H.J. Lu
2020-05-29  7:45         ` Martin Liška
2020-05-29  8:51           ` Martin Liška
2020-05-29 12:15           ` Tom Tromey
2020-05-29 12:25             ` Martin Liška
2020-05-29 12:44               ` Tom Tromey
2020-05-29 13:56                 ` Martin Liška [this message]
2020-05-30 10:23                   ` Aktemur, Tankut Baris
2020-05-30 11:22                     ` Martin Liška
2020-05-30 19:41                   ` Tom Tromey
2020-05-31  4:40                     ` Fangrui Song
2020-05-31  7:41                     ` Jan Vrany
2020-06-01  7:51                     ` Martin Liška
2020-05-29 12:28             ` Martin Liška
2020-05-29 13:57             ` Eli Zaretskii
2020-05-30 19:23               ` Tom Tromey
2020-05-30 19:35                 ` Eli Zaretskii
2020-06-01  7:39                   ` Martin Liška
2020-06-01 14:59                     ` Eli Zaretskii
2020-06-02  6:49                       ` Martin Liška
2021-01-15  1:18                         ` Fangrui Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12ea10a1-59c1-5858-4619-ed3b40121d30@suse.cz \
    --to=mliska@suse.cz \
    --cc=binutils@sourceware.org \
    --cc=gdb@sourceware.org \
    --cc=hjl.tools@gmail.com \
    --cc=simark@simark.ca \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).