From: Fangrui Song <i@maskray.me>
To: "Martin Liška" <mliska@suse.cz>
Cc: Tom Tromey <tom@tromey.com>, Simon Marchi <simark@simark.ca>,
Binutils <binutils@sourceware.org>, GDB <gdb@sourceware.org>
Subject: Re: Auto update ChangeLog for binutils+gdb commits?
Date: Sat, 30 May 2020 21:40:43 -0700 [thread overview]
Message-ID: <MWHPR12MB14563C1C185701557BD940FBCB8D0@MWHPR12MB1456.namprd12.prod.outlook.com> (raw)
In-Reply-To: <87y2p9qkgd.fsf@tromey.com>
I tried mklog.py on my gold patch.
% ~/Dev/gcc/contrib/mklog.py < 0001-gold-Set-DF_1_PIE-for-pie.patch
ChangeLog:
* elfcpp/elfcpp.h (enum DF_1):
* gold/layout.cc (Layout::finish_dynamic_section):
IIUC, the practice is to group ChangeLog's by the top-level directories
elfcpp
* elfcpp.h (enum DF_1):
gold
* layout.cc (Layout::finish_dynamic_section):
On Sat, May 30, 2020 at 12:41 PM Tom Tromey <tom@tromey.com> wrote:
>
> >> Could you run it on some recent gdb commits and show the output?
>
> I tried it out a little as well.
>
> It seems promising. However, I noticed some issues.
>
> First, in the basic output:
>
> Martin> * gdb/Makefile.in:
>
> It would be more convenient for editing if the ":" were followed by a
> space, since I'm normally going to have to add one anyway.
>
>
> Next, try it like:
>
> $ git show af0b2a3e85df9f49a3528e5b7578fcf9412f1acc | ./contrib/mklog.py
>
> I get:
>
> gdb/ChangeLog:
>
> * ChangeLog:
> * dwarf2/abbrev.c (hash_abbrev):
> (abbrev_table::add_abbrev):
> (struct abbrev_info):
> (abbrev_table::lookup_abbrev):
> (abbrev_table::read):
> * dwarf2/abbrev.h (GDB_DWARF2_ABBREV_H):
> (struct abbrev_table):
>
> abbrev.c says:
>
> (struct abbrev_info):
>
> ... but I didn't see anything that would be relevant in the patch.
>
> abbrev.h says:
>
> * dwarf2/abbrev.h (GDB_DWARF2_ABBREV_H):
>
> ... but this is very incorrect. In gdb we normally ignore changes to
> the #includes, but if needed I suppose this could mention the addition
> of one; but either way mentioning the include guard name is wrong --
> macros should be ignored unless each preceding line ends with a
> backslash.
>
> If you try 89bcba74f89baceba3fa7387622e3d60e1de02e8, you'll see that
> mklog ignores namespaces.
>
> Martin> Sure. You're a skilled GDB developer with long experience. But for newcomers or
> Martin> people without the scripts, this can simplify their workflow.
>
> IMO we should optimize for reducing the overhead for regular
> contributors. Newcomers normally have many things to learn.
>
> Tom
next prev parent reply other threads:[~2020-05-31 4:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 17:07 Auto generate ChangeLog for binutils commits? H.J. Lu
2020-05-27 14:10 ` Simon Marchi
2020-05-27 14:20 ` H.J. Lu
2020-05-27 14:29 ` Simon Marchi
2020-05-27 15:10 ` Auto update ChangeLog for binutils+gdb commits? H.J. Lu
2020-05-29 7:45 ` Martin Liška
2020-05-29 8:51 ` Martin Liška
2020-05-29 12:15 ` Tom Tromey
2020-05-29 12:25 ` Martin Liška
2020-05-29 12:44 ` Tom Tromey
2020-05-29 13:56 ` Martin Liška
2020-05-30 10:23 ` Aktemur, Tankut Baris
2020-05-30 11:22 ` Martin Liška
2020-05-30 19:41 ` Tom Tromey
2020-05-31 4:40 ` Fangrui Song [this message]
2020-05-31 7:41 ` Jan Vrany
2020-06-01 7:51 ` Martin Liška
2020-05-29 12:28 ` Martin Liška
2020-05-29 13:57 ` Eli Zaretskii
2020-05-30 19:23 ` Tom Tromey
2020-05-30 19:35 ` Eli Zaretskii
2020-06-01 7:39 ` Martin Liška
2020-06-01 14:59 ` Eli Zaretskii
2020-06-02 6:49 ` Martin Liška
2021-01-15 1:18 ` Fangrui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR12MB14563C1C185701557BD940FBCB8D0@MWHPR12MB1456.namprd12.prod.outlook.com \
--to=i@maskray.me \
--cc=binutils@sourceware.org \
--cc=gdb@sourceware.org \
--cc=mliska@suse.cz \
--cc=simark@simark.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).