From: "Martin Liška" <mliska@suse.cz>
To: Eli Zaretskii <eliz@gnu.org>
Cc: tom@tromey.com, simark@simark.ca, hjl.tools@gmail.com,
binutils@sourceware.org, gdb@sourceware.org
Subject: Re: Auto update ChangeLog for binutils+gdb commits?
Date: Tue, 2 Jun 2020 08:49:46 +0200 [thread overview]
Message-ID: <7b70bf47-db34-51a8-ae7e-a9d295954db8@suse.cz> (raw)
In-Reply-To: <838sh6g7cu.fsf@gnu.org>
On 6/1/20 4:59 PM, Eli Zaretskii wrote:
>> Cc: simark@simark.ca, hjl.tools@gmail.com, binutils@sourceware.org,
>> gdb@sourceware.org
>> From: Martin Liška <mliska@suse.cz>
>> Date: Mon, 1 Jun 2020 09:39:08 +0200
>>
>>> If all the script does is look at the hunk headers of the diffs, then
>>> indeed such a script doesn't have any added value. I thought it did a
>>> more thorough (and thus more accurate) job than that.
>>>
>>
>> It does, it tries to find a function name, macro, struct in a diff hunk
>> and this name is taken as changed. If nothing like this is found, then
>> diff header name is used.
>
> How does it handle the frequent case where the change is attributed by
> Diff to the previous function because the function's type or argument
> list is being modified?
It's handled by parsing of each diff line where we try to identify
beginning of a function, strut or something else. In that case the
diff header is ignored.
>
> And how does the script decide that "nothing like this is found",
> i.e. how does it know that what is in the hunk header is not really a
> function name?
It's best effort approach and it's not easy task ;)
Martin
>
> Thanks.
>
next prev parent reply other threads:[~2020-06-02 6:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 17:07 Auto generate ChangeLog for binutils commits? H.J. Lu
2020-05-27 14:10 ` Simon Marchi
2020-05-27 14:20 ` H.J. Lu
2020-05-27 14:29 ` Simon Marchi
2020-05-27 15:10 ` Auto update ChangeLog for binutils+gdb commits? H.J. Lu
2020-05-29 7:45 ` Martin Liška
2020-05-29 8:51 ` Martin Liška
2020-05-29 12:15 ` Tom Tromey
2020-05-29 12:25 ` Martin Liška
2020-05-29 12:44 ` Tom Tromey
2020-05-29 13:56 ` Martin Liška
2020-05-30 10:23 ` Aktemur, Tankut Baris
2020-05-30 11:22 ` Martin Liška
2020-05-30 19:41 ` Tom Tromey
2020-05-31 4:40 ` Fangrui Song
2020-05-31 7:41 ` Jan Vrany
2020-06-01 7:51 ` Martin Liška
2020-05-29 12:28 ` Martin Liška
2020-05-29 13:57 ` Eli Zaretskii
2020-05-30 19:23 ` Tom Tromey
2020-05-30 19:35 ` Eli Zaretskii
2020-06-01 7:39 ` Martin Liška
2020-06-01 14:59 ` Eli Zaretskii
2020-06-02 6:49 ` Martin Liška [this message]
2021-01-15 1:18 ` Fangrui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b70bf47-db34-51a8-ae7e-a9d295954db8@suse.cz \
--to=mliska@suse.cz \
--cc=binutils@sourceware.org \
--cc=eliz@gnu.org \
--cc=gdb@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=simark@simark.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).