PATCH: Fix "proc find" in dejagnu

PATCH: Fix "proc find" in dejagnu

[H. J. Lu]

[-- Attachment #1: Type: text/plain, Size: 462 bytes --]

"proc find" is using "getdirs -all" incorrectly. When "getdirs -all" is
used, there is no need to try to get all directories yourselves. The
current "proc find" will list any file not in the root directory
twice. This patch should fix it.

BTW, is anyone working on dejagnu? I have found and fixed 3 bugs
in less than 2 weeks since I was forced to use dejagnu 1.4.3. I didn't
get any reponses nor any indications those bugs would be fixed any
time soon.



H.J.

[-- Attachment #2: dejagnu-find.patch --]
[-- Type: text/plain, Size: 807 bytes --]

2003-05-19  H.J. Lu <hongjiu.lu@intel.com>

	* lib/utils.exp (find): Correctly use [getdirs -all $rootdir].

--- dejagnu/lib/utils.exp.recursive	2002-08-29 20:54:53.000000000 -0700
+++ dejagnu/lib/utils.exp	2003-05-18 23:42:17.000000000 -0700
@@ -97,25 +97,7 @@ proc getdirs { args } {
 #
 proc find { rootdir pattern } {
     # first find all the directories
-    set dirs "$rootdir "
-    while 1 {
-	set tmp $rootdir
-	set rootdir ""
-	if [string match "" $tmp] {
-	    break
-	}
-	foreach i $tmp {
-	    set j [getdirs -all $i]
-	    if ![string match "" $j] {
-		append dirs "$j "
-		set rootdir $j
-		unset j
-	    } else {
-		set rootdir ""
-	    }
-	}
-	set tmp ""
-    }
+    set dirs "$rootdir [getdirs -all $rootdir]"
     
     # find all the files that match the pattern
     foreach i $dirs {

Re: PATCH: Fix "proc find" in dejagnu

[Rob Savoye]

On Sun, May 18, 2003 at 11:57:10PM -0700, H. J. Lu wrote:

> BTW, is anyone working on dejagnu? I have found and fixed 3 bugs
> in less than 2 weeks since I was forced to use dejagnu 1.4.3. I didn't
> get any reponses nor any indications those bugs would be fixed any
 
  Yes, somebody is still working on it, classically as a "side gig" to
my income generating work... I've encorporated all your patches into my
local source tree, and as they were mostly obvious, I didn't feel a need
for discussion. I still have to test them. Personally, if you don't like
DejaGnu don't use it... or implement something better. Dissing DejaGnu
isn't really a good way to get me to respond. DejaGnu is over 12 years
old, and could use some work to make it more up to date. Maybe someday
I'll have that much (free) time, but till then, about all I can do is
keep patching it so it's at least useful to the GNU development tools,
since not too many other projects bother to do any real testing. As
almost nobody else has ever stepped forward to help with maintaining
DejaGnu, it's pretty much a solo effort. I unfortunately find my new
GNU project (http://www.senecass.com/abelmon/) way more stimulating than
hacking on regression testing frameworks full-time for another 12 years. 

	- rob -