public inbox for gdb@sourceware.org
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: oza Pawandeep <oza.pawandeep@gmail.com>
Cc: Tom Tromey <tromey@redhat.com>,
	gdb@sourceware.org,	gdb-patches@sourceware.org
Subject: Re: [design change] record-replay linux ABI level
Date: Mon, 14 May 2012 14:57:00 -0000	[thread overview]
Message-ID: <20120514145650.GF10253@adacore.com> (raw)
In-Reply-To: <CAK1A=4y7d8ot_G+O8oFm_ZVDT9q7QdFu87hMXT=+mHfVuJPnTw@mail.gmail.com>

> static enum gdb_syscall
> arm_canonicalize_syscall (int syscall)
> {
>   enum { arm_sys_prlimit64 = 369 };
> 
>   if (syscall <= arm_sys_prlimit64)
>     {
>       if (syscall <= gdb_sys_sched_getaffinity)
>         return syscall;
>       else if (syscall <= gdb_sys_fadvise64_64)
>         {
>           return (syscall + (unsigned int)2);
>         }
>       else
>         {
>           switch (syscall)

Why not define a table that defines the mapping for every syscall?
We do that for registers -vs- register names, for instance, and that
works very well.

    static enum gdb_syscall arm_syscal_map[] =
    {
      gdb_sys_restart_syscall, gdb_sys_exit, gdb_sys_fork,
      [...]
      gdb_sys_sched_getaffinity, gdb_sys_arm_trap16,
      [...]
    };

-- 
Joel

  reply	other threads:[~2012-05-14 14:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAK1A=4xtgYd8hQEwHxjLQiv4eqhCu0cSRDmmbFJvBDJwDxUM+Q__46748.0269181125$1336555010$gmane$org@mail.gmail.com>
2012-05-09 20:39 ` Tom Tromey
2012-05-10  8:49   ` oza Pawandeep
     [not found]   ` <CAK1A=4xbh0M=yfc2MQpZdDCJEPnL3_z8=TA0VSE7qVCoO0Dn-Q__42617.423789534$1336639800$gmane$org@mail.gmail.com>
2012-05-10 13:39     ` Tom Tromey
2012-05-13  7:19       ` oza Pawandeep
2012-05-13  7:33         ` oza Pawandeep
2012-05-13  9:47           ` oza Pawandeep
2012-05-14 14:57             ` Joel Brobecker [this message]
2012-05-15  5:20               ` oza Pawandeep
2012-05-15  5:34                 ` Joel Brobecker
     [not found]               ` <CAK1A=4yervLeVDQ-r49n95ftrB27u8K+R1hfstz1oFwTNX=t7Q__24807.0006179207$1337059251$gmane$org@mail.gmail.com>
2012-05-15 16:42                 ` Tom Tromey
2012-05-16 10:48                   ` oza Pawandeep
2012-05-16 14:57                     ` Tom Tromey
2012-06-05  9:16                       ` oza Pawandeep
2012-06-06 18:17                         ` Tom Tromey
2012-06-05  9:19                       ` oza Pawandeep
2012-05-09  9:16 oza Pawandeep

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120514145650.GF10253@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=gdb@sourceware.org \
    --cc=oza.pawandeep@gmail.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).