From: Simon Marchi <simark@simark.ca>
To: Shahab Vahedi <shahab.vahedi@gmail.com>,
Luis Machado <luis.machado@linaro.org>
Cc: gdb@sourceware.org, Shahab Vahedi <shahab@synopsys.com>
Subject: Re: Why enforcing sw_breakpoint_from_kind() implementation in GDBserver targets
Date: Thu, 11 Jun 2020 10:51:04 -0400 [thread overview]
Message-ID: <335e5978-4893-b355-69cd-98a101f8dd2e@simark.ca> (raw)
In-Reply-To: <20200611110053.GD1270@gmail.com>
On 2020-06-11 7:00 a.m., Shahab Vahedi wrote:
> Hi Luis, Simon,
>
> On Thu, Jun 11, 2020 at 07:35:33AM -0300, Luis Machado wrote:
>> On 6/11/20 6:40 AM, Shahab Vahedi via Gdb wrote:
>>> Hi Simon,
>>>
>>> The ARC GDB client inserts the breakpoint by writing to memory (the
>>> legacy way). With your explanations, I plan to add the Z0 packet
>>> support to it. Nevertheless, should it be still necessary to have
>>> "sw_breakpoint_from_kind" in GDBserver as a mandatory method?
>
> Simon, I thought about this a little. Are we aiming for deprecating
> the old way? Then I guess that's the way to go.
If all the gdbserver targets we support do support Z0, then yes I think
we could consider doing that. How would we do it? Make insert_point
and remove_point virtual pure to force sub-classes to implement them
with something meaningful?
Note that this would only concern GDBserver, other server implementations
of the remote protocol are free to support Z0 or not. But we could decide
that all GDBserver ports have to support it.
Simon
next prev parent reply other threads:[~2020-06-11 14:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 17:47 Shahab Vahedi
2020-06-11 3:05 ` Simon Marchi
2020-06-11 9:40 ` Shahab Vahedi
2020-06-11 10:35 ` Luis Machado
2020-06-11 11:00 ` Shahab Vahedi
2020-06-11 11:44 ` Shahab Vahedi
2020-06-12 11:04 ` Aktemur, Tankut Baris
2020-06-15 10:39 ` Shahab Vahedi
2020-06-16 13:15 ` Aktemur, Tankut Baris
2020-06-17 21:31 ` Shahab Vahedi
2020-06-17 22:20 ` Luis Machado
2020-06-11 14:51 ` Simon Marchi [this message]
2020-06-15 8:54 ` Metzger, Markus T
2020-06-17 0:40 ` Maciej W. Rozycki
2020-06-18 8:11 ` Metzger, Markus T
2020-06-18 9:13 ` Maciej W. Rozycki
2020-06-18 10:29 ` Metzger, Markus T
2020-06-18 11:03 ` Maciej W. Rozycki
2020-06-18 11:11 ` Metzger, Markus T
2020-06-11 21:21 ` Martin Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=335e5978-4893-b355-69cd-98a101f8dd2e@simark.ca \
--to=simark@simark.ca \
--cc=gdb@sourceware.org \
--cc=luis.machado@linaro.org \
--cc=shahab.vahedi@gmail.com \
--cc=shahab@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).