From: "Metzger, Markus T" <markus.t.metzger@intel.com>
To: "Maciej W. Rozycki" <macro@wdc.com>
Cc: Simon Marchi <simark@simark.ca>,
Shahab Vahedi <shahab.vahedi@gmail.com>,
Luis Machado <luis.machado@linaro.org>,
"gdb@sourceware.org" <gdb@sourceware.org>,
Shahab Vahedi <shahab@synopsys.com>
Subject: RE: Why enforcing sw_breakpoint_from_kind() implementation in GDBserver targets
Date: Thu, 18 Jun 2020 11:11:44 +0000 [thread overview]
Message-ID: <DM5PR11MB1690E34AE1B7CDA9B3CBDBB3DE9B0@DM5PR11MB1690.namprd11.prod.outlook.com> (raw)
In-Reply-To: <alpine.LFD.2.21.2006181154170.9519@redsun52.ssa.fujisawa.hgst.com>
Hello Maciej,
> > The breakpoint kind would depend on the ISA. And we'd have a real lot of
> them.
>
> Well, that's just one interpretation. The breakpoint kind is really a
> generic cookie each target is free to give any interpretation to. There
> is no processing of this data I know of in common GDB or `gdbserver' code.
That's how I had interpreted it. I thought you suggested defining one kind per
instruction/operand so the kind would encode the original instruction to restore.
> > I don't think that we'd want to encode the original instruction in the breakpoint
> > kind. That's what the shadow copy inside the breakpoint object is for.
>
> I thought you wrote you had had to choose not to use `z0'/`Z0' packets
> due to the inability to utilise the breakpoint bits this way. Maybe I got
> this wrong.
The issue is that the breakpoint struct is opaque and there is no API to access
the shadow copy storage from a target's insert_point() function.
This can be changed, of course. I did not look into it because gdbarch breakpoint
methods worked for me.
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2020-06-18 11:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 17:47 Shahab Vahedi
2020-06-11 3:05 ` Simon Marchi
2020-06-11 9:40 ` Shahab Vahedi
2020-06-11 10:35 ` Luis Machado
2020-06-11 11:00 ` Shahab Vahedi
2020-06-11 11:44 ` Shahab Vahedi
2020-06-12 11:04 ` Aktemur, Tankut Baris
2020-06-15 10:39 ` Shahab Vahedi
2020-06-16 13:15 ` Aktemur, Tankut Baris
2020-06-17 21:31 ` Shahab Vahedi
2020-06-17 22:20 ` Luis Machado
2020-06-11 14:51 ` Simon Marchi
2020-06-15 8:54 ` Metzger, Markus T
2020-06-17 0:40 ` Maciej W. Rozycki
2020-06-18 8:11 ` Metzger, Markus T
2020-06-18 9:13 ` Maciej W. Rozycki
2020-06-18 10:29 ` Metzger, Markus T
2020-06-18 11:03 ` Maciej W. Rozycki
2020-06-18 11:11 ` Metzger, Markus T [this message]
2020-06-11 21:21 ` Martin Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR11MB1690E34AE1B7CDA9B3CBDBB3DE9B0@DM5PR11MB1690.namprd11.prod.outlook.com \
--to=markus.t.metzger@intel.com \
--cc=gdb@sourceware.org \
--cc=luis.machado@linaro.org \
--cc=macro@wdc.com \
--cc=shahab.vahedi@gmail.com \
--cc=shahab@synopsys.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).