From: Martin Simmons <qqxnjvamvxwx@dyxyl.com>
To: Shahab Vahedi <shahab.vahedi@gmail.com>
Cc: gdb@sourceware.org,shahab@synopsys.com
Subject: Re: Why enforcing sw_breakpoint_from_kind() implementation in GDBserver targets
Date: Thu, 11 Jun 2020 22:21:21 +0100 [thread overview]
Message-ID: <jebllpxpri.fsf@dyxyl.com> (raw)
In-Reply-To: <20200610174702.GA3486@gmail.com> (message from Shahab Vahedi via Gdb on Wed, 10 Jun 2020 19:47:02 +0200)
>>>>> On Wed, 10 Jun 2020 19:47:02 +0200, Shahab Vahedi via Gdb said:
>
> Last but not least, one nitpick: Even though I have added the
> implementation of "sw_breakpoint_from_kind", I have never done so for
> "breakpoint_kind_from_pc" or "breakpoint_kind_from_current_state".
> These last two are supposed to provide the "kind" that will be the
> input parameter for "sw_breakpoint_from_kind". Therefore, even if the
> new piece of "sw_breakpoint_from_kind" would be executed, that would be
> problematic. I'm not sure what can be done about this but I think _if_
> "sw_breakpoint_from_kind" should be mandatory, so are
> "breakpoint_kind_from_pc" and "breakpoint_kind_from_current_state".
"breakpoint_kind_from_pc" and "breakpoint_kind_from_current_state" have
default implementations in gdbserver/target.cc so there is no need to
make them mandatory.
__Martin
prev parent reply other threads:[~2020-06-11 21:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 17:47 Shahab Vahedi
2020-06-11 3:05 ` Simon Marchi
2020-06-11 9:40 ` Shahab Vahedi
2020-06-11 10:35 ` Luis Machado
2020-06-11 11:00 ` Shahab Vahedi
2020-06-11 11:44 ` Shahab Vahedi
2020-06-12 11:04 ` Aktemur, Tankut Baris
2020-06-15 10:39 ` Shahab Vahedi
2020-06-16 13:15 ` Aktemur, Tankut Baris
2020-06-17 21:31 ` Shahab Vahedi
2020-06-17 22:20 ` Luis Machado
2020-06-11 14:51 ` Simon Marchi
2020-06-15 8:54 ` Metzger, Markus T
2020-06-17 0:40 ` Maciej W. Rozycki
2020-06-18 8:11 ` Metzger, Markus T
2020-06-18 9:13 ` Maciej W. Rozycki
2020-06-18 10:29 ` Metzger, Markus T
2020-06-18 11:03 ` Maciej W. Rozycki
2020-06-18 11:11 ` Metzger, Markus T
2020-06-11 21:21 ` Martin Simmons [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jebllpxpri.fsf@dyxyl.com \
--to=qqxnjvamvxwx@dyxyl.com \
--cc=gdb@sourceware.org \
--cc=shahab.vahedi@gmail.com \
--cc=shahab@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).