From: Mark Wielaard <mark@klomp.org>
To: Luis Machado <luis.machado@arm.com>,
Andrew Burgess <aburgess@redhat.com>
Cc: Simon Marchi <simark@simark.ca>,
Joel Brobecker <brobecker@adacore.com>,
Simon Marchi via Gdb <gdb@sourceware.org>
Subject: Re: Any concrete plans after the GDB BoF?
Date: Tue, 14 Feb 2023 14:07:11 +0100 [thread overview]
Message-ID: <35786a0df754fb97b59e460e6da9afc6f9b8c95c.camel@klomp.org> (raw)
In-Reply-To: <65409b73-fc6d-9a89-3541-31eb1a0b0791@arm.com>
Hi Luis,
On Mon, 2023-02-13 at 12:52 +0000, Luis Machado wrote:
> I suppose that's the point of introducing auto-formatters. If some incorrect formatting is
> pushed alongside some code, it is not a big deal. But having to manually chase some format and fix it by hand (as we do now)
> before it can go in is potentially worse.
>
> It is also a burden for reviewing. It doesn't seem like the kind of thing people should be doing manually at
> this point in time.
Note that builder.sourceware.org can help with that. If you push a
patch to a try builder then the gdb-try-fedora-x86_64 builder will run
python black over it (and fail and put a format diff in the output log
if it doesn't match):
https://sourceware.org/git/?p=builder.git;a=blob;f=builder/master.cfg;hb=HEAD#l2735
I am hoping we can automate that with patchwork so that patches will
get a fail marker if they don't pass the format checker.
Cheers,
Mark
next prev parent reply other threads:[~2023-02-14 13:07 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 10:47 Luis Machado
2022-10-28 16:16 ` Simon Marchi
2022-10-28 16:51 ` John Baldwin
2022-10-28 16:54 ` Simon Marchi
2022-10-31 9:28 ` Luis Machado
2022-10-31 13:17 ` Simon Marchi
2022-10-31 13:37 ` Joel Brobecker
2022-10-31 14:15 ` Simon Marchi
2022-10-31 17:31 ` Joel Brobecker
2023-02-11 17:13 ` Andrew Burgess
2023-02-12 12:43 ` Mark Wielaard
2023-02-13 11:54 ` Andrew Burgess
2023-02-13 12:52 ` Luis Machado
2023-02-13 14:24 ` Tom Tromey
2023-02-13 14:42 ` Luis Machado
2023-02-13 15:13 ` Andrew Burgess
2023-02-13 15:23 ` Luis Machado
2023-02-14 5:48 ` Joel Brobecker
2023-02-15 14:47 ` Andrew Burgess
2023-02-16 4:14 ` Joel Brobecker
2023-02-16 9:51 ` Mark Wielaard
2023-02-16 10:16 ` Joel Brobecker
2023-02-16 11:58 ` Eli Zaretskii
2023-02-16 13:31 ` Joel Brobecker
2023-02-16 15:23 ` Eli Zaretskii
2023-02-14 13:07 ` Mark Wielaard [this message]
2023-02-14 14:23 ` Pedro Alves
2023-02-14 13:00 ` Mark Wielaard
2023-02-15 14:36 ` Andrew Burgess
2023-02-13 14:05 ` Tom Tromey
2022-12-15 10:17 ` Luis Machado
2023-01-01 22:02 ` Mark Wielaard
2023-01-20 17:30 ` Tom Tromey
2023-01-20 20:30 ` Tom Tromey
2023-01-27 15:50 ` Lancelot SIX
2023-01-27 23:50 ` Tom Tromey
2023-01-30 17:43 ` Lancelot SIX
2023-01-30 18:46 ` Mark Wielaard
2023-01-30 21:08 ` Tom Tromey
2023-02-04 11:36 ` Mark Wielaard
2023-01-31 10:00 ` Lancelot SIX
2022-12-13 2:48 ` Frank Ch. Eigler
2023-02-16 8:53 anix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35786a0df754fb97b59e460e6da9afc6f9b8c95c.camel@klomp.org \
--to=mark@klomp.org \
--cc=aburgess@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb@sourceware.org \
--cc=luis.machado@arm.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).