From: Simon Marchi <simark@simark.ca>
To: Luis Machado <luis.machado@arm.com>,
"gdb@sourceware.org" <gdb@sourceware.org>
Cc: Mark Wielaard <mark@klomp.org>
Subject: Re: Any concrete plans after the GDB BoF?
Date: Fri, 28 Oct 2022 12:16:34 -0400 [thread overview]
Message-ID: <c6d6eee0-8ff6-f79e-cafe-d111cb4ac909@simark.ca> (raw)
In-Reply-To: <83485199-965e-7ff5-1dc8-d027b74b56f7@arm.com>
On 2022-10-27 06 h 47, Luis Machado via Gdb wrote:
> Hi,
>
> Having suggested a few topics for the GDB BoF (I noticed they were discussed, to some extent), are there
> any concrete plans from the GDB global maintainers (leadership? I don't know how to call it) to address
> some of those concerns?
>
> Simon was kind enough to cleanup the patchworks instance, though that is not yet fully integrated into
> something we can easily use to do tests/CI. I see the number of unreviewed patches is growing again.
>
> For example, it is not easy to pick a patch to review. You need to locate the entry in your inbox so you
> can reply to it.
I do not know of a way to trigger CI tests from Patchwork, that would
perhaps be a question for Mark (added in CC).
On a personal note, coming back from the Cauldron, I set myself a goal
to do more reviews as part of my daily work. I'm trying to do around 1
hour a day of upstream reviews, and to choose what to review, I use
patchwork, sorting patches by oldest date. I check if the patch I'm
looking at has already been reviewed, merged, or superseded by a new
version, and if so I update its status. Rinse and repeat until I find a
patch that needs reviewing. Otherwise, just looking at my inbox's
gdb-patches folder with thousands of unread messages, I don't know what
to start with. Just by myself, I certainly won't get through the whole
list of patches pending review, but I think it is a somewhat fair
algorithm. So in that regard, patchwork is useful for me.
I wanted to send an announcement on the list to say "hey, patchwork has
been cleaned, let's use it!", but I have been procrastinating since I
came back.
> On formatting, have we considered the benefit of using clang-format for GDB, therefore potentially saving lots of time
> in reviews not having to worry about formatting?
This often comes up, I am all for it. We need someone to write up a
proposal of how this would work (a bit like Bruno did for the
attribution tags). I might get to it, but I don't promise anything.
Simon
next prev parent reply other threads:[~2022-10-28 16:16 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 10:47 Luis Machado
2022-10-28 16:16 ` Simon Marchi [this message]
2022-10-28 16:51 ` John Baldwin
2022-10-28 16:54 ` Simon Marchi
2022-10-31 9:28 ` Luis Machado
2022-10-31 13:17 ` Simon Marchi
2022-10-31 13:37 ` Joel Brobecker
2022-10-31 14:15 ` Simon Marchi
2022-10-31 17:31 ` Joel Brobecker
2023-02-11 17:13 ` Andrew Burgess
2023-02-12 12:43 ` Mark Wielaard
2023-02-13 11:54 ` Andrew Burgess
2023-02-13 12:52 ` Luis Machado
2023-02-13 14:24 ` Tom Tromey
2023-02-13 14:42 ` Luis Machado
2023-02-13 15:13 ` Andrew Burgess
2023-02-13 15:23 ` Luis Machado
2023-02-14 5:48 ` Joel Brobecker
2023-02-15 14:47 ` Andrew Burgess
2023-02-16 4:14 ` Joel Brobecker
2023-02-16 9:51 ` Mark Wielaard
2023-02-16 10:16 ` Joel Brobecker
2023-02-16 11:58 ` Eli Zaretskii
2023-02-16 13:31 ` Joel Brobecker
2023-02-16 15:23 ` Eli Zaretskii
2023-02-14 13:07 ` Mark Wielaard
2023-02-14 14:23 ` Pedro Alves
2023-02-14 13:00 ` Mark Wielaard
2023-02-15 14:36 ` Andrew Burgess
2023-02-13 14:05 ` Tom Tromey
2022-12-15 10:17 ` Luis Machado
2023-01-01 22:02 ` Mark Wielaard
2023-01-20 17:30 ` Tom Tromey
2023-01-20 20:30 ` Tom Tromey
2023-01-27 15:50 ` Lancelot SIX
2023-01-27 23:50 ` Tom Tromey
2023-01-30 17:43 ` Lancelot SIX
2023-01-30 18:46 ` Mark Wielaard
2023-01-30 21:08 ` Tom Tromey
2023-02-04 11:36 ` Mark Wielaard
2023-01-31 10:00 ` Lancelot SIX
2022-12-13 2:48 ` Frank Ch. Eigler
2023-02-16 8:53 anix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6d6eee0-8ff6-f79e-cafe-d111cb4ac909@simark.ca \
--to=simark@simark.ca \
--cc=gdb@sourceware.org \
--cc=luis.machado@arm.com \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).