From: Andrew Burgess <aburgess@redhat.com>
To: Mark Wielaard <mark@klomp.org>
Cc: Simon Marchi <simark@simark.ca>,
Joel Brobecker <brobecker@adacore.com>,
Simon Marchi via Gdb <gdb@sourceware.org>
Subject: Re: Any concrete plans after the GDB BoF?
Date: Wed, 15 Feb 2023 14:36:48 +0000 [thread overview]
Message-ID: <873577m1vj.fsf@redhat.com> (raw)
In-Reply-To: <a53fe9a7ba70c34cd239e89f736a6a91e60a04b0.camel@klomp.org>
Mark Wielaard <mark@klomp.org> writes:
> Hi Andrew,
>
> On Mon, 2023-02-13 at 11:54 +0000, Andrew Burgess wrote:
>> Mark Wielaard <mark@klomp.org> writes:
>>
>> > But is there already a verions that works? I think that is the
>> > difference between the python black formatter for python code and the
>> > clang-format for C and C++ code. It seems for the python code there is
>> > a supported format that matches what is used, but for clang-format
>> > there is not (yet?).
>>
>> I'm a little confused by your point here. You (correctly) point out
>> above that the output from black is pretty stable across versions.
>>
>> But here it almost seems like you're suggesting that we should chase the
>> latest clang-format because it doesn't (currently) support the style we
>> use. Which would seem to suggest we are hoping it _will_ change, which
>> suggests output instability, which, surely, is a bad thing? But like I
>> said, I didn't really understand the question here...
>
> Sorry, I was just observing that I believe the python with black case
> and the C and C++ case with clang-format are not the same. I think we
> are in agreement that the python case is probably fine
Just for the record, my concerns about using a tool to format C/C++ code
hold just as much for Python (i.e. I don't really think our current use
of black is "fine"), but I just don't care enough to express an opinion
(before now).
> (we just
> disagree about whether it is future proof - I think we can use whatever
> version of black, you are skeptical that the formatting will stay the
> same). But for clang-format we don't have a format that seems
> acceptable (to at least to some people) and older versions seems to
> produce different formatting from newer versions.
I'd assumed the output of clang-format would be mostly stable, if that's
known not to be true then I think that's a stronger argument for using a
known version.
Thanks,
Andrew
next prev parent reply other threads:[~2023-02-15 14:36 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 10:47 Luis Machado
2022-10-28 16:16 ` Simon Marchi
2022-10-28 16:51 ` John Baldwin
2022-10-28 16:54 ` Simon Marchi
2022-10-31 9:28 ` Luis Machado
2022-10-31 13:17 ` Simon Marchi
2022-10-31 13:37 ` Joel Brobecker
2022-10-31 14:15 ` Simon Marchi
2022-10-31 17:31 ` Joel Brobecker
2023-02-11 17:13 ` Andrew Burgess
2023-02-12 12:43 ` Mark Wielaard
2023-02-13 11:54 ` Andrew Burgess
2023-02-13 12:52 ` Luis Machado
2023-02-13 14:24 ` Tom Tromey
2023-02-13 14:42 ` Luis Machado
2023-02-13 15:13 ` Andrew Burgess
2023-02-13 15:23 ` Luis Machado
2023-02-14 5:48 ` Joel Brobecker
2023-02-15 14:47 ` Andrew Burgess
2023-02-16 4:14 ` Joel Brobecker
2023-02-16 9:51 ` Mark Wielaard
2023-02-16 10:16 ` Joel Brobecker
2023-02-16 11:58 ` Eli Zaretskii
2023-02-16 13:31 ` Joel Brobecker
2023-02-16 15:23 ` Eli Zaretskii
2023-02-14 13:07 ` Mark Wielaard
2023-02-14 14:23 ` Pedro Alves
2023-02-14 13:00 ` Mark Wielaard
2023-02-15 14:36 ` Andrew Burgess [this message]
2023-02-13 14:05 ` Tom Tromey
2022-12-15 10:17 ` Luis Machado
2023-01-01 22:02 ` Mark Wielaard
2023-01-20 17:30 ` Tom Tromey
2023-01-20 20:30 ` Tom Tromey
2023-01-27 15:50 ` Lancelot SIX
2023-01-27 23:50 ` Tom Tromey
2023-01-30 17:43 ` Lancelot SIX
2023-01-30 18:46 ` Mark Wielaard
2023-01-30 21:08 ` Tom Tromey
2023-02-04 11:36 ` Mark Wielaard
2023-01-31 10:00 ` Lancelot SIX
2022-12-13 2:48 ` Frank Ch. Eigler
2023-02-16 8:53 anix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873577m1vj.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb@sourceware.org \
--cc=mark@klomp.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).