[Bug libc/29537] [2.34 regression]: Alignment issue on m68k when using futexes on qemu-user

["adhemerval.zanella at linaro dot org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=29537

--- Comment #2 from Adhemerval Zanella <adhemerval.zanella at linaro dot org> ---
It seems a real issue, but I am puzzled why we have not see any issue so far. I
take mostly runs were done in single-core, where hardware did not enforce
32-bit alignment with atomic operations.

A better change would be to use:

diff --git a/sysdeps/nptl/libc-lockP.h b/sysdeps/nptl/libc-lockP.h
index d3a6837fd2..9efe962588 100644
--- a/sysdeps/nptl/libc-lockP.h
+++ b/sysdeps/nptl/libc-lockP.h
@@ -34,7 +34,7 @@
 #include <tls.h>

 /* Mutex type.  */
-typedef int __libc_lock_t;
+typedef int __libc_lock_t __LOCK_ALIGNMENT;
 typedef struct { pthread_mutex_t mutex; } __rtld_lock_recursive_t;
 typedef pthread_rwlock_t __libc_rwlock_t;

Since __LOCK_ALIGNMENT is defined per architecture if required.  The HPPA also
requires a 16-byte alignment for locks, although it is just a historical
artifact to keep compatibility with old implementation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.