* [Bug nptl/30587] FAIL: nptl/tst-cleanupx4 on hppa
2023-06-26 17:11 [Bug nptl/30587] New: FAIL: nptl/tst-cleanupx4 on hppa danglin at gcc dot gnu.org
@ 2023-06-26 17:42 ` sam at gentoo dot org
2023-06-27 14:08 ` fberat at redhat dot com
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: sam at gentoo dot org @ 2023-06-26 17:42 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=30587
Sam James <sam at gentoo dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sam at gentoo dot org,
| |siddhesh at sourceware dot org
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug nptl/30587] FAIL: nptl/tst-cleanupx4 on hppa
2023-06-26 17:11 [Bug nptl/30587] New: FAIL: nptl/tst-cleanupx4 on hppa danglin at gcc dot gnu.org
2023-06-26 17:42 ` [Bug nptl/30587] " sam at gentoo dot org
@ 2023-06-27 14:08 ` fberat at redhat dot com
2023-06-27 14:52 ` dave.anglin at bell dot net
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: fberat at redhat dot com @ 2023-06-27 14:08 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=30587
Frédéric Bérat <fberat at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fberat at redhat dot com
--- Comment #1 from Frédéric Bérat <fberat at redhat dot com> ---
In principle, we could revert the change affecting nptl/tst-cleanup.c but I'm a
bit puzzled by this issue. It looks strange that it affects nptl/tst-cleanupx4
but not nptl/tst-cleanup4. The only difference between the 2 being the linkage.
Would there be a way to get access to some hppa hardware to do some more
investigation ?
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug nptl/30587] FAIL: nptl/tst-cleanupx4 on hppa
2023-06-26 17:11 [Bug nptl/30587] New: FAIL: nptl/tst-cleanupx4 on hppa danglin at gcc dot gnu.org
2023-06-26 17:42 ` [Bug nptl/30587] " sam at gentoo dot org
2023-06-27 14:08 ` fberat at redhat dot com
@ 2023-06-27 14:52 ` dave.anglin at bell dot net
2023-06-27 14:58 ` dave.anglin at bell dot net
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: dave.anglin at bell dot net @ 2023-06-27 14:52 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=30587
--- Comment #2 from dave.anglin at bell dot net ---
On 2023-06-27 10:08 a.m., fberat at redhat dot com wrote:
> Would there be a way to get access to some hppa hardware to do some more
> investigation ?
We have a machine, panama.parisc-linux.org, that is available for development
and testing.
Helge should be able to provide an account.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug nptl/30587] FAIL: nptl/tst-cleanupx4 on hppa
2023-06-26 17:11 [Bug nptl/30587] New: FAIL: nptl/tst-cleanupx4 on hppa danglin at gcc dot gnu.org
` (2 preceding siblings ...)
2023-06-27 14:52 ` dave.anglin at bell dot net
@ 2023-06-27 14:58 ` dave.anglin at bell dot net
2023-06-27 16:02 ` fberat at redhat dot com
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: dave.anglin at bell dot net @ 2023-06-27 14:58 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=30587
--- Comment #3 from dave.anglin at bell dot net ---
On 2023-06-27 10:08 a.m., fberat at redhat dot com wrote:
> In principle, we could revert the change affecting nptl/tst-cleanup.c but I'm a
> bit puzzled by this issue. It looks strange that it affects nptl/tst-cleanupx4
> but not nptl/tst-cleanup4. The only difference between the 2 being the linkage.
Correct, only nptl/tst-cleanupx4 fails after change.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug nptl/30587] FAIL: nptl/tst-cleanupx4 on hppa
2023-06-26 17:11 [Bug nptl/30587] New: FAIL: nptl/tst-cleanupx4 on hppa danglin at gcc dot gnu.org
` (3 preceding siblings ...)
2023-06-27 14:58 ` dave.anglin at bell dot net
@ 2023-06-27 16:02 ` fberat at redhat dot com
2023-06-27 16:45 ` adhemerval.zanella at linaro dot org
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: fberat at redhat dot com @ 2023-06-27 16:02 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=30587
--- Comment #4 from Frédéric Bérat <fberat at redhat dot com> ---
Since I don't have the access yet, I'm looking at the logs:
test 0
clh (2)
global = 2, expected 15
This executes fn2(), which should basically do:
pthread_cleanup_push (clh, (void *) 3l);
_pthread_cleanup_push (&b, clh, (void *) 2l);
pthread_cleanup_push (clh, (void *) 1l);
Whereas, from the output, only `_pthread_cleanup_pop (&b, 1);` seems to be
executed.
The same goes for the following iterations. It looks like only
_pthread_cleanup_pop actions get executed on cancellation.
I don't see how this could be induced by the aforementioned patch.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug nptl/30587] FAIL: nptl/tst-cleanupx4 on hppa
2023-06-26 17:11 [Bug nptl/30587] New: FAIL: nptl/tst-cleanupx4 on hppa danglin at gcc dot gnu.org
` (4 preceding siblings ...)
2023-06-27 16:02 ` fberat at redhat dot com
@ 2023-06-27 16:45 ` adhemerval.zanella at linaro dot org
2023-06-27 17:13 ` sam at gentoo dot org
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: adhemerval.zanella at linaro dot org @ 2023-06-27 16:45 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=30587
Adhemerval Zanella <adhemerval.zanella at linaro dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |adhemerval.zanella at linaro dot o
| |rg
--- Comment #5 from Adhemerval Zanella <adhemerval.zanella at linaro dot org> ---
At least on qemu-user this test fail with or without the
20b6b8e8a50874dd189687df8f6f8a11d4813b34.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug nptl/30587] FAIL: nptl/tst-cleanupx4 on hppa
2023-06-26 17:11 [Bug nptl/30587] New: FAIL: nptl/tst-cleanupx4 on hppa danglin at gcc dot gnu.org
` (5 preceding siblings ...)
2023-06-27 16:45 ` adhemerval.zanella at linaro dot org
@ 2023-06-27 17:13 ` sam at gentoo dot org
2023-06-27 19:09 ` deller at gmx dot de
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: sam at gentoo dot org @ 2023-06-27 17:13 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=30587
Sam James <sam at gentoo dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |deller at gmx dot de
--- Comment #6 from Sam James <sam at gentoo dot org> ---
I can give access to another machine if Helge can't.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug nptl/30587] FAIL: nptl/tst-cleanupx4 on hppa
2023-06-26 17:11 [Bug nptl/30587] New: FAIL: nptl/tst-cleanupx4 on hppa danglin at gcc dot gnu.org
` (6 preceding siblings ...)
2023-06-27 17:13 ` sam at gentoo dot org
@ 2023-06-27 19:09 ` deller at gmx dot de
2023-06-27 20:26 ` dave.anglin at bell dot net
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: deller at gmx dot de @ 2023-06-27 19:09 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=30587
--- Comment #7 from Helge Deller <deller at gmx dot de> ---
(In reply to Frédéric Bérat from comment #1)
> Would there be a way to get access to some hppa hardware to do some more
> investigation ?
Sure. Just send me your preferred login name and your public ssh key and I can
give you access to a machine. In case you have a debian developer key you can
directly log in to panama.parisc-linux.org.
Helge
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug nptl/30587] FAIL: nptl/tst-cleanupx4 on hppa
2023-06-26 17:11 [Bug nptl/30587] New: FAIL: nptl/tst-cleanupx4 on hppa danglin at gcc dot gnu.org
` (7 preceding siblings ...)
2023-06-27 19:09 ` deller at gmx dot de
@ 2023-06-27 20:26 ` dave.anglin at bell dot net
2023-06-28 14:39 ` dave.anglin at bell dot net
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: dave.anglin at bell dot net @ 2023-06-27 20:26 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=30587
--- Comment #8 from dave.anglin at bell dot net ---
On 2023-06-27 12:02 p.m., fberat at redhat dot com wrote:
> https://sourceware.org/bugzilla/show_bug.cgi?id=30587
>
> --- Comment #4 from Frédéric Bérat <fberat at redhat dot com> ---
> Since I don't have the access yet, I'm looking at the logs:
>
> test 0
> clh (2)
> global = 2, expected 15
>
> This executes fn2(), which should basically do:
> pthread_cleanup_push (clh, (void *) 3l);
> _pthread_cleanup_push (&b, clh, (void *) 2l);
> pthread_cleanup_push (clh, (void *) 1l);
>
> Whereas, from the output, only `_pthread_cleanup_pop (&b, 1);` seems to be
> executed.
>
> The same goes for the following iterations. It looks like only
> _pthread_cleanup_pop actions get executed on cancellation.
>
> I don't see how this could be induced by the aforementioned patch.
It seems to me that the sequencing of the cleanups must be timing dependent.
Simply changing
the read in tst-cleanup4.c to xread changes the test result from PASS to FAIL.
The test doesn't fail if xread is moved into tst-cleanup4.c.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug nptl/30587] FAIL: nptl/tst-cleanupx4 on hppa
2023-06-26 17:11 [Bug nptl/30587] New: FAIL: nptl/tst-cleanupx4 on hppa danglin at gcc dot gnu.org
` (8 preceding siblings ...)
2023-06-27 20:26 ` dave.anglin at bell dot net
@ 2023-06-28 14:39 ` dave.anglin at bell dot net
2023-06-28 14:56 ` carlos at redhat dot com
2023-07-01 13:33 ` danglin at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: dave.anglin at bell dot net @ 2023-06-28 14:39 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=30587
--- Comment #9 from dave.anglin at bell dot net ---
On 2023-06-27 4:26 p.m., dave.anglin at bell dot net wrote:
> https://sourceware.org/bugzilla/show_bug.cgi?id=30587
>
> --- Comment #8 from dave.anglin at bell dot net ---
> On 2023-06-27 12:02 p.m., fberat at redhat dot com wrote:
>> https://sourceware.org/bugzilla/show_bug.cgi?id=30587
>>
>> --- Comment #4 from Frédéric Bérat <fberat at redhat dot com> ---
>> Since I don't have the access yet, I'm looking at the logs:
>>
>> test 0
>> clh (2)
>> global = 2, expected 15
>>
>> This executes fn2(), which should basically do:
>> pthread_cleanup_push (clh, (void *) 3l);
>> _pthread_cleanup_push (&b, clh, (void *) 2l);
>> pthread_cleanup_push (clh, (void *) 1l);
>>
>> Whereas, from the output, only `_pthread_cleanup_pop (&b, 1);` seems to be
>> executed.
>>
>> The same goes for the following iterations. It looks like only
>> _pthread_cleanup_pop actions get executed on cancellation.
>>
>> I don't see how this could be induced by the aforementioned patch.
> It seems to me that the sequencing of the cleanups must be timing dependent.
> Simply changing
> the read in tst-cleanup4.c to xread changes the test result from PASS to FAIL.
>
> The test doesn't fail if xread is moved into tst-cleanup4.c.
The problem is xread.c is not compiled with "-fexceptions". The
nptl/tst-cleanupx4 test
passes if xread.c is compiled with "-fexceptions".
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug nptl/30587] FAIL: nptl/tst-cleanupx4 on hppa
2023-06-26 17:11 [Bug nptl/30587] New: FAIL: nptl/tst-cleanupx4 on hppa danglin at gcc dot gnu.org
` (9 preceding siblings ...)
2023-06-28 14:39 ` dave.anglin at bell dot net
@ 2023-06-28 14:56 ` carlos at redhat dot com
2023-07-01 13:33 ` danglin at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: carlos at redhat dot com @ 2023-06-28 14:56 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=30587
Carlos O'Donell <carlos at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |carlos at redhat dot com
--- Comment #10 from Carlos O'Donell <carlos at redhat dot com> ---
(In reply to dave.anglin from comment #9)
> The test doesn't fail if xread is moved into tst-cleanup4.c.
> The problem is xread.c is not compiled with "-fexceptions". The
> nptl/tst-cleanupx4 test
> passes if xread.c is compiled with "-fexceptions".
Then this is not a regression but is a pre-existing problem with libsupport.a.
We need to compile the support routine infrastructure with "-fexceptions
-fasynchronous-unwind-tables" to make sure we can always unwind through the
wrappers which themselves may call functions which we know we can unwind
through.
This needs a patch to fix support/Makefile to add it to all routines.
Dave, Can you please propose a patch to do that?
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug nptl/30587] FAIL: nptl/tst-cleanupx4 on hppa
2023-06-26 17:11 [Bug nptl/30587] New: FAIL: nptl/tst-cleanupx4 on hppa danglin at gcc dot gnu.org
` (10 preceding siblings ...)
2023-06-28 14:56 ` carlos at redhat dot com
@ 2023-07-01 13:33 ` danglin at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: danglin at gcc dot gnu.org @ 2023-07-01 13:33 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=30587
John David Anglin <danglin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #11 from John David Anglin <danglin at gcc dot gnu.org> ---
Fixed on master by commit 1d5024f4f052c12e404d42d3b5bfe9c3e9fd27c4.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread