public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc/azanella/clang] i386: Disable some tests on clang
@ 2024-04-17 20:13 Adhemerval Zanella
  0 siblings, 0 replies; 8+ messages in thread
From: Adhemerval Zanella @ 2024-04-17 20:13 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=cd90ccecee008afcd040177bfd02bb466c0c9300

commit cd90ccecee008afcd040177bfd02bb466c0c9300
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Fri Jul 28 09:34:03 2023 -0300

    i386: Disable some tests on clang
    
    clang generated R_I386_PC32 instead of R_386_PLT32 for static
    ifoo calls, which triggers an ld issues where it can not link
    non-PIC and PIC objects.  This seems to be a clang bug.

Diff:
---
 elf/ifuncmain9.c              | 5 +++++
 sysdeps/x86/tst-ifunc-isa-1.c | 5 +++++
 sysdeps/x86/tst-ifunc-isa-2.c | 4 ++++
 3 files changed, 14 insertions(+)

diff --git a/elf/ifuncmain9.c b/elf/ifuncmain9.c
index a13020dc6d..ed9c5a5d86 100644
--- a/elf/ifuncmain9.c
+++ b/elf/ifuncmain9.c
@@ -23,6 +23,7 @@
 # include <stdbool.h>
 # include <stdio.h>
 # include <libc-diag.h>
+# include <support/test-driver.h>
 
 /* Do not use the test framework, so that the process setup is not
    disturbed.  */
@@ -57,6 +58,9 @@ DIAG_POP_NEEDS_COMMENT_CLANG;
 int
 main (void)
 {
+#if defined __clang__ && defined __i386__
+  return EXIT_UNSUPPORTED;
+#else
   bool errors = false;
 
   if (implementation_called != 0)
@@ -93,4 +97,5 @@ main (void)
     }
 
   return errors;
+#endif
 }
diff --git a/sysdeps/x86/tst-ifunc-isa-1.c b/sysdeps/x86/tst-ifunc-isa-1.c
index 44726576f1..276efc0572 100644
--- a/sysdeps/x86/tst-ifunc-isa-1.c
+++ b/sysdeps/x86/tst-ifunc-isa-1.c
@@ -17,14 +17,19 @@
    <https://www.gnu.org/licenses/>.  */
 
 #include <stdlib.h>
+#include <support/test-driver.h>
 #include "tst-ifunc-isa.h"
 
 static int
 do_test (void)
 {
+#if defined __clang__ && defined __i386__
+  return EXIT_UNSUPPORTED;
+#else
   enum isa value = foo ();
   enum isa expected = get_isa ();
   return value == expected ? EXIT_SUCCESS : EXIT_FAILURE;
+#endif
 }
 
 #include <support/test-driver.c>
diff --git a/sysdeps/x86/tst-ifunc-isa-2.c b/sysdeps/x86/tst-ifunc-isa-2.c
index 156c649807..130169b614 100644
--- a/sysdeps/x86/tst-ifunc-isa-2.c
+++ b/sysdeps/x86/tst-ifunc-isa-2.c
@@ -23,12 +23,16 @@
 static int
 do_test (void)
 {
+#if defined __clang__ && defined __i386__
+  return EXIT_UNSUPPORTED;
+#else
   /* CPU must support SSE2.  */
   if (!__builtin_cpu_supports ("sse2"))
     return EXIT_UNSUPPORTED;
   enum isa value = foo ();
   /* All ISAs, but SSE2, are disabled by tunables.  */
   return value == sse2 ? EXIT_SUCCESS : EXIT_FAILURE;
+#endif
 }
 
 #include <support/test-driver.c>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [glibc/azanella/clang] i386: Disable some tests on clang
@ 2024-04-02 16:00 Adhemerval Zanella
  0 siblings, 0 replies; 8+ messages in thread
From: Adhemerval Zanella @ 2024-04-02 16:00 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=38831688eaebab0bce550d1a40fc20c8961c7d7e

commit 38831688eaebab0bce550d1a40fc20c8961c7d7e
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Fri Jul 28 09:34:03 2023 -0300

    i386: Disable some tests on clang
    
    clang generated R_I386_PC32 instead of R_386_PLT32 for static
    ifoo calls, which triggers an ld issues where it can not link
    non-PIC and PIC objects.  This seems to be a clang bug.

Diff:
---
 elf/ifuncmain9.c              | 5 +++++
 sysdeps/x86/tst-ifunc-isa-1.c | 5 +++++
 sysdeps/x86/tst-ifunc-isa-2.c | 4 ++++
 3 files changed, 14 insertions(+)

diff --git a/elf/ifuncmain9.c b/elf/ifuncmain9.c
index a13020dc6d..ed9c5a5d86 100644
--- a/elf/ifuncmain9.c
+++ b/elf/ifuncmain9.c
@@ -23,6 +23,7 @@
 # include <stdbool.h>
 # include <stdio.h>
 # include <libc-diag.h>
+# include <support/test-driver.h>
 
 /* Do not use the test framework, so that the process setup is not
    disturbed.  */
@@ -57,6 +58,9 @@ DIAG_POP_NEEDS_COMMENT_CLANG;
 int
 main (void)
 {
+#if defined __clang__ && defined __i386__
+  return EXIT_UNSUPPORTED;
+#else
   bool errors = false;
 
   if (implementation_called != 0)
@@ -93,4 +97,5 @@ main (void)
     }
 
   return errors;
+#endif
 }
diff --git a/sysdeps/x86/tst-ifunc-isa-1.c b/sysdeps/x86/tst-ifunc-isa-1.c
index 44726576f1..276efc0572 100644
--- a/sysdeps/x86/tst-ifunc-isa-1.c
+++ b/sysdeps/x86/tst-ifunc-isa-1.c
@@ -17,14 +17,19 @@
    <https://www.gnu.org/licenses/>.  */
 
 #include <stdlib.h>
+#include <support/test-driver.h>
 #include "tst-ifunc-isa.h"
 
 static int
 do_test (void)
 {
+#if defined __clang__ && defined __i386__
+  return EXIT_UNSUPPORTED;
+#else
   enum isa value = foo ();
   enum isa expected = get_isa ();
   return value == expected ? EXIT_SUCCESS : EXIT_FAILURE;
+#endif
 }
 
 #include <support/test-driver.c>
diff --git a/sysdeps/x86/tst-ifunc-isa-2.c b/sysdeps/x86/tst-ifunc-isa-2.c
index 156c649807..130169b614 100644
--- a/sysdeps/x86/tst-ifunc-isa-2.c
+++ b/sysdeps/x86/tst-ifunc-isa-2.c
@@ -23,12 +23,16 @@
 static int
 do_test (void)
 {
+#if defined __clang__ && defined __i386__
+  return EXIT_UNSUPPORTED;
+#else
   /* CPU must support SSE2.  */
   if (!__builtin_cpu_supports ("sse2"))
     return EXIT_UNSUPPORTED;
   enum isa value = foo ();
   /* All ISAs, but SSE2, are disabled by tunables.  */
   return value == sse2 ? EXIT_SUCCESS : EXIT_FAILURE;
+#endif
 }
 
 #include <support/test-driver.c>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [glibc/azanella/clang] i386: Disable some tests on clang
@ 2024-02-09 17:38 Adhemerval Zanella
  0 siblings, 0 replies; 8+ messages in thread
From: Adhemerval Zanella @ 2024-02-09 17:38 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=5ca2ccf69a403bcf6a2f218adeda552daaaaaf7c

commit 5ca2ccf69a403bcf6a2f218adeda552daaaaaf7c
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Fri Jul 28 09:34:03 2023 -0300

    i386: Disable some tests on clang
    
    clang generated R_I386_PC32 instead of R_386_PLT32 for static
    ifoo calls, which triggers an ld issues where it can not link
    non-PIC and PIC objects.  This seems to be a clang bug.

Diff:
---
 elf/ifuncmain9.c              | 5 +++++
 sysdeps/x86/tst-ifunc-isa-1.c | 5 +++++
 sysdeps/x86/tst-ifunc-isa-2.c | 4 ++++
 3 files changed, 14 insertions(+)

diff --git a/elf/ifuncmain9.c b/elf/ifuncmain9.c
index a13020dc6d..ed9c5a5d86 100644
--- a/elf/ifuncmain9.c
+++ b/elf/ifuncmain9.c
@@ -23,6 +23,7 @@
 # include <stdbool.h>
 # include <stdio.h>
 # include <libc-diag.h>
+# include <support/test-driver.h>
 
 /* Do not use the test framework, so that the process setup is not
    disturbed.  */
@@ -57,6 +58,9 @@ DIAG_POP_NEEDS_COMMENT_CLANG;
 int
 main (void)
 {
+#if defined __clang__ && defined __i386__
+  return EXIT_UNSUPPORTED;
+#else
   bool errors = false;
 
   if (implementation_called != 0)
@@ -93,4 +97,5 @@ main (void)
     }
 
   return errors;
+#endif
 }
diff --git a/sysdeps/x86/tst-ifunc-isa-1.c b/sysdeps/x86/tst-ifunc-isa-1.c
index 44726576f1..276efc0572 100644
--- a/sysdeps/x86/tst-ifunc-isa-1.c
+++ b/sysdeps/x86/tst-ifunc-isa-1.c
@@ -17,14 +17,19 @@
    <https://www.gnu.org/licenses/>.  */
 
 #include <stdlib.h>
+#include <support/test-driver.h>
 #include "tst-ifunc-isa.h"
 
 static int
 do_test (void)
 {
+#if defined __clang__ && defined __i386__
+  return EXIT_UNSUPPORTED;
+#else
   enum isa value = foo ();
   enum isa expected = get_isa ();
   return value == expected ? EXIT_SUCCESS : EXIT_FAILURE;
+#endif
 }
 
 #include <support/test-driver.c>
diff --git a/sysdeps/x86/tst-ifunc-isa-2.c b/sysdeps/x86/tst-ifunc-isa-2.c
index 156c649807..130169b614 100644
--- a/sysdeps/x86/tst-ifunc-isa-2.c
+++ b/sysdeps/x86/tst-ifunc-isa-2.c
@@ -23,12 +23,16 @@
 static int
 do_test (void)
 {
+#if defined __clang__ && defined __i386__
+  return EXIT_UNSUPPORTED;
+#else
   /* CPU must support SSE2.  */
   if (!__builtin_cpu_supports ("sse2"))
     return EXIT_UNSUPPORTED;
   enum isa value = foo ();
   /* All ISAs, but SSE2, are disabled by tunables.  */
   return value == sse2 ? EXIT_SUCCESS : EXIT_FAILURE;
+#endif
 }
 
 #include <support/test-driver.c>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [glibc/azanella/clang] i386: Disable some tests on clang
@ 2024-02-07 14:13 Adhemerval Zanella
  0 siblings, 0 replies; 8+ messages in thread
From: Adhemerval Zanella @ 2024-02-07 14:13 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=1b26bfdceac9bcccafb0f1e047845367581e87b2

commit 1b26bfdceac9bcccafb0f1e047845367581e87b2
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Fri Jul 28 09:34:03 2023 -0300

    i386: Disable some tests on clang
    
    clang generated R_I386_PC32 instead of R_386_PLT32 for static
    ifoo calls, which triggers an ld issues where it can not link
    non-PIC and PIC objects.  This seems to be a clang bug.

Diff:
---
 elf/ifuncmain9.c              | 5 +++++
 sysdeps/x86/tst-ifunc-isa-1.c | 5 +++++
 sysdeps/x86/tst-ifunc-isa-2.c | 4 ++++
 3 files changed, 14 insertions(+)

diff --git a/elf/ifuncmain9.c b/elf/ifuncmain9.c
index a13020dc6d..ed9c5a5d86 100644
--- a/elf/ifuncmain9.c
+++ b/elf/ifuncmain9.c
@@ -23,6 +23,7 @@
 # include <stdbool.h>
 # include <stdio.h>
 # include <libc-diag.h>
+# include <support/test-driver.h>
 
 /* Do not use the test framework, so that the process setup is not
    disturbed.  */
@@ -57,6 +58,9 @@ DIAG_POP_NEEDS_COMMENT_CLANG;
 int
 main (void)
 {
+#if defined __clang__ && defined __i386__
+  return EXIT_UNSUPPORTED;
+#else
   bool errors = false;
 
   if (implementation_called != 0)
@@ -93,4 +97,5 @@ main (void)
     }
 
   return errors;
+#endif
 }
diff --git a/sysdeps/x86/tst-ifunc-isa-1.c b/sysdeps/x86/tst-ifunc-isa-1.c
index 44726576f1..276efc0572 100644
--- a/sysdeps/x86/tst-ifunc-isa-1.c
+++ b/sysdeps/x86/tst-ifunc-isa-1.c
@@ -17,14 +17,19 @@
    <https://www.gnu.org/licenses/>.  */
 
 #include <stdlib.h>
+#include <support/test-driver.h>
 #include "tst-ifunc-isa.h"
 
 static int
 do_test (void)
 {
+#if defined __clang__ && defined __i386__
+  return EXIT_UNSUPPORTED;
+#else
   enum isa value = foo ();
   enum isa expected = get_isa ();
   return value == expected ? EXIT_SUCCESS : EXIT_FAILURE;
+#endif
 }
 
 #include <support/test-driver.c>
diff --git a/sysdeps/x86/tst-ifunc-isa-2.c b/sysdeps/x86/tst-ifunc-isa-2.c
index 156c649807..130169b614 100644
--- a/sysdeps/x86/tst-ifunc-isa-2.c
+++ b/sysdeps/x86/tst-ifunc-isa-2.c
@@ -23,12 +23,16 @@
 static int
 do_test (void)
 {
+#if defined __clang__ && defined __i386__
+  return EXIT_UNSUPPORTED;
+#else
   /* CPU must support SSE2.  */
   if (!__builtin_cpu_supports ("sse2"))
     return EXIT_UNSUPPORTED;
   enum isa value = foo ();
   /* All ISAs, but SSE2, are disabled by tunables.  */
   return value == sse2 ? EXIT_SUCCESS : EXIT_FAILURE;
+#endif
 }
 
 #include <support/test-driver.c>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [glibc/azanella/clang] i386: Disable some tests on clang
@ 2024-01-29 18:04 Adhemerval Zanella
  0 siblings, 0 replies; 8+ messages in thread
From: Adhemerval Zanella @ 2024-01-29 18:04 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=2919b8e2f476855f4fe6a23f0339f130a6001f88

commit 2919b8e2f476855f4fe6a23f0339f130a6001f88
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Fri Jul 28 09:34:03 2023 -0300

    i386: Disable some tests on clang
    
    clang generated R_I386_PC32 instead of R_386_PLT32 for static
    ifoo calls, which triggers an ld issues where it can not link
    non-PIC and PIC objects.  This seems to be a clang bug.

Diff:
---
 elf/ifuncmain9.c              | 5 +++++
 sysdeps/x86/tst-ifunc-isa-1.c | 5 +++++
 sysdeps/x86/tst-ifunc-isa-2.c | 4 ++++
 3 files changed, 14 insertions(+)

diff --git a/elf/ifuncmain9.c b/elf/ifuncmain9.c
index a13020dc6d..ed9c5a5d86 100644
--- a/elf/ifuncmain9.c
+++ b/elf/ifuncmain9.c
@@ -23,6 +23,7 @@
 # include <stdbool.h>
 # include <stdio.h>
 # include <libc-diag.h>
+# include <support/test-driver.h>
 
 /* Do not use the test framework, so that the process setup is not
    disturbed.  */
@@ -57,6 +58,9 @@ DIAG_POP_NEEDS_COMMENT_CLANG;
 int
 main (void)
 {
+#if defined __clang__ && defined __i386__
+  return EXIT_UNSUPPORTED;
+#else
   bool errors = false;
 
   if (implementation_called != 0)
@@ -93,4 +97,5 @@ main (void)
     }
 
   return errors;
+#endif
 }
diff --git a/sysdeps/x86/tst-ifunc-isa-1.c b/sysdeps/x86/tst-ifunc-isa-1.c
index 44726576f1..276efc0572 100644
--- a/sysdeps/x86/tst-ifunc-isa-1.c
+++ b/sysdeps/x86/tst-ifunc-isa-1.c
@@ -17,14 +17,19 @@
    <https://www.gnu.org/licenses/>.  */
 
 #include <stdlib.h>
+#include <support/test-driver.h>
 #include "tst-ifunc-isa.h"
 
 static int
 do_test (void)
 {
+#if defined __clang__ && defined __i386__
+  return EXIT_UNSUPPORTED;
+#else
   enum isa value = foo ();
   enum isa expected = get_isa ();
   return value == expected ? EXIT_SUCCESS : EXIT_FAILURE;
+#endif
 }
 
 #include <support/test-driver.c>
diff --git a/sysdeps/x86/tst-ifunc-isa-2.c b/sysdeps/x86/tst-ifunc-isa-2.c
index 156c649807..130169b614 100644
--- a/sysdeps/x86/tst-ifunc-isa-2.c
+++ b/sysdeps/x86/tst-ifunc-isa-2.c
@@ -23,12 +23,16 @@
 static int
 do_test (void)
 {
+#if defined __clang__ && defined __i386__
+  return EXIT_UNSUPPORTED;
+#else
   /* CPU must support SSE2.  */
   if (!__builtin_cpu_supports ("sse2"))
     return EXIT_UNSUPPORTED;
   enum isa value = foo ();
   /* All ISAs, but SSE2, are disabled by tunables.  */
   return value == sse2 ? EXIT_SUCCESS : EXIT_FAILURE;
+#endif
 }
 
 #include <support/test-driver.c>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [glibc/azanella/clang] i386: Disable some tests on clang
@ 2023-12-21 19:00 Adhemerval Zanella
  0 siblings, 0 replies; 8+ messages in thread
From: Adhemerval Zanella @ 2023-12-21 19:00 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=cb55b2d645c36adf0bb051ec4b16d8bf0519b897

commit cb55b2d645c36adf0bb051ec4b16d8bf0519b897
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Fri Jul 28 09:34:03 2023 -0300

    i386: Disable some tests on clang
    
    clang generated R_I386_PC32 instead of R_386_PLT32 for static
    ifoo calls, which triggers an ld issues where it can not link
    non-PIC and PIC objects.  This seems to be a clang bug.

Diff:
---
 elf/ifuncmain9.c              | 5 +++++
 sysdeps/x86/tst-ifunc-isa-1.c | 5 +++++
 sysdeps/x86/tst-ifunc-isa-2.c | 4 ++++
 3 files changed, 14 insertions(+)

diff --git a/elf/ifuncmain9.c b/elf/ifuncmain9.c
index 5fa25b6d1c..10659c9938 100644
--- a/elf/ifuncmain9.c
+++ b/elf/ifuncmain9.c
@@ -23,6 +23,7 @@
 # include <stdbool.h>
 # include <stdio.h>
 # include <libc-diag.h>
+# include <support/test-driver.h>
 
 /* Do not use the test framework, so that the process setup is not
    disturbed.  */
@@ -57,6 +58,9 @@ DIAG_POP_NEEDS_COMMENT_CLANG;
 int
 main (void)
 {
+#if defined __clang__ && defined __i386__
+  return EXIT_UNSUPPORTED;
+#else
   bool errors = false;
 
   if (implementation_called != 0)
@@ -93,4 +97,5 @@ main (void)
     }
 
   return errors;
+#endif
 }
diff --git a/sysdeps/x86/tst-ifunc-isa-1.c b/sysdeps/x86/tst-ifunc-isa-1.c
index 94c3944aec..991e70d19e 100644
--- a/sysdeps/x86/tst-ifunc-isa-1.c
+++ b/sysdeps/x86/tst-ifunc-isa-1.c
@@ -17,14 +17,19 @@
    <https://www.gnu.org/licenses/>.  */
 
 #include <stdlib.h>
+#include <support/test-driver.h>
 #include "tst-ifunc-isa.h"
 
 static int
 do_test (void)
 {
+#if defined __clang__ && defined __i386__
+  return EXIT_UNSUPPORTED;
+#else
   enum isa value = foo ();
   enum isa expected = get_isa ();
   return value == expected ? EXIT_SUCCESS : EXIT_FAILURE;
+#endif
 }
 
 #include <support/test-driver.c>
diff --git a/sysdeps/x86/tst-ifunc-isa-2.c b/sysdeps/x86/tst-ifunc-isa-2.c
index 7521bc7c38..93b617844f 100644
--- a/sysdeps/x86/tst-ifunc-isa-2.c
+++ b/sysdeps/x86/tst-ifunc-isa-2.c
@@ -23,12 +23,16 @@
 static int
 do_test (void)
 {
+#if defined __clang__ && defined __i386__
+  return EXIT_UNSUPPORTED;
+#else
   /* CPU must support SSE2.  */
   if (!__builtin_cpu_supports ("sse2"))
     return EXIT_UNSUPPORTED;
   enum isa value = foo ();
   /* All ISAs, but SSE2, are disabled by tunables.  */
   return value == sse2 ? EXIT_SUCCESS : EXIT_FAILURE;
+#endif
 }
 
 #include <support/test-driver.c>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [glibc/azanella/clang] i386: Disable some tests on clang
@ 2023-09-28 17:58 Adhemerval Zanella
  0 siblings, 0 replies; 8+ messages in thread
From: Adhemerval Zanella @ 2023-09-28 17:58 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=69154cbc77cdb79e351386f3598f1ef0a2e7089a

commit 69154cbc77cdb79e351386f3598f1ef0a2e7089a
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Fri Jul 28 09:34:03 2023 -0300

    i386: Disable some tests on clang
    
    clang generated R_I386_PC32 instead of R_386_PLT32 for static
    ifoo calls, which triggers an ld issues where it can not link
    non-PIC and PIC objects.  This seems to be a clang bug.

Diff:
---
 elf/ifuncmain9.c              | 5 +++++
 sysdeps/x86/tst-ifunc-isa-1.c | 5 +++++
 sysdeps/x86/tst-ifunc-isa-2.c | 4 ++++
 3 files changed, 14 insertions(+)

diff --git a/elf/ifuncmain9.c b/elf/ifuncmain9.c
index 5fa25b6d1c..10659c9938 100644
--- a/elf/ifuncmain9.c
+++ b/elf/ifuncmain9.c
@@ -23,6 +23,7 @@
 # include <stdbool.h>
 # include <stdio.h>
 # include <libc-diag.h>
+# include <support/test-driver.h>
 
 /* Do not use the test framework, so that the process setup is not
    disturbed.  */
@@ -57,6 +58,9 @@ DIAG_POP_NEEDS_COMMENT_CLANG;
 int
 main (void)
 {
+#if defined __clang__ && defined __i386__
+  return EXIT_UNSUPPORTED;
+#else
   bool errors = false;
 
   if (implementation_called != 0)
@@ -93,4 +97,5 @@ main (void)
     }
 
   return errors;
+#endif
 }
diff --git a/sysdeps/x86/tst-ifunc-isa-1.c b/sysdeps/x86/tst-ifunc-isa-1.c
index 94c3944aec..991e70d19e 100644
--- a/sysdeps/x86/tst-ifunc-isa-1.c
+++ b/sysdeps/x86/tst-ifunc-isa-1.c
@@ -17,14 +17,19 @@
    <https://www.gnu.org/licenses/>.  */
 
 #include <stdlib.h>
+#include <support/test-driver.h>
 #include "tst-ifunc-isa.h"
 
 static int
 do_test (void)
 {
+#if defined __clang__ && defined __i386__
+  return EXIT_UNSUPPORTED;
+#else
   enum isa value = foo ();
   enum isa expected = get_isa ();
   return value == expected ? EXIT_SUCCESS : EXIT_FAILURE;
+#endif
 }
 
 #include <support/test-driver.c>
diff --git a/sysdeps/x86/tst-ifunc-isa-2.c b/sysdeps/x86/tst-ifunc-isa-2.c
index 7521bc7c38..93b617844f 100644
--- a/sysdeps/x86/tst-ifunc-isa-2.c
+++ b/sysdeps/x86/tst-ifunc-isa-2.c
@@ -23,12 +23,16 @@
 static int
 do_test (void)
 {
+#if defined __clang__ && defined __i386__
+  return EXIT_UNSUPPORTED;
+#else
   /* CPU must support SSE2.  */
   if (!__builtin_cpu_supports ("sse2"))
     return EXIT_UNSUPPORTED;
   enum isa value = foo ();
   /* All ISAs, but SSE2, are disabled by tunables.  */
   return value == sse2 ? EXIT_SUCCESS : EXIT_FAILURE;
+#endif
 }
 
 #include <support/test-driver.c>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [glibc/azanella/clang] i386: Disable some tests on clang
@ 2023-08-30 12:43 Adhemerval Zanella
  0 siblings, 0 replies; 8+ messages in thread
From: Adhemerval Zanella @ 2023-08-30 12:43 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=390439fd8d6520aed04a523774fa93c11241f45d

commit 390439fd8d6520aed04a523774fa93c11241f45d
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Fri Jul 28 09:34:03 2023 -0300

    i386: Disable some tests on clang
    
    clang generated R_I386_PC32 instead of R_386_PLT32 for static
    ifoo calls, which triggers an ld issues where it can not link
    non-PIC and PIC objects.  This seems to be a clang bug.

Diff:
---
 elf/ifuncmain9.c              | 7 ++++++-
 sysdeps/x86/tst-ifunc-isa-1.c | 5 +++++
 sysdeps/x86/tst-ifunc-isa-2.c | 4 ++++
 3 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/elf/ifuncmain9.c b/elf/ifuncmain9.c
index e37c391f02..10659c9938 100644
--- a/elf/ifuncmain9.c
+++ b/elf/ifuncmain9.c
@@ -23,6 +23,7 @@
 # include <stdbool.h>
 # include <stdio.h>
 # include <libc-diag.h>
+# include <support/test-driver.h>
 
 /* Do not use the test framework, so that the process setup is not
    disturbed.  */
@@ -50,13 +51,16 @@ resolver (void)
   ++resolver_called;
   return implementation;
 }
-DIAG_POP_NEEDS_COMMENT_CLANG;
 
 static int magic (void) __attribute__ ((ifunc ("resolver")));
+DIAG_POP_NEEDS_COMMENT_CLANG;
 
 int
 main (void)
 {
+#if defined __clang__ && defined __i386__
+  return EXIT_UNSUPPORTED;
+#else
   bool errors = false;
 
   if (implementation_called != 0)
@@ -93,4 +97,5 @@ main (void)
     }
 
   return errors;
+#endif
 }
diff --git a/sysdeps/x86/tst-ifunc-isa-1.c b/sysdeps/x86/tst-ifunc-isa-1.c
index 94c3944aec..991e70d19e 100644
--- a/sysdeps/x86/tst-ifunc-isa-1.c
+++ b/sysdeps/x86/tst-ifunc-isa-1.c
@@ -17,14 +17,19 @@
    <https://www.gnu.org/licenses/>.  */
 
 #include <stdlib.h>
+#include <support/test-driver.h>
 #include "tst-ifunc-isa.h"
 
 static int
 do_test (void)
 {
+#if defined __clang__ && defined __i386__
+  return EXIT_UNSUPPORTED;
+#else
   enum isa value = foo ();
   enum isa expected = get_isa ();
   return value == expected ? EXIT_SUCCESS : EXIT_FAILURE;
+#endif
 }
 
 #include <support/test-driver.c>
diff --git a/sysdeps/x86/tst-ifunc-isa-2.c b/sysdeps/x86/tst-ifunc-isa-2.c
index 7521bc7c38..93b617844f 100644
--- a/sysdeps/x86/tst-ifunc-isa-2.c
+++ b/sysdeps/x86/tst-ifunc-isa-2.c
@@ -23,12 +23,16 @@
 static int
 do_test (void)
 {
+#if defined __clang__ && defined __i386__
+  return EXIT_UNSUPPORTED;
+#else
   /* CPU must support SSE2.  */
   if (!__builtin_cpu_supports ("sse2"))
     return EXIT_UNSUPPORTED;
   enum isa value = foo ();
   /* All ISAs, but SSE2, are disabled by tunables.  */
   return value == sse2 ? EXIT_SUCCESS : EXIT_FAILURE;
+#endif
 }
 
 #include <support/test-driver.c>

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2024-04-17 20:13 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-17 20:13 [glibc/azanella/clang] i386: Disable some tests on clang Adhemerval Zanella
  -- strict thread matches above, loose matches on Subject: below --
2024-04-02 16:00 Adhemerval Zanella
2024-02-09 17:38 Adhemerval Zanella
2024-02-07 14:13 Adhemerval Zanella
2024-01-29 18:04 Adhemerval Zanella
2023-12-21 19:00 Adhemerval Zanella
2023-09-28 17:58 Adhemerval Zanella
2023-08-30 12:43 Adhemerval Zanella

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).