* Re: too many 'changed' entries
2003-03-27 18:19 ` Mel Hatzis
@ 2003-03-28 16:57 ` Dirk Schenkewitz
2003-04-29 21:05 ` Yngve Svendsen
2003-05-07 17:05 ` Dirk Schenkewitz
2 siblings, 0 replies; 6+ messages in thread
From: Dirk Schenkewitz @ 2003-03-28 16:57 UTC (permalink / raw)
To: Mel Hatzis, help-gnats
Mel Hatzis schrieb:
>
> On 03/27/2003 06:04 AM, Dirk Schenkewitz submitted:
>
> >Dirk Schenkewitz schrieb:
> >
> >
> >>Hi All,
> >>
> >>Can someone give me a hint to get rid of this:
> >>
> >>Every time a PR is edited (via Gnatsweb) it happens that stuff is noted as
> >>'changed' in the Audit-Trail, although the only "change" was the formatting,
> >>and even there the user did not change anything - all of this happens auto-
> >>matically.
> >>
> >>As an example, here is something I found in one audit-trail.
> >>/
> >>| Description-Changed-From-To: In einer Mehrfachauswahl wird auf einen String mit einem '#D ' abgefragt. Entspricht der Wert,
> >>| verläuft zunächst alles gut. Entspricht der Wert nicht und muss er nur überlesen werden, kommt Fehler: Variable Konstante
> >>| erwartet.
> >>| ->In einer Mehrfachauswahl wird auf einen String mit einem '#D
> >>| ' abgefragt. Entspricht der Wert, verläuft zunächst alles
> >>| gut. Entspricht der Wert nicht und muss er nur überlesen
> >>| werden, kommt Fehler: Variable Konstante erwartet.
> >>\
> >>
> >>We're using Gnatsweb v3.99.3, Gnats v4.0-beta1 (taken from the GnatsWeb
> >>display) - is this a known bug which can be removed by updating, perhaps ?
> >>Or did I make a configuration mistake ?
(browser related stuff deleted)
> >Has nobody else observed this ?
> >(Please, people, give me a hint, even if it is something obvious -
> >right now i'm just out of ideas.)
> >
> I noticed this too. In my case, I setup a field as 'required' and
> it wasn't working via gnatsweb, because gnatsweb was inserting a
> newline (thereby making the field look like it had a value).
>
> I fixed it by changing the 'fix_multiline_val' sub, as follows:
>
> sub fix_multiline_val
> {
> my $val = shift;
> $val =~ s/\r\n?/\n/g;
> $val .= "\n" unless $val =~ /\n$/;
> if ($val =~ /^\s*$/)
> {
> # don't allow whitespace values to circumvent 'required' fields
> $val = "";
> }
> $val;
> }
>
> This basically prevents whitespace only values from being entered
> as the (multiline) field value which I consider to be a good fix.
Absolutely.
> This should help you in the case where a newly created PR is edited
> for the first time - since this is when gnatsweb will add the
> newline, thereby changing the field and adding a change log to the
> audit trail.
Weird observation, perhaps pure chance and completely unrelated, but
- it seems to remove even my problem, which also happens when there
already is something in a field. I have no idea what is going on.
> Hope this helps.
It did, so far! I'm not sure if I can believe that it's gone forever.
But right now it seems to be. (Even if it comes back, now I have an
idea where to tweak things.)
Thanks a lot, I owe you a beer, at least. :-)
Have fun
dirk
--
Dirk Schenkewitz
InterFace AG fon: +49 (0)89 / 610 49 - 126
Leipziger Str. 16 fax: +49 (0)89 / 610 49 - 83
D-82008 Unterhaching
http://www.interface-ag.de mailto:dirk.schenkewitz@interface-ag.de
_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://mail.gnu.org/mailman/listinfo/help-gnats
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: too many 'changed' entries
2003-03-27 18:19 ` Mel Hatzis
2003-03-28 16:57 ` Dirk Schenkewitz
@ 2003-04-29 21:05 ` Yngve Svendsen
2003-05-07 17:05 ` Dirk Schenkewitz
2 siblings, 0 replies; 6+ messages in thread
From: Yngve Svendsen @ 2003-04-29 21:05 UTC (permalink / raw)
To: Mel Hatzis, Dirk Schenkewitz; +Cc: help-gnats
At 10:15 27.03.2003 -0800, Mel Hatzis wrote:
>I noticed this too. In my case, I setup a field as 'required' and
>it wasn't working via gnatsweb, because gnatsweb was inserting a
>newline (thereby making the field look like it had a value).
>
>I fixed it by changing the 'fix_multiline_val' sub, as follows:
(snip)
>This basically prevents whitespace only values from being entered
>as the (multiline) field value which I consider to be a good fix.
>
>This should help you in the case where a newly created PR is edited
>for the first time - since this is when gnatsweb will add the
>newline, thereby changing the field and adding a change log to the
>audit trail.
Nice catch. I have committed the fix. Of course, Gnatsweb's somewhat
reckless sprinkling of newlines should itself be cleaned up, but I dare not
do it for 4.0 after seeing what removing one apparently extraneous newline
did to attachment handling.
- Yngve
_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://mail.gnu.org/mailman/listinfo/help-gnats
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: too many 'changed' entries
2003-03-27 18:19 ` Mel Hatzis
2003-03-28 16:57 ` Dirk Schenkewitz
2003-04-29 21:05 ` Yngve Svendsen
@ 2003-05-07 17:05 ` Dirk Schenkewitz
2 siblings, 0 replies; 6+ messages in thread
From: Dirk Schenkewitz @ 2003-05-07 17:05 UTC (permalink / raw)
To: help-gnats
[-- Attachment #1: Type: text/plain, Size: 2318 bytes --]
Hi All,
I finally found out the reason & solved my own problem.
Thank you very much, Mel, for turning me in the right direction!
Mel Hatzis wrote:
>
> On 03/27/2003 06:04 AM, Dirk Schenkewitz submitted:
>
> > ...
>
> I noticed this too. In my case, I setup a field as 'required' and
> it wasn't working via gnatsweb, because gnatsweb was inserting a
> newline (thereby making the field look like it had a value).
>
> I fixed it by changing the 'fix_multiline_val' sub, as follows:
>
> sub fix_multiline_val
> {
> my $val = shift;
> $val =~ s/\r\n?/\n/g;
> $val .= "\n" unless $val =~ /\n$/;
> if ($val =~ /^\s*$/)
> {
> # don't allow whitespace values to circumvent 'required' fields
> $val = "";
> }
> $val;
> }
>
> This basically prevents whitespace only values from being entered
> as the (multiline) field value which I consider to be a good fix.
>
> This should help you in the case where a newly created PR is edited
> for the first time - since this is when gnatsweb will add the
> newline, thereby changing the field and adding a change log to the
> audit trail.
>
> Hope this helps.
It did, although not completely. Now I know that I caused the problem
by myself, by adding "-wrap=>'hard'" to the edit-fields. This was done
to preserve the format of an PR, esp. user-added line-breaks. Without
it I found no way to distinguish between user-added and gnatsweb-added
line-breaks. But it caused the following strange behaviour:
- a soft linebreak was inserted as a single <CR><LF> sequence.
- a hard (user-added) linebreak was inserted as <CR><LF><CR><LF><CR><LF>.
I found no way to avoid that. Finally I changed 'fix_multiline_val'
into the attached one. From then on, everything worked like I wanted:
- Soft linebreaks do not make it into the PR
- Hard linebreaks go into the PR as-is.
I send this to the list just in case someone else wants this behaviour
or stumbles over it. It's not a Gnatsweb bug but merely a perl-cgi bug.
But it seems the only way to get rid of it is a special version of
'fix_multiline_val'.
Have fun.
dirk
--
Dirk Schenkewitz
InterFace AG fon: +49 (0)89 / 610 49 - 126
Leipziger Str. 16 fax: +49 (0)89 / 610 49 - 83
D-82008 Unterhaching
http://www.interface-ag.de mailto:dirk.schenkewitz@interface-ag.de
[-- Attachment #2: fix_multiline_val.pl --]
[-- Type: application/x-perl, Size: 847 bytes --]
[-- Attachment #3: Type: text/plain, Size: 139 bytes --]
_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://mail.gnu.org/mailman/listinfo/help-gnats
^ permalink raw reply [flat|nested] 6+ messages in thread