gnatsweb/386: Gnatsweb must check text with regexp before submitting new PR

gnatsweb/386: Gnatsweb must check text with regexp before submitting new PR

[Lars.Henriksen]

>Number:         386
>Category:       gnatsweb
>Synopsis:       Gnatsweb must check text with regexp before submitting new PR
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun May 26 10:24:33 -0400 2002
>Originator:     Lars.Henriksen@netman.dk
>Release:        3.99.3
>Organization:

>Environment:

>Description:
Gnatsweb submits a new PR to gnatsd with the SUBM command.
SUBM will accept almost anything as contents of aPR, and it
certainly doesn't check field contents. This is to some
extent done by Gnatsweb for enumerated-in-file fields, but
not for text fields with matching regexps.

This implies that you can create a PR that will be rejected
with an invalid text field the first time you edit it, even
though you didn't change the text field (but something else).

Fix included (that also removes a superfluous newline).
>How-To-Repeat:

>Fix:
--- gnatsweb.pl-3.99.3  Sun May 26 15:39:55 2002
+++ gnatsweb.pl.fix     Sun May 26 16:06:06 2002
@@ -1222,8 +1222,11 @@
     return;
   }
 
+  client_cmd ("chek initial");
+  client_cmd("$text.");
+  return if ($client_would_have_exited);
   client_cmd ("subm");
-  client_cmd("$text\n.");
+  client_cmd("$text.");
 
   my $return_url = $q->param('return_url') || get_script_name();
   my $refresh = 5;
>Unformatted:
 

_______________________________________________
Gnats-prs mailing list
Gnats-prs@gnu.org
http://mail.gnu.org/mailman/listinfo/gnats-prs

Re: gnatsweb/386: Gnatsweb must check text with regexp before submitting new PR

[Yngve Svendsen]

At 10:24 26.05.2002 -0400, Lars.Henriksen@netman.dk wrote:
>Fix included (that also removes a superfluous newline).

Thanks! I am putting this in the queue of things that will be applied when 
I get Gnatsweb development going again, hopefully not too late in the summer.

- Yngve


_______________________________________________
Gnats-prs mailing list
Gnats-prs@gnu.org
http://mail.gnu.org/mailman/listinfo/gnats-prs