Error building from cvs

Error building from cvs

[John Long]

Hello. I just pulled the latest CVS sources and the build is breaking. After
it didn't work I did make again and captured the output so I could post to
the list:

make[1]: Entering directory `/tmp/insight-cvs/src'
make[2]: Entering directory `/tmp/insight-cvs/src/libiberty'
make[3]: Entering directory `/tmp/insight-cvs/src/libiberty/testsuite'
make[3]: Nothing to be done for `all'.
make[3]: Leaving directory `/tmp/insight-cvs/src/libiberty/testsuite'
make[2]: Leaving directory `/tmp/insight-cvs/src/libiberty'
make[2]: Entering directory `/tmp/insight-cvs/src/intl'
make[2]: Nothing to be done for `all'.
make[2]: Leaving directory `/tmp/insight-cvs/src/intl'
make[2]: Entering directory `/tmp/insight-cvs/src/bfd'
Making info in doc
make[3]: Entering directory `/tmp/insight-cvs/src/bfd/doc'
make[3]: Nothing to be done for `info'.
make[3]: Leaving directory `/tmp/insight-cvs/src/bfd/doc'
Making info in po
make[3]: Entering directory `/tmp/insight-cvs/src/bfd/po'
make[3]: Nothing to be done for `info'.
make[3]: Leaving directory `/tmp/insight-cvs/src/bfd/po'
make[3]: Entering directory `/tmp/insight-cvs/src/bfd'
make[3]: Nothing to be done for `info-am'.
make[3]: Leaving directory `/tmp/insight-cvs/src/bfd'
make  all-recursive
make[3]: Entering directory `/tmp/insight-cvs/src/bfd'
Making all in doc
make[4]: Entering directory `/tmp/insight-cvs/src/bfd/doc'
make[4]: Nothing to be done for `all'.
make[4]: Leaving directory `/tmp/insight-cvs/src/bfd/doc'
Making all in po
make[4]: Entering directory `/tmp/insight-cvs/src/bfd/po'
make[4]: Nothing to be done for `all'.
make[4]: Leaving directory `/tmp/insight-cvs/src/bfd/po'
make[4]: Entering directory `/tmp/insight-cvs/src/bfd'
make[4]: Leaving directory `/tmp/insight-cvs/src/bfd'
make[3]: Leaving directory `/tmp/insight-cvs/src/bfd'
make[2]: Leaving directory `/tmp/insight-cvs/src/bfd'
make[2]: Entering directory `/tmp/insight-cvs/src/opcodes'
make  all-recursive
make[3]: Entering directory `/tmp/insight-cvs/src/opcodes'
Making all in .
make[4]: Entering directory `/tmp/insight-cvs/src/opcodes'
i386-tbl.h
make[4]: Leaving directory `/tmp/insight-cvs/src/opcodes'
Making all in po
make[4]: Entering directory `/tmp/insight-cvs/src/opcodes/po'
make[4]: Nothing to be done for `all'.
make[4]: Leaving directory `/tmp/insight-cvs/src/opcodes/po'
make[3]: Leaving directory `/tmp/insight-cvs/src/opcodes'
make[2]: Leaving directory `/tmp/insight-cvs/src/opcodes'
make[2]: Entering directory `/tmp/insight-cvs/src/etc'
for f in standards.info configure.info; do \
  if test -f ./`echo $f | sed -e 's/.info$/.texi/'`; then \
    if make "MAKEINFO=makeinfo --split-size=5000000 --split-size=5000000" $f; then \
      true; \
    else \
      exit 1; \
    fi; \
  fi; \
done
make[3]: Entering directory `/tmp/insight-cvs/src/etc'
make[3]: `standards.info' is up to date.
make[3]: Leaving directory `/tmp/insight-cvs/src/etc'
make[3]: Entering directory `/tmp/insight-cvs/src/etc'
make[3]: `configure.info' is up to date.
make[3]: Leaving directory `/tmp/insight-cvs/src/etc'
make[2]: Leaving directory `/tmp/insight-cvs/src/etc'
make[2]: Entering directory `/tmp/insight-cvs/src/tcl'
make[3]: Entering directory `/tmp/insight-cvs/src/tcl/unix'
make[3]: Nothing to be done for `all'.
make[3]: Leaving directory `/tmp/insight-cvs/src/tcl/unix'
make[2]: Leaving directory `/tmp/insight-cvs/src/tcl'
make[2]: Entering directory `/tmp/insight-cvs/src/tk'
make[3]: Entering directory `/tmp/insight-cvs/src/tk/unix'
make[3]: Nothing to be done for `all'.
make[3]: Leaving directory `/tmp/insight-cvs/src/tk/unix'
make[2]: Leaving directory `/tmp/insight-cvs/src/tk'
make[2]: Entering directory `/tmp/insight-cvs/src/itcl'
Making all in itcl
make[3]: Entering directory `/tmp/insight-cvs/src/itcl/itcl'
make[3]: Nothing to be done for `all'.
make[3]: Leaving directory `/tmp/insight-cvs/src/itcl/itcl'
Making all in itk
make[3]: Entering directory `/tmp/insight-cvs/src/itcl/itk'
make[3]: Nothing to be done for `all'.
make[3]: Leaving directory `/tmp/insight-cvs/src/itcl/itk'
Making all in iwidgets
make[3]: Entering directory `/tmp/insight-cvs/src/itcl/iwidgets'
Nothing to make for target 'all'.  Run 'make test' to test the distribution
and 'make install' to install it.
make[3]: Leaving directory `/tmp/insight-cvs/src/itcl/iwidgets'
make[3]: Entering directory `/tmp/insight-cvs/src/itcl'
make[3]: Nothing to be done for `all-am'.
make[3]: Leaving directory `/tmp/insight-cvs/src/itcl'
make[2]: Leaving directory `/tmp/insight-cvs/src/itcl'
make[2]: Entering directory `/tmp/insight-cvs/src/libdecnumber'
make[2]: Nothing to be done for `all'.
make[2]: Leaving directory `/tmp/insight-cvs/src/libdecnumber'
make[2]: Entering directory `/tmp/insight-cvs/src/libgui'
make  all-recursive
make[3]: Entering directory `/tmp/insight-cvs/src/libgui'
Making all in library
make[4]: Entering directory `/tmp/insight-cvs/src/libgui/library'
make[4]: Nothing to be done for `all'.
make[4]: Leaving directory `/tmp/insight-cvs/src/libgui/library'
Making all in src
make[4]: Entering directory `/tmp/insight-cvs/src/libgui/src'
make[4]: Nothing to be done for `all'.
make[4]: Leaving directory `/tmp/insight-cvs/src/libgui/src'
make[4]: Entering directory `/tmp/insight-cvs/src/libgui'
make[4]: Leaving directory `/tmp/insight-cvs/src/libgui'
make[3]: Leaving directory `/tmp/insight-cvs/src/libgui'
make[2]: Leaving directory `/tmp/insight-cvs/src/libgui'
make[2]: Entering directory `/tmp/insight-cvs/src/readline'
make[2]: Nothing to be done for `all'.
make[2]: Leaving directory `/tmp/insight-cvs/src/readline'
make[2]: Entering directory `/tmp/insight-cvs/src/sim'
make[2]: Leaving directory `/tmp/insight-cvs/src/sim'
make[2]: Entering directory `/tmp/insight-cvs/src/gdb'
make[3]: Entering directory `/tmp/insight-cvs/src/gdb'
make[4]: Entering directory `/tmp/insight-cvs/src/gdb/build-gnulib'
make[5]: Entering directory `/tmp/insight-cvs/src/gdb/build-gnulib'
make[6]: Entering directory `/tmp/insight-cvs/src/gdb/build-gnulib/import'
make  all-recursive
make[7]: Entering directory `/tmp/insight-cvs/src/gdb/build-gnulib/import'
make[8]: Entering directory `/tmp/insight-cvs/src/gdb/build-gnulib/import'
make[8]: Nothing to be done for `all-am'.
make[8]: Leaving directory `/tmp/insight-cvs/src/gdb/build-gnulib/import'
make[7]: Leaving directory `/tmp/insight-cvs/src/gdb/build-gnulib/import'
make[6]: Leaving directory `/tmp/insight-cvs/src/gdb/build-gnulib/import'
make[5]: Leaving directory `/tmp/insight-cvs/src/gdb/build-gnulib'
make[4]: Leaving directory `/tmp/insight-cvs/src/gdb/build-gnulib'
make[3]: Leaving directory `/tmp/insight-cvs/src/gdb'
gcc -g -O2   -I. -I. -I./common -I./config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I./../include/opcode -I./../opcodes/.. -I./../readline/.. -I../bfd -I./../bfd -I./../include -I../libdecnumber -I./../libdecnumber  -I./gnulib/import -Ibuild-gnulib/import   -DTUI=1  -DGDBTK -I/usr/include/python2.7 -I/usr/include/python2.7 -Wall -Wdeclaration-after-statement -Wpointer-arith -Wpointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wmissing-prototypes -Wdeclaration-after-statement -Wempty-body -Wmissing-parameter-type -Wold-style-declaration -Wold-style-definition -Wformat-nonliteral -Werror -c -o gdbtk.o -MT gdbtk.o -MMD -MP -MF .deps/gdbtk.Tpo -I./../libgui/src    -I/tmp/insight-cvs/src/tcl/generic -I/tmp/insight-cvs/src/tk/generic   -DGDBTK_LIBRARY=\"/usr/local/share/insight1.0\" -DSRC_DIR=\"/tmp/insight-cvs/src/gdb\" ./gdbtk/generic/gdbtk.c
./gdbtk/generic/gdbtk.c: In function 'gdbtk_interactive':
./gdbtk/generic/gdbtk.c:253:1: error: old-style function definition [-Werror=old-style-definition]
./gdbtk/generic/gdbtk.c: In function 'gdbtk_start_timer':
./gdbtk/generic/gdbtk.c:260:1: error: old-style function definition [-Werror=old-style-definition]
./gdbtk/generic/gdbtk.c: In function 'gdbtk_stop_timer':
./gdbtk/generic/gdbtk.c:307:1: error: old-style function definition [-Werror=old-style-definition]
./gdbtk/generic/gdbtk.c: In function '_initialize_gdbtk':
./gdbtk/generic/gdbtk.c:691:1: error: old-style function definition [-Werror=old-style-definition]
cc1: all warnings being treated as errors
make[2]: *** [gdbtk.o] Error 1
make[2]: Leaving directory `/tmp/insight-cvs/src/gdb'
make[1]: *** [all-gdb] Error 2
make[1]: Leaving directory `/tmp/insight-cvs/src'
make: *** [all] Error 2

This is Linux running on Intel x86 with gcc 4.7.1. Any ideas?

Thanks,

/jl

-- 
ASCII ribbon campaign ( ) Powered by Lemote Fuloong
 against HTML e-mail   X  Loongson MIPS and OpenBSD
   and proprietary    / \    http://www.mutt.org
     attachments     /   \  Code Blue or Go Home!
 Encrypted email preferred  PGP Key 2048R/DA65BC04 

Re: Error building from cvs

[Keith Seitz]

[-- Attachment #1: Type: text/plain, Size: 2596 bytes --]

On 07/02/2013 02:41 AM, John Long wrote:
> Hello. I just pulled the latest CVS sources and the build is breaking. After
> it didn't work I did make again and captured the output so I could post to
> the list:
> gcc -g -O2   -I. -I. -I./common -I./config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I./../include/opcode -I./../opcodes/.. -I./../readline/.. -I../bfd -I./../bfd -I./../include -I../libdecnumber -I./../libdecnumber  -I./gnulib/import -Ibuild-gnulib/import   -DTUI=1  -DGDBTK -I/usr/include/python2.7 -I/usr/include/python2.7 -Wall -Wdeclaration-after-statement -Wpointer-arith -Wpointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wmissing-prototypes -Wdeclaration-after-statement -Wempty-body -Wmissing-parameter-type -Wold-style-declaration -Wold-style-definition -Wformat-nonliteral -Werror -c -o gdbtk.o -MT gdbtk.o -MMD -MP -MF .deps/gdbtk.Tpo -I./../libgui/src    -I/tmp/insight-cvs/src/tcl/generic -I/tmp/insight-cvs/src/tk/generic   -DGDBTK_LIBRARY=\"/usr/local/share/insight1.0\" -DSRC_DIR=\"/tmp/insight-cvs/src/gdb\" ./gdbtk/generic/gdbtk.c
> ./gdbtk/generic/gdbtk.c: In function 'gdbtk_interactive':
> ./gdbtk/generic/gdbtk.c:253:1: error: old-style function definition [-Werror=old-style-definition]
> ./gdbtk/generic/gdbtk.c: In function 'gdbtk_start_timer':
> ./gdbtk/generic/gdbtk.c:260:1: error: old-style function definition [-Werror=old-style-definition]
> ./gdbtk/generic/gdbtk.c: In function 'gdbtk_stop_timer':
> ./gdbtk/generic/gdbtk.c:307:1: error: old-style function definition [-Werror=old-style-definition]
> ./gdbtk/generic/gdbtk.c: In function '_initialize_gdbtk':
> ./gdbtk/generic/gdbtk.c:691:1: error: old-style function definition [-Werror=old-style-definition]
> cc1: all warnings being treated as errors

Thank you for reporting this. This is occurring as a result of a patch 
checked into gdb yesterday.

I've applied the attached patch to drag insight into the 21st century 
(minimal kicking and screaming).

Keith

ChangeLog
2013-07-02  Keith Seitz  <keiths@redhat.com>

	* generic/gdbtk-cmds.c (gdb_listfuncs): Update declaration.
	* generic/gdbtk-hooks.c (gdb_two_elem_cmd): Likewise.
	(report_error): Likewise.
	(gdbtk_readline_end, gdbtk_post_add_symbol, gdbtk_error_begin,
	gdbtk_attach): Likewise.
	* generic/gdbtk/gdbtk-register.c (setup_architecture_data):
	Likewise.
	* generic/gdbtk-wrapper.c (GDB_equal_value, GDB_reinit_frame_cache,
	GDB_value-coerce_array): Likewise.
	* generic/gdbtk.c (gdbtk_interactive, gdbtk_start_timer,
	gdbtk_stop_timer, _initialize_gdbtk): Likewise.


[-- Attachment #2: old-style-defn.patch --]
[-- Type: text/x-patch, Size: 5071 bytes --]

diff --git a/gdb/gdbtk/generic/gdbtk-cmds.c b/gdb/gdbtk/generic/gdbtk-cmds.c
index 9b6a67e..42f2b1e 100644
--- a/gdb/gdbtk/generic/gdbtk-cmds.c
+++ b/gdb/gdbtk/generic/gdbtk-cmds.c
@@ -1528,11 +1528,8 @@ gdb_search (ClientData clientData, Tcl_Interp *interp,
 */
 
 static int
-gdb_listfuncs (clientData, interp, objc, objv)
-     ClientData clientData;
-     Tcl_Interp *interp;
-     int objc;
-     Tcl_Obj *CONST objv[];
+gdb_listfuncs (ClientData clientData, Tcl_Interp *interp,
+	       int objc, Tcl_Obj *CONST objv[])
 {
   struct symtab *symtab;
   struct blockvector *bv;
diff --git a/gdb/gdbtk/generic/gdbtk-hooks.c b/gdb/gdbtk/generic/gdbtk-hooks.c
index e1445e9..4aa8d06 100644
--- a/gdb/gdbtk/generic/gdbtk-hooks.c
+++ b/gdb/gdbtk/generic/gdbtk-hooks.c
@@ -194,9 +194,7 @@ gdbtk_restore_result_ptr (void *old_result_ptr)
 /* This allows you to Tcl_Eval a tcl command which takes
    a command word, and then a single argument. */
 int
-gdbtk_two_elem_cmd (cmd_name, argv1)
-     char *cmd_name;
-     char *argv1;
+gdbtk_two_elem_cmd (char *cmd_name, char *argv1)
 {
   char *command;
   int result, flags_ptr, arg_len, cmd_len;
@@ -364,7 +362,7 @@ gdbtk_warning (const char *warning, va_list args)
 /* the gdbtk dbug command.  */
 
 void
-report_error ()
+report_error (void)
 {
   TclDebug ('E', Tcl_GetVar (gdbtk_interp, "errorInfo", TCL_GLOBAL_ONLY));
   /*  Tcl_BackgroundError(gdbtk_interp); */
@@ -518,7 +516,7 @@ gdbtk_readline (char *prompt)
 }
 
 static void
-gdbtk_readline_end ()
+gdbtk_readline_end (void)
 {
   if (Tcl_Eval (gdbtk_interp, "gdbtk_tcl_readline_end") != TCL_OK)
     report_error ();
@@ -644,7 +642,7 @@ gdbtk_pre_add_symbol (const char *name)
 
 /* This hook is called whenever we finish loading a symbol file. */
 static void
-gdbtk_post_add_symbol ()
+gdbtk_post_add_symbol (void)
 {
   if (Tcl_Eval (gdbtk_interp, "gdbtk_tcl_post_add_symbol") != TCL_OK)
     report_error ();
@@ -783,7 +781,7 @@ gdbtk_exec_file_display (char *filename)
 /* Called from error_begin, this hook is used to warn the gui
    about multi-line error messages */
 static void
-gdbtk_error_begin ()
+gdbtk_error_begin (void)
 {
   if (result_ptr != NULL)
     result_ptr->flags |= GDBTK_ERROR_ONLY;
@@ -816,7 +814,7 @@ gdbtk_annotate_signal (void)
 }
 
 static void
-gdbtk_attach ()
+gdbtk_attach (void)
 {
   if (Tcl_Eval (gdbtk_interp, "after idle \"update idletasks;gdbtk_attached\"") != TCL_OK)
     {
@@ -825,7 +823,7 @@ gdbtk_attach ()
 }
 
 static void
-gdbtk_detach ()
+gdbtk_detach (void)
 {
   if (Tcl_Eval (gdbtk_interp, "gdbtk_detached") != TCL_OK)
     {
diff --git a/gdb/gdbtk/generic/gdbtk-register.c b/gdb/gdbtk/generic/gdbtk-register.c
index 8f40d94..4f95c89 100644
--- a/gdb/gdbtk/generic/gdbtk-register.c
+++ b/gdb/gdbtk/generic/gdbtk-register.c
@@ -462,7 +462,7 @@ register_changed_p (int regnum, map_arg arg)
 }
 
 static void
-setup_architecture_data ()
+setup_architecture_data (void)
 {
   int numregs;
 
diff --git a/gdb/gdbtk/generic/gdbtk-wrapper.c b/gdb/gdbtk/generic/gdbtk-wrapper.c
index 491ffa3..8e0fc87 100644
--- a/gdb/gdbtk/generic/gdbtk-wrapper.c
+++ b/gdb/gdbtk/generic/gdbtk-wrapper.c
@@ -1,5 +1,5 @@
 /* longjmp-free interface between gdb and gdbtk.
-   Copyright (C) 1999, 2000, 2002, 2008 Free Software Foundation, Inc.
+   Copyright (C) 1999, 2000, 2002, 2008, 2013 Free Software Foundation, Inc.
 
    This file is part of GDB.
 
@@ -271,10 +271,7 @@ wrap_evaluate_expression (char *a)
 }
 
 gdb_result
-GDB_value_equal (val1, val2, result)
-     value_ptr val1;
-     value_ptr val2;
-     int *result;
+GDB_value_equal (value_ptr val1, value_ptr val2, int *result)
 {
   struct gdb_wrapper_arguments args;
   gdb_result r;
@@ -422,7 +419,7 @@ wrap_block_innermost_frame (char *opaque_arg)
 }
 
 gdb_result
-GDB_reinit_frame_cache ()
+GDB_reinit_frame_cache (void)
 {
   gdb_result r;
 
@@ -500,9 +497,7 @@ wrap_value_slice (char *opaque_arg)
 }
 
 gdb_result
-GDB_value_coerce_array (val, rval)
-     value_ptr val;
-     value_ptr *rval;
+GDB_value_coerce_array (value_ptr val, value_ptr *rval)
 {
   struct gdb_wrapper_arguments args;
   gdb_result r;
diff --git a/gdb/gdbtk/generic/gdbtk.c b/gdb/gdbtk/generic/gdbtk.c
index d205347..ea13943 100644
--- a/gdb/gdbtk/generic/gdbtk.c
+++ b/gdb/gdbtk/generic/gdbtk.c
@@ -250,14 +250,14 @@ cleanup_init (void *ignore)
    via the QUIT macro.  */
 
 void
-gdbtk_interactive ()
+gdbtk_interactive (void)
 {
   /* Tk_DoOneEvent (TK_DONT_WAIT|TK_IDLE_EVENTS); */
 }
 
 /* Start a timer which will keep the GUI alive while in target_wait. */
 void
-gdbtk_start_timer ()
+gdbtk_start_timer (void)
 {
   static int first = 1;
 
@@ -304,7 +304,7 @@ gdbtk_start_timer ()
 
 /* Stop the timer if it is running. */
 void
-gdbtk_stop_timer ()
+gdbtk_stop_timer (void)
 {
   if (gdbtk_timer_going)
     {
@@ -688,7 +688,7 @@ gdbtk_test (char *filename)
 /* Come here during initialize_all_files () */
 
 void
-_initialize_gdbtk ()
+_initialize_gdbtk (void)
 {
   /* Current_interpreter not set yet, so we must check
      if "interpreter_p" is set to "insight" to know if

Re: Error building from cvs

[John Long]

Thanks a lot, I'll try this again tomorrow or the day after and get back to
you on it as soon as I know anything.

/jl

On Tue, Jul 02, 2013 at 10:07:46AM -0700, Keith Seitz wrote:

> Thank you for reporting this. This is occurring as a result of a
> patch checked into gdb yesterday.
> 
> I've applied the attached patch to drag insight into the 21st
> century (minimal kicking and screaming).
> 
> Keith

Re: Error building from cvs

[John Long]

Keith, I just went to look at this and realized I am still confused about
patching commands. I pulled the sources from CVS from your patch seems to be
in git format. patch -p0 < patch doesn't seem to work very well.

Can you please remind me how to apply your patches?

Thanks,

/jl

Re: Error building from cvs

[Keith Seitz]

On 07/03/2013 04:06 AM, John Long wrote:
> Can you please remind me how to apply your patches?

Git format shouldn't matter: I apply those to branches all the time with 
`patch'. The probable cause is the leading path on that patch.

The paths in the patch are all prefaced with: "a/gdb/gdbtk/generic" [or 
"b/gdb/gdbtk/generic"]. So depending on what source directory you are 
sitting in, you need to specify something other than "-p0" to `patch'.

If the CWD is (from CVS) src/gdb/, then you need -p2. If the CWD is 
src/, you need -p1. If you are sitting in src/gdb/gdbtk/generic/, yes, 
you need -p4 to ignore the first for directory components in the patch.

Keith

Re: Error building from cvs

[John Long]

Thanks, I see you updated the CVS sources as well. This built fine and comes
up ok. I'll see what I can do with it!

/jl

On Wed, Jul 03, 2013 at 09:11:02AM -0700, Keith Seitz wrote:
> On 07/03/2013 04:06 AM, John Long wrote:
> >Can you please remind me how to apply your patches?
> 
> Git format shouldn't matter: I apply those to branches all the time
> with `patch'. The probable cause is the leading path on that patch.
> 
> The paths in the patch are all prefaced with: "a/gdb/gdbtk/generic"
> [or "b/gdb/gdbtk/generic"]. So depending on what source directory
> you are sitting in, you need to specify something other than "-p0"
> to `patch'.
> 
> If the CWD is (from CVS) src/gdb/, then you need -p2. If the CWD is
> src/, you need -p1. If you are sitting in src/gdb/gdbtk/generic/,
> yes, you need -p4 to ignore the first for directory components in
> the patch.
> 
> Keith

-- 
ASCII ribbon campaign ( ) Powered by Lemote Fuloong
 against HTML e-mail   X  Loongson MIPS and OpenBSD
   and proprietary    / \    http://www.mutt.org
     attachments     /   \  Code Blue or Go Home!
 Encrypted email preferred  PGP Key 2048R/DA65BC04