Re: [PATCH] Allow onlinehelp to work on native windows

Re: [PATCH] Allow onlinehelp to work on native windows

[Roland Schwingel]

Hi Keith,

 > > * generic/gdbtk.c: (gdbtk_init): Move call to
 > ide_create_shell_execute_command
 > > to generic windows section.
 >
 > This line is too long. Please wrap after "call". [We try to keep line
 > lengths < 80 characters.]
Rewrapped the Changelog entry.

 > > Any comments? Is this ok?
 >
 > Ok with that change.
In another email today you asked me to adapt copyright years on all 
files I touch. In gdbtk.c the years have been also out of sync I 
corrected that too and mentioned it in the changelog.

The change is now committed.

Thanks for taking a look,

Roland

Re: [PATCH] Allow onlinehelp to work on native windows

[Keith Seitz]

On 03/19/2012 04:50 AM, Roland Schwingel wrote:
> Hello,
>
> Here comes a simple patch allowing insight's onlinehelp also to be
> opened on native windows, not only on cygwin.
> It still continues to work on cygwin, too.
>
> Changelog:
>
> 2012-03-19 Roland Schwingel <roland.schwingel@onevision.com>
>
> * generic/gdbtk.c: (gdbtk_init): Move call to ide_create_shell_execute_command
> to generic windows section.

This line is too long. Please wrap after "call". [We try to keep line 
lengths < 80 characters.]

> Any comments? Is this ok?

Ok with that change.

Keith

[PATCH] Allow onlinehelp to work on native windows

[Roland Schwingel]

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

Hello,

Here comes a simple patch allowing insight's onlinehelp also to be 
opened on native windows, not only on cygwin.
It still continues to work on cygwin, too.

Changelog:

2012-03-19  Roland Schwingel <roland.schwingel@onevision.com>

         * generic/gdbtk.c: (gdbtk_init): Move call to 
ide_create_shell_execute_command
         to generic windows section.

Any comments? Is this ok?

Roland

[-- Attachment #2: mingw_onlinehelp_gdbtk.c.patch --]
[-- Type: text/plain, Size: 853 bytes --]

--- gdbtk_orig/generic/gdbtk.c	2012-03-19 11:21:15.542232400 +0100
+++ gdbtk/generic/gdbtk.c	2012-03-19 11:23:12.099170600 +0100
@@ -540,13 +540,13 @@
     error ("windows print code initialization failed");
   if (ide_create_win_grab_command (gdbtk_interp) != TCL_OK)
     error ("grab support command initialization failed");
+  if (ide_create_shell_execute_command (gdbtk_interp) != TCL_OK)
+    error ("cygwin shell execute command initialization failed");
 #endif
 #ifdef __CYGWIN32__
   /* Path conversion functions.  */
   if (ide_create_cygwin_path_command (gdbtk_interp) != TCL_OK)
     error ("cygwin path command initialization failed");
-  if (ide_create_shell_execute_command (gdbtk_interp) != TCL_OK)
-    error ("cygwin shell execute command initialization failed");
 #endif
 
   /* Only for testing -- and only when it can't be done any