* Re: [PATCH] Allow onlinehelp to work on native windows
@ 2012-03-30 7:09 Roland Schwingel
0 siblings, 0 replies; 3+ messages in thread
From: Roland Schwingel @ 2012-03-30 7:09 UTC (permalink / raw)
To: Keith Seitz, insight
Hi Keith,
> > * generic/gdbtk.c: (gdbtk_init): Move call to
> ide_create_shell_execute_command
> > to generic windows section.
>
> This line is too long. Please wrap after "call". [We try to keep line
> lengths < 80 characters.]
Rewrapped the Changelog entry.
> > Any comments? Is this ok?
>
> Ok with that change.
In another email today you asked me to adapt copyright years on all
files I touch. In gdbtk.c the years have been also out of sync I
corrected that too and mentioned it in the changelog.
The change is now committed.
Thanks for taking a look,
Roland
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Allow onlinehelp to work on native windows
@ 2012-03-19 11:51 Roland Schwingel
2012-03-29 23:17 ` Keith Seitz
0 siblings, 1 reply; 3+ messages in thread
From: Roland Schwingel @ 2012-03-19 11:51 UTC (permalink / raw)
To: insight
[-- Attachment #1: Type: text/plain, Size: 402 bytes --]
Hello,
Here comes a simple patch allowing insight's onlinehelp also to be
opened on native windows, not only on cygwin.
It still continues to work on cygwin, too.
Changelog:
2012-03-19 Roland Schwingel <roland.schwingel@onevision.com>
* generic/gdbtk.c: (gdbtk_init): Move call to
ide_create_shell_execute_command
to generic windows section.
Any comments? Is this ok?
Roland
[-- Attachment #2: mingw_onlinehelp_gdbtk.c.patch --]
[-- Type: text/plain, Size: 853 bytes --]
--- gdbtk_orig/generic/gdbtk.c 2012-03-19 11:21:15.542232400 +0100
+++ gdbtk/generic/gdbtk.c 2012-03-19 11:23:12.099170600 +0100
@@ -540,13 +540,13 @@
error ("windows print code initialization failed");
if (ide_create_win_grab_command (gdbtk_interp) != TCL_OK)
error ("grab support command initialization failed");
+ if (ide_create_shell_execute_command (gdbtk_interp) != TCL_OK)
+ error ("cygwin shell execute command initialization failed");
#endif
#ifdef __CYGWIN32__
/* Path conversion functions. */
if (ide_create_cygwin_path_command (gdbtk_interp) != TCL_OK)
error ("cygwin path command initialization failed");
- if (ide_create_shell_execute_command (gdbtk_interp) != TCL_OK)
- error ("cygwin shell execute command initialization failed");
#endif
/* Only for testing -- and only when it can't be done any
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Allow onlinehelp to work on native windows
2012-03-19 11:51 Roland Schwingel
@ 2012-03-29 23:17 ` Keith Seitz
0 siblings, 0 replies; 3+ messages in thread
From: Keith Seitz @ 2012-03-29 23:17 UTC (permalink / raw)
To: Roland Schwingel; +Cc: insight
On 03/19/2012 04:50 AM, Roland Schwingel wrote:
> Hello,
>
> Here comes a simple patch allowing insight's onlinehelp also to be
> opened on native windows, not only on cygwin.
> It still continues to work on cygwin, too.
>
> Changelog:
>
> 2012-03-19 Roland Schwingel <roland.schwingel@onevision.com>
>
> * generic/gdbtk.c: (gdbtk_init): Move call to ide_create_shell_execute_command
> to generic windows section.
This line is too long. Please wrap after "call". [We try to keep line
lengths < 80 characters.]
> Any comments? Is this ok?
Ok with that change.
Keith
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-30 7:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-30 7:09 [PATCH] Allow onlinehelp to work on native windows Roland Schwingel
-- strict thread matches above, loose matches on Subject: below --
2012-03-19 11:51 Roland Schwingel
2012-03-29 23:17 ` Keith Seitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).