* question about function combobox
@ 2001-08-23 14:56 Tom Tromey
2001-08-23 16:49 ` Tom Tromey
0 siblings, 1 reply; 7+ messages in thread
From: Tom Tromey @ 2001-08-23 14:56 UTC (permalink / raw)
To: Insight List
I'm debugging jc1 (the Java compiler part of gcc) -- code I don't know
all that well.
Today I tried to use the function combobox on the source window. I
was surprised to find that it was not in alphabetical order. I had to
scan the list of functions to find the one I was interested in. This
took me quite a while. In fact it was simpler to switch back to the
editor, see what line I was on, and then switch back to Insight so I
could simply scroll down to that line.
Is there a reason why the function names aren't alphabetical?
This would be a simple change in SrcWin::fillFuncCB.
Tom
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: question about function combobox
2001-08-23 14:56 question about function combobox Tom Tromey
@ 2001-08-23 16:49 ` Tom Tromey
2001-08-23 16:54 ` Keith Seitz
0 siblings, 1 reply; 7+ messages in thread
From: Tom Tromey @ 2001-08-23 16:49 UTC (permalink / raw)
To: Insight List
Tom> Is there a reason why the function names aren't alphabetical?
Tom> This would be a simple change in SrcWin::fillFuncCB.
And here it is.
Ok to commit?
Tom
Index: ChangeLog
from Tom Tromey <tromey@redhat.com>
* library/srcwin.itb (SrcWin::fillFuncCB): Sort function names.
Index: library/srcwin.itb
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/srcwin.itb,v
retrieving revision 1.15
diff -u -r1.15 srcwin.itb
--- library/srcwin.itb 2001/06/04 15:49:53 1.15
+++ library/srcwin.itb 2001/08/23 23:48:28
@@ -386,7 +386,7 @@
_set_name ""
return
}
- foreach f $listfuncs {
+ foreach f [lsort -increasing $listfuncs] {
lassign $f func mang
set _mangled_func($func) $mang
$_statbar.func list insert end $func
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: question about function combobox
2001-08-23 16:49 ` Tom Tromey
@ 2001-08-23 16:54 ` Keith Seitz
2001-08-23 16:56 ` Tom Tromey
0 siblings, 1 reply; 7+ messages in thread
From: Keith Seitz @ 2001-08-23 16:54 UTC (permalink / raw)
To: Tom Tromey; +Cc: Insight List
On 23 Aug 2001, Tom Tromey wrote:
> Tom> Is there a reason why the function names aren't alphabetical?
> Tom> This would be a simple change in SrcWin::fillFuncCB.
>
> And here it is.
> Ok to commit?
Oddly, I thought that we sorted these already in C. I just looked at
gdb_listfiles and we don't do that at all. How strange!
Please check it in.
Thanks!
Keith
> Index: ChangeLog
> from Tom Tromey <tromey@redhat.com>
>
> * library/srcwin.itb (SrcWin::fillFuncCB): Sort function names.
>
> Index: library/srcwin.itb
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/srcwin.itb,v
> retrieving revision 1.15
> diff -u -r1.15 srcwin.itb
> --- library/srcwin.itb 2001/06/04 15:49:53 1.15
> +++ library/srcwin.itb 2001/08/23 23:48:28
> @@ -386,7 +386,7 @@
> _set_name ""
> return
> }
> - foreach f $listfuncs {
> + foreach f [lsort -increasing $listfuncs] {
> lassign $f func mang
> set _mangled_func($func) $mang
> $_statbar.func list insert end $func
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: question about function combobox
2001-08-23 16:54 ` Keith Seitz
@ 2001-08-23 16:56 ` Tom Tromey
2001-08-23 16:57 ` Keith Seitz
0 siblings, 1 reply; 7+ messages in thread
From: Tom Tromey @ 2001-08-23 16:56 UTC (permalink / raw)
To: Keith Seitz; +Cc: Insight List
>>>>> "Keith" == Keith Seitz <keiths@cygnus.com> writes:
Keith> Oddly, I thought that we sorted these already in C. I just
Keith> looked at gdb_listfiles and we don't do that at all. How
Keith> strange!
Would you rather I do the sorting in C?
Tom
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: question about function combobox
2001-08-23 16:56 ` Tom Tromey
@ 2001-08-23 16:57 ` Keith Seitz
2001-08-23 17:11 ` Tom Tromey
0 siblings, 1 reply; 7+ messages in thread
From: Keith Seitz @ 2001-08-23 16:57 UTC (permalink / raw)
To: Tom Tromey; +Cc: Insight List
On 23 Aug 2001, Tom Tromey wrote:
> >>>>> "Keith" == Keith Seitz <keiths@cygnus.com> writes:
>
> Keith> Oddly, I thought that we sorted these already in C. I just
> Keith> looked at gdb_listfiles and we don't do that at all. How
> Keith> strange!
>
> Would you rather I do the sorting in C?
Blah. Why bother? I don't think it matters too much. If you feel compelled
to do it, then by all means. I don't really care, to tell the truth.
Keith
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: question about function combobox
2001-08-23 16:57 ` Keith Seitz
@ 2001-08-23 17:11 ` Tom Tromey
2001-08-23 17:12 ` Keith Seitz
0 siblings, 1 reply; 7+ messages in thread
From: Tom Tromey @ 2001-08-23 17:11 UTC (permalink / raw)
To: Keith Seitz; +Cc: Insight List
>>>>> "Keith" == Keith Seitz <keiths@cygnus.com> writes:
>> Would you rather I do the sorting in C?
Keith> Blah. Why bother? I don't think it matters too much. If you
Keith> feel compelled to do it, then by all means. I don't really
Keith> care, to tell the truth.
Tcl is fine by me -- I've checked in the patch.
Tom
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: question about function combobox
2001-08-23 17:11 ` Tom Tromey
@ 2001-08-23 17:12 ` Keith Seitz
0 siblings, 0 replies; 7+ messages in thread
From: Keith Seitz @ 2001-08-23 17:12 UTC (permalink / raw)
To: Tom Tromey; +Cc: Insight List
On 23 Aug 2001, Tom Tromey wrote:
> >>>>> "Keith" == Keith Seitz <keiths@cygnus.com> writes:
>
> >> Would you rather I do the sorting in C?
>
> Keith> Blah. Why bother? I don't think it matters too much. If you
> Keith> feel compelled to do it, then by all means. I don't really
> Keith> care, to tell the truth.
>
> Tcl is fine by me -- I've checked in the patch.
Me, too. Thanks!
Keith
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2001-08-23 17:12 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-08-23 14:56 question about function combobox Tom Tromey
2001-08-23 16:49 ` Tom Tromey
2001-08-23 16:54 ` Keith Seitz
2001-08-23 16:56 ` Tom Tromey
2001-08-23 16:57 ` Keith Seitz
2001-08-23 17:11 ` Tom Tromey
2001-08-23 17:12 ` Keith Seitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).