question about function combobox

question about function combobox

[Tom Tromey]

I'm debugging jc1 (the Java compiler part of gcc) -- code I don't know
all that well.

Today I tried to use the function combobox on the source window.  I
was surprised to find that it was not in alphabetical order.  I had to
scan the list of functions to find the one I was interested in.  This
took me quite a while.  In fact it was simpler to switch back to the
editor, see what line I was on, and then switch back to Insight so I
could simply scroll down to that line.

Is there a reason why the function names aren't alphabetical?
This would be a simple change in SrcWin::fillFuncCB.

Tom

Re: question about function combobox

[Tom Tromey]

Tom> Is there a reason why the function names aren't alphabetical?
Tom> This would be a simple change in SrcWin::fillFuncCB.

And here it is.
Ok to commit?

Tom

Index: ChangeLog
from  Tom Tromey  <tromey@redhat.com>

	* library/srcwin.itb (SrcWin::fillFuncCB): Sort function names.

Index: library/srcwin.itb
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/srcwin.itb,v
retrieving revision 1.15
diff -u -r1.15 srcwin.itb
--- library/srcwin.itb 2001/06/04 15:49:53 1.15
+++ library/srcwin.itb 2001/08/23 23:48:28
@@ -386,7 +386,7 @@
       _set_name ""
       return
     }
-    foreach f $listfuncs {
+    foreach f [lsort -increasing $listfuncs] {
       lassign $f func mang
       set _mangled_func($func) $mang
       $_statbar.func list insert end $func

Re: question about function combobox

[Keith Seitz]

On 23 Aug 2001, Tom Tromey wrote:

> Tom> Is there a reason why the function names aren't alphabetical?
> Tom> This would be a simple change in SrcWin::fillFuncCB.
>
> And here it is.
> Ok to commit?

Oddly, I thought that we sorted these already in C. I just looked at
gdb_listfiles and we don't do that at all. How strange!

Please check it in.
Thanks!
Keith

> Index: ChangeLog
> from  Tom Tromey  <tromey@redhat.com>
>
> 	* library/srcwin.itb (SrcWin::fillFuncCB): Sort function names.
>
> Index: library/srcwin.itb
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/srcwin.itb,v
> retrieving revision 1.15
> diff -u -r1.15 srcwin.itb
> --- library/srcwin.itb 2001/06/04 15:49:53 1.15
> +++ library/srcwin.itb 2001/08/23 23:48:28
> @@ -386,7 +386,7 @@
>        _set_name ""
>        return
>      }
> -    foreach f $listfuncs {
> +    foreach f [lsort -increasing $listfuncs] {
>        lassign $f func mang
>        set _mangled_func($func) $mang
>        $_statbar.func list insert end $func
>

Re: question about function combobox

[Tom Tromey]

>>>>> "Keith" == Keith Seitz <keiths@cygnus.com> writes:

Keith> Oddly, I thought that we sorted these already in C. I just
Keith> looked at gdb_listfiles and we don't do that at all. How
Keith> strange!

Would you rather I do the sorting in C?

Tom

Re: question about function combobox

[Keith Seitz]

On 23 Aug 2001, Tom Tromey wrote:

> >>>>> "Keith" == Keith Seitz <keiths@cygnus.com> writes:
>
> Keith> Oddly, I thought that we sorted these already in C. I just
> Keith> looked at gdb_listfiles and we don't do that at all. How
> Keith> strange!
>
> Would you rather I do the sorting in C?

Blah. Why bother? I don't think it matters too much. If you feel compelled
to do it, then by all means. I don't really care, to tell the truth.

Keith

Re: question about function combobox

[Tom Tromey]

>>>>> "Keith" == Keith Seitz <keiths@cygnus.com> writes:

>> Would you rather I do the sorting in C?

Keith> Blah. Why bother? I don't think it matters too much. If you
Keith> feel compelled to do it, then by all means. I don't really
Keith> care, to tell the truth.

Tcl is fine by me -- I've checked in the patch.

Tom

Re: question about function combobox

[Keith Seitz]

On 23 Aug 2001, Tom Tromey wrote:

> >>>>> "Keith" == Keith Seitz <keiths@cygnus.com> writes:
>
> >> Would you rather I do the sorting in C?
>
> Keith> Blah. Why bother? I don't think it matters too much. If you
> Keith> feel compelled to do it, then by all means. I don't really
> Keith> care, to tell the truth.
>
> Tcl is fine by me -- I've checked in the patch.

Me, too. Thanks!
Keith