Build insight cvs-head get error

Build insight cvs-head get error

[Hui Zhu]

ubuntu 8.04 x86

../src/configure --disable-sid --disable-rda --disable-binutils
--disable-gas --disable-ld --disable-gprof --enable-targets=all
--enable-64-bits-bfd CFLAGS=-g

gcc -g   -I. -I../../src/gdb -I../../src/gdb/common
-I../../src/gdb/config -DLOCALEDIR="\"/usr/local/share/locale\""
-DHAVE_CONFIG_H -I../../src/gdb/../include/opcode
-I../../src/gdb/../readline/.. -I../bfd -I../../src/gdb/../bfd
-I../../src/gdb/../include -I../libdecnumber
-I../../src/gdb/../libdecnumber  -I../../src/gdb/gnulib -Ignulib
-DMI_OUT=1 -DTUI=1  -DGDBTK  -Wall -Wdeclaration-after-statement
-Wpointer-arith -Wformat-nonliteral -Wno-pointer-sign -Wno-unused
-Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts
-Werror -c -o gdbtk-cmds.o -MT gdbtk-cmds.o -MMD -MP -MF
.deps/gdbtk-cmds.Tpo -I../../src/gdb/../libgui/src
-I/home/teawater/gdb/sse/src/tcl/generic
-I/home/teawater/gdb/sse/src/tk/generic
-DGDBTK_LIBRARY=\"/usr/local/share/insight1.0\"
-DSRC_DIR=\"/home/teawater/gdb/sse/src/gdb\"
../../src/gdb/gdbtk/generic/gdbtk-cmds.c
../../src/gdb/gdbtk/generic/gdbtk-cmds.c: In function 'gdb_set_inferior_args':
../../src/gdb/gdbtk/generic/gdbtk-cmds.c:867: error: void value not
ignored as it ought to be
make: *** [gdbtk-cmds.o] Error 1


Thanks,
Hui

Re: Build insight cvs-head get error

[Keith Seitz]

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

On 01/25/2010 12:21 AM, Hui Zhu wrote:

> ../../src/gdb/gdbtk/generic/gdbtk-cmds.c: In function 'gdb_set_inferior_args':
> ../../src/gdb/gdbtk/generic/gdbtk-cmds.c:867: error: void value not
> ignored as it ought to be

I've checked in the attached patch for this.

Keith

ChangeLog
2010-01-25  Keith Seitz  <keiths@redhat.com>

	* generic/gdbtk-cmds.c (gdb_set_inferior_args): set_inferior_args
	now works as expected. Do not strdup/free the argument string.


[-- Attachment #2: set_inferior_args.patch --]
[-- Type: text/plain, Size: 753 bytes --]

Index: generic/gdbtk-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v
retrieving revision 1.114
retrieving revision 1.115
diff -u -p -r1.114 -r1.115
--- generic/gdbtk-cmds.c	4 Jan 2010 20:14:46 -0000	1.114
+++ generic/gdbtk-cmds.c	25 Jan 2010 19:59:29 -0000	1.115
@@ -859,13 +859,7 @@ gdb_set_inferior_args (ClientData client
     }
 
   args = Tcl_GetStringFromObj (objv[1], NULL);
-
-  /* The xstrdup/xfree stuff is so that we maintain a coherent picture
-     for gdb.  I would expect the accessors to do this, but they
-     don't.  */
-  args = xstrdup (args);
-  args = set_inferior_args (args);
-  xfree (args);
+  set_inferior_args (args);
 
   return TCL_OK;
 }

Re: Build insight cvs-head get error

[Hui Zhu]

Thanks Keith.  I build cvs-head is OK now.

Best regards,
Hui

On Tue, Jan 26, 2010 at 04:01, Keith Seitz <keiths@redhat.com> wrote:
> On 01/25/2010 12:21 AM, Hui Zhu wrote:
>
>> ../../src/gdb/gdbtk/generic/gdbtk-cmds.c: In function
>> 'gdb_set_inferior_args':
>> ../../src/gdb/gdbtk/generic/gdbtk-cmds.c:867: error: void value not
>> ignored as it ought to be
>
> I've checked in the attached patch for this.
>
> Keith
>
> ChangeLog
> 2010-01-25  Keith Seitz  <keiths@redhat.com>
>
>        * generic/gdbtk-cmds.c (gdb_set_inferior_args): set_inferior_args
>        now works as expected. Do not strdup/free the argument string.
>
>