Re: [PATCH] libjava/classpath/native/jni/java-lang/java_lang_VMProcess.c: Be sure 'errbuf' always be zero terminated.

Re: [PATCH] libjava/classpath/native/jni/java-lang/java_lang_VMProcess.c: Be sure 'errbuf' always be zero terminated.

[Chen Gang]

On 08/10/2014 04:22 PM, Chen Gang wrote:
> 
> I guess, I find the root cause:
> 

Although I say "I guess", in fact, I already had related proofs for it.

 - When configure "libjava/classpath", "--disable-core-jni" is passed
   as parameter explicitly (can check "x86_64-.../libjava/classpatch/
   config.log" to know about it).

 - if pass "--disable-core-jni" to "libjava/classpatch/configure", it
   will disable 'JNIDIR' in "libjava/classpath/native/jni/Makefile". If
   remove "--disable-core-jni", it enables 'JNIDIR' to build java-lang.

 - After grep "--disaboe-core-jni", only "libjava/configure(.ac)" do it
   (and hard code it).

For me, the proofs are enough, and the code in "libjava/configure(.ac)"
are also obvious for it.


So please check it is whether it is the root cause, when you have time.

Thanks.

> In "gcc/libjava/configure", "--disable-core-jni" is hardcoded manually
> for classpath with FIXME, then all related trying are useless. For me,
> if have parameter "--enable-core-jni", need skip "--disable-core-jni".
> 
> The related information in gcc/libjava/configure:
> 
>  6820 # Set up to configure Classpath.
>  6821 # FIXME: no supported way to pass args in autoconf.
>  6822 # Disable tool wrappers to avoid ltdl.h configure check.
>  6823 ac_configure_args="$ac_configure_args --disable-tool-wrappers"
>  6824 ac_configure_args="$ac_configure_args --disable-load-library"
>  6825 ac_configure_args="$ac_configure_args --${LIBGCJDEBUG}-debug"
>  6826 ac_configure_args="$ac_configure_args --enable-default-toolkit=$TOOLKIT"
>  6827 dir1=`cd $srcdir && pwd`
>  6828 dir2=`pwd`
>  6829 ac_configure_args="$ac_configure_args --with-vm-classes=$dir1:$dir2"
>  6830 ac_configure_args="$ac_configure_args --disable-core-jni"
>  6831 ac_configure_args="$ac_configure_args --disable-examples"
>  6832 ac_configure_args="$ac_configure_args --with-glibj=build"
> 
> 
> 
> On 08/10/2014 01:58 PM, Chen Gang wrote:
>>
>> On 8/3/14 13:50, Chen Gang wrote:
>>> Excuse me, after tried, I still did not know hot to build the source
>>> code for "x86_64-unknown-linux-gnu/32/libjava/classpath/native/jni".
>>> What I have done is:
>>>
>>>  - ../gcc/configure --enable-core-jni  --enable-languages=c,c++,java
>>>    make all-target-libjava
>>>
>>>  - also try "../gcc/configure && make", but get same result.
>>>
>>>  - I also enable JNIDIRS in "x86_64-unknown-linux-gnu/libjava/classpath
>>>    /native/jni/Makefile" manually, but still no effect.
>>>
>>> Welcome any ideas, suggestions or completions for it, thank.
>>>
>>> Also sorry, I did not finish sending patch v2 for it within 2014-08-03,
>>> one excuse is: for each complete building, it needs 12-15 hours under my
>>> laptop. So next, I shall buy a PC for it (also for linux kernel).
>>>
>>
>> After try again, I can let it pass building, but I do not know whether
>> it is enough for this patch:
>>
>>  - ../gcc/configure --enable-core-jni && make
>>
>>  - enable JNIDIRS in x86_64-unknown-linux-gnu/libjava/classpath/native/
>>    Makefile, manually.
>>
>>  - then "make && make check" succeed with all related things are built.
>>
>> Before send patch v2 for it, I shall wait the confirmation from related
>> members.
>>
>>
>> Thanks.
>>
> 


-- 
Chen Gang

Open share and attitude like air water and life which God blessed

Re: [PATCH] libjava/classpath/native/jni/java-lang/java_lang_VMProcess.c: Be sure 'errbuf' always be zero terminated.

[Chen Gang]

On 8/12/14 4:20, Chen Gang wrote:
> On 08/10/2014 04:22 PM, Chen Gang wrote:
>>
>> I guess, I find the root cause:
>>

I have given the test, if remove the hardcoded "--disable-core-jni" from
libjava/configure, we can let "JNIDIR" enabled.

So I am sure, it must be the root cause.

Thanks.

> 
> Although I say "I guess", in fact, I already had related proofs for it.
> 
>  - When configure "libjava/classpath", "--disable-core-jni" is passed
>    as parameter explicitly (can check "x86_64-.../libjava/classpatch/
>    config.log" to know about it).
> 
>  - if pass "--disable-core-jni" to "libjava/classpatch/configure", it
>    will disable 'JNIDIR' in "libjava/classpath/native/jni/Makefile". If
>    remove "--disable-core-jni", it enables 'JNIDIR' to build java-lang.
> 
>  - After grep "--disaboe-core-jni", only "libjava/configure(.ac)" do it
>    (and hard code it).
> 
> For me, the proofs are enough, and the code in "libjava/configure(.ac)"
> are also obvious for it.
> 
> 
> So please check it is whether it is the root cause, when you have time.
> 
> Thanks.
> 
>> In "gcc/libjava/configure", "--disable-core-jni" is hardcoded manually
>> for classpath with FIXME, then all related trying are useless. For me,
>> if have parameter "--enable-core-jni", need skip "--disable-core-jni".
>>
>> The related information in gcc/libjava/configure:
>>
>>  6820 # Set up to configure Classpath.
>>  6821 # FIXME: no supported way to pass args in autoconf.
>>  6822 # Disable tool wrappers to avoid ltdl.h configure check.
>>  6823 ac_configure_args="$ac_configure_args --disable-tool-wrappers"
>>  6824 ac_configure_args="$ac_configure_args --disable-load-library"
>>  6825 ac_configure_args="$ac_configure_args --${LIBGCJDEBUG}-debug"
>>  6826 ac_configure_args="$ac_configure_args --enable-default-toolkit=$TOOLKIT"
>>  6827 dir1=`cd $srcdir && pwd`
>>  6828 dir2=`pwd`
>>  6829 ac_configure_args="$ac_configure_args --with-vm-classes=$dir1:$dir2"
>>  6830 ac_configure_args="$ac_configure_args --disable-core-jni"
>>  6831 ac_configure_args="$ac_configure_args --disable-examples"
>>  6832 ac_configure_args="$ac_configure_args --with-glibj=build"
>>
>>
>>
>> On 08/10/2014 01:58 PM, Chen Gang wrote:
>>>
>>> On 8/3/14 13:50, Chen Gang wrote:
>>>> Excuse me, after tried, I still did not know hot to build the source
>>>> code for "x86_64-unknown-linux-gnu/32/libjava/classpath/native/jni".
>>>> What I have done is:
>>>>
>>>>  - ../gcc/configure --enable-core-jni  --enable-languages=c,c++,java
>>>>    make all-target-libjava
>>>>
>>>>  - also try "../gcc/configure && make", but get same result.
>>>>
>>>>  - I also enable JNIDIRS in "x86_64-unknown-linux-gnu/libjava/classpath
>>>>    /native/jni/Makefile" manually, but still no effect.
>>>>
>>>> Welcome any ideas, suggestions or completions for it, thank.
>>>>
>>>> Also sorry, I did not finish sending patch v2 for it within 2014-08-03,
>>>> one excuse is: for each complete building, it needs 12-15 hours under my
>>>> laptop. So next, I shall buy a PC for it (also for linux kernel).
>>>>
>>>
>>> After try again, I can let it pass building, but I do not know whether
>>> it is enough for this patch:
>>>
>>>  - ../gcc/configure --enable-core-jni && make
>>>
>>>  - enable JNIDIRS in x86_64-unknown-linux-gnu/libjava/classpath/native/
>>>    Makefile, manually.
>>>
>>>  - then "make && make check" succeed with all related things are built.
>>>
>>> Before send patch v2 for it, I shall wait the confirmation from related
>>> members.
>>>
>>>
>>> Thanks.
>>>
>>
> 
> 

-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed