[Bug libgcj/13604] AccessController unfinished

[Bug libgcj/13604] AccessController unfinished

[tromey at gcc dot gnu dot org]

------- Additional Comments From tromey at gcc dot gnu dot org  2004-10-13 21:21 -------
See this unreviewed patch:
http://gcc.gnu.org/ml/java-patches/2004-q3/msg00372.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13604

[Bug libgcj/13604] AccessController unfinished

[aph at gcc dot gnu dot org]

------- Additional Comments From aph at gcc dot gnu dot org  2004-10-20 16:16 -------
Is there any special reason why this patch is unreviewed?  Might it make things
worse?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13604

[Bug libgcj/13604] AccessController unfinished

[mckinlay at redhat dot com]

------- Additional Comments From mckinlay at redhat dot com  2004-10-20 17:44 -------
The patch will need to be updated for the new stack trace infrastructure,
because the interface to stack traces has changed. In particular, the
gnu.gcj.runtime.StackTrace class is no longer supported. 

Either a) we could add a native part to AccessController which calls the new
stack tracer, or b) if we want AccessController to remain pure Java, something
similar to the StackTrace class (but perhaps without a gcj-specific name) could
be put back in. Either way, this decision should be made in consulation with the
Classpath hackers so we all agree on the API between AccessController and the
stack tracer.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13604

[Bug libgcj/13604] AccessController unfinished

[mckinlay at redhat dot com]

------- Additional Comments From mckinlay at redhat dot com  2004-10-20 17:45 -------
Actually using the native API is probably the better option, since having a
public stack trace API in Java is likely a security problem.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13604

[Bug libgcj/13604] AccessController unfinished

[konqueror at gmx dot de]

------- Additional Comments From konqueror at gmx dot de  2004-10-20 20:36 -------
Please put native code into VMAccessController from start if possible. 

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13604

[Bug libgcj/13604] AccessController unfinished

[tromey at gcc dot gnu dot org]

-- 

tromey at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13604

[Bug libgcj/13604] AccessController unfinished

[gbenson at redhat dot com]

------- Comment #9 from gbenson at redhat dot com  2006-07-28 10:59 -------
Fixed.


-- 

gbenson at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13604

[Bug libgcj/13604] AccessController unfinished

[gary at gcc dot gnu dot org]

------- Comment #8 from gary at gcc dot gnu dot org  2006-07-28 10:54 -------
Subject: Bug 13604

Author: gary
Date: Fri Jul 28 10:54:11 2006
New Revision: 115793

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=115793
Log:
2006-07-28  Gary Benson  <gbenson@redhat.com>
            Casey Marshall <csm@gnu.org>

        PR libgcj/13604:
        * include/java-stack.h (GetClassMethodStack): Declare.
        * stacktrace.cc (GetClassMethodStack): New method.
        * java/security/AccessController.java: Removed.
        * java/security/VMAccessController.java: New file.
        * java/security/natVMAccessController.cc: Likewise.
        * Makefile.am (nat_source_files): Added the above.
        * sources.am, Makefile.in: Rebuilt.


Added:
    trunk/libjava/java/security/VMAccessController.java
    trunk/libjava/java/security/natVMAccessController.cc
Removed:
    trunk/libjava/java/security/AccessController.java
Modified:
    trunk/libjava/ChangeLog
    trunk/libjava/Makefile.am
    trunk/libjava/Makefile.in
    trunk/libjava/include/java-stack.h
    trunk/libjava/sources.am
    trunk/libjava/stacktrace.cc


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13604

[Bug libgcj/13604] AccessController unfinished

[gbenson at redhat dot com]

-- 

gbenson at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |gbenson at redhat dot com
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2004-08-08 19:52:07         |2006-07-28 08:19:40
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13604