[Bug java/29304] New: autoconf should be used in libjava to check for fabs, fabsf and scalbn

[Bug java/29304] New: autoconf should be used in libjava to check for fabs, fabsf and scalbn

[howarth at nitro dot med dot uc dot edu]

Currently libjava doesn't check for the existance of math functions in libm
before declaring them. This results in warnings on Darwin PPC...
symbol _fabsf used from dynamic library /usr/lib/libm.dylib(fabs.o) not from
earlier dynamic library /sw/lib/gcc4/lib/libgcj.8.dylib(sf_fabs.o)
symbol _fabs used from dynamic library /usr/lib/libm.dylib(fabs.o) not from
earlier dynamic library /sw/lib/gcc4/lib/libgcj.8.dylib(s_fabs.o)
symbol _scalbn used from dynamic library /usr/lib/libm.dylib(scalb.o) not from
earlier dynamic library
/sw/lib/gcc4/lib/libgcj.8.dylib(s_scalbn.o/sw/lib/odcctool
s/bin/ld: warning suggest use of -bind_at_load, as lazy binding may result in
errors or different symbols being used
)
creating gappletviewer

We should be using wrappers like libgfortran/intrinsics/c99_functions.c does.
In this case we need...

Index: classpath/native/fdlibm/sf_fabs.c
===================================================================
--- classpath/native/fdlibm/sf_fabs.c   (revision 117342)
+++ classpath/native/fdlibm/sf_fabs.c   (working copy)
@@ -19,6 +19,8 @@

 #include "fdlibm.h"

+#ifndef HAVE_FABSF
+#define HAVE_FABSF 1
 #ifdef __STDC__
        float fabsf(float x)
 #else
@@ -31,9 +33,12 @@
        SET_FLOAT_WORD(x,ix&0x7fffffff);
         return x;
 }
+#endif

 #ifdef _DOUBLE_IS_32BITS

+#ifndef HAVE_FABS
+#define HAVE_FABS 1
 #ifdef __STDC__
        double fabs(double x)
 #else
@@ -43,5 +48,6 @@
 {
        return (double) fabsf((float) x);
 }
+#endif

 #endif /* defined(_DOUBLE_IS_32BITS) */
Index: classpath/native/fdlibm/s_scalbn.c
===================================================================
--- classpath/native/fdlibm/s_scalbn.c  (revision 117342)
+++ classpath/native/fdlibm/s_scalbn.c  (working copy)
@@ -32,6 +32,8 @@ twom54  =  5.55111512312578270212e-17, /
 huge   = 1.0e+300,
 tiny   = 1.0e-300;

+#ifndef HAVE_SCALBN
+#define HAVE_SCALBN 1
 #ifdef __STDC__
        double scalbn (double x, int n)
 #else
@@ -63,3 +65,4 @@ tiny   = 1.0e-300;
         return x*twom54;
 }
 #endif /* _DOUBLE_IS_32BITS */
+#endif


-- 
           Summary: autoconf should be used in libjava to check for fabs,
                    fabsf and scalbn
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: java
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: howarth at nitro dot med dot uc dot edu
 GCC build triplet: powerpc-apple-darwin8
  GCC host triplet: powerpc-apple-darwin8
GCC target triplet: powerpc-apple-darwin8


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29304

[Bug classpath/29304] autoconf should be used in libjava to check for fabs, fabsf and scalbn

[howarth at nitro dot med dot uc dot edu]

------- Comment #1 from howarth at nitro dot med dot uc dot edu  2006-10-01 04:17 -------
We will also need to add...

AC_CHECK_LIB([m],[fabsf],[AC_DEFINE([HAVE_FABSF],[1],[libm includes fabsf])])
AC_CHECK_LIB([m],[fabs],[AC_DEFINE([HAVE_FABS],[1],[libm includes fabs])])
AC_CHECK_LIB([m],[scalbn],[AC_DEFINE([HAVE_SCALBN],[1],[libm includes
scalbn])])

to configure.ac in libjava.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29304

[Bug classpath/29304] autoconf should be used in libjava to check for fabs, fabsf and scalbn

[egallager at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=29304

--- Comment #4 from Eric Gallager <egallager at gcc dot gnu.org> ---
(In reply to Andrew John Hughes from comment #3)
> No, this is a Classpath bug. Nothing to do with GCJ.

Does it make sense for Classpath and GCC to continue to share a bugzilla these
days? This is far from the only time I've been confused by it... would it be
possible to split them into 2 separate bug databases?
>From java-prs-return-12233-listarch-java-prs=gcc.gnu.org@gcc.gnu.org Wed Jan 02 21:48:55 2019
Return-Path: <java-prs-return-12233-listarch-java-prs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-java-prs@gcc.gnu.org
Received: (qmail 47297 invoked by alias); 2 Jan 2019 21:48:55 -0000
Mailing-List: contact java-prs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <java-prs.gcc.gnu.org>
List-Subscribe: <mailto:java-prs-subscribe@gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/java-prs/>
List-Post: <mailto:java-prs@gcc.gnu.org>
List-Help: <mailto:java-prs-help@gcc.gnu.org>, <http://gcc.gnu.org/ml/#faqs>
Sender: java-prs-owner@gcc.gnu.org
Delivered-To: mailing list java-prs@gcc.gnu.org
Received: (qmail 47245 invoked by uid 48); 2 Jan 2019 21:48:54 -0000
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: java-prs@gcc.gnu.org
Subject: [Bug classpath/29304] autoconf should be used in libjava to check
 for fabs, fabsf and scalbn
Date: Wed, 02 Jan 2019 21:48:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: classpath
X-Bugzilla-Component: classpath
X-Bugzilla-Version: 0.15
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: pinskia at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-29304-8172-nVLJRmpLVF@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-29304-8172@http.gcc.gnu.org/bugzilla/>
References: <bug-29304-8172@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2019-q1/txt/msg00001.txt.bz2
Content-length: 835

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=29304

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Eric Gallager from comment #4)
> (In reply to Andrew John Hughes from comment #3)
> > No, this is a Classpath bug. Nothing to do with GCJ.
> 
> Does it make sense for Classpath and GCC to continue to share a bugzilla
> these days? This is far from the only time I've been confused by it... would
> it be possible to split them into 2 separate bug databases?

I am less confused by the sharing because I know the history (I was one of the
folks who prompted the sharing).  I don't think it hurts having the classpath
in GCC's bugzilla and I normally monitor classpath's bug list for accidental
usage there (there was one today but it only happens once every two months so
it is low traffic).
>From java-prs-return-12234-listarch-java-prs=gcc.gnu.org@gcc.gnu.org Fri Dec 20 22:46:29 2019
Return-Path: <java-prs-return-12234-listarch-java-prs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-java-prs@gcc.gnu.org
Received: (qmail 69829 invoked by alias); 20 Dec 2019 22:46:28 -0000
Mailing-List: contact java-prs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <java-prs.gcc.gnu.org>
List-Subscribe: <mailto:java-prs-subscribe@gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/java-prs/>
List-Post: <mailto:java-prs@gcc.gnu.org>
List-Help: <mailto:java-prs-help@gcc.gnu.org>, <http://gcc.gnu.org/ml/#faqs>
Sender: java-prs-owner@gcc.gnu.org
Delivered-To: mailing list java-prs@gcc.gnu.org
Received: (qmail 69807 invoked by uid 48); 20 Dec 2019 22:46:28 -0000
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: java-prs@gcc.gnu.org
Subject: [Bug java/64044] Java emits bogus .class$ decls
Date: Fri, 20 Dec 2019 22:46:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: java
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: redi at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-64044-8172-3TbbqU8odA@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-64044-8172@http.gcc.gnu.org/bugzilla/>
References: <bug-64044-8172@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2019-q4/txt/msg00000.txt.bz2
Content-length: 137

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64044

--- Comment #7 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed by r218018