[Bug java/32247] New: -Wall enables -Wunused enables -Wunused-parameter

public inbox for java-prs@sourceware.org
help / color / mirror / Atom feed

* [Bug java/32247]  New: -Wall enables -Wunused enables -Wunused-parameter
@ 2007-06-07 16:33 cagney at redhat dot com
  2007-06-10  1:56 ` [Bug java/32247] " pinskia at gcc dot gnu dot org
                   ` (12 more replies)
  0 siblings, 13 replies; 15+ messages in thread
From: cagney at redhat dot com @ 2007-06-07 16:33 UTC (permalink / raw)
  To: java-prs

The latest java compiler (well in Fedora 7) enables -Wunused as part of -Wall. 
Is this such a good idea as this leads to -Wunused-parameter (a relatively
common thing in O-O),


-- 
           Summary: -Wall enables -Wunused enables -Wunused-parameter
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: java
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: cagney at redhat dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32247


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug java/32247] -Wall enables -Wunused enables -Wunused-parameter
  2007-06-07 16:33 [Bug java/32247] New: -Wall enables -Wunused enables -Wunused-parameter cagney at redhat dot com
@ 2007-06-10  1:56 ` pinskia at gcc dot gnu dot org
  2007-06-11 21:38 ` cagney at redhat dot com
                   ` (11 subsequent siblings)
  12 siblings, 0 replies; 15+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2007-06-10  1:56 UTC (permalink / raw)
  To: java-prs



------- Comment #1 from pinskia at gcc dot gnu dot org  2007-06-10 01:56 -------
The java source compiler has been removed from gcc 4.3 so closing as won't fix.
Also I don't think unused parameters are common in OOP but in java.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |WONTFIX


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32247


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug java/32247] -Wall enables -Wunused enables -Wunused-parameter
  2007-06-07 16:33 [Bug java/32247] New: -Wall enables -Wunused enables -Wunused-parameter cagney at redhat dot com
  2007-06-10  1:56 ` [Bug java/32247] " pinskia at gcc dot gnu dot org
@ 2007-06-11 21:38 ` cagney at redhat dot com
  2007-06-11 21:40 ` pinskia at gcc dot gnu dot org
                   ` (10 subsequent siblings)
  12 siblings, 0 replies; 15+ messages in thread
From: cagney at redhat dot com @ 2007-06-11 21:38 UTC (permalink / raw)
  To: java-prs



------- Comment #2 from cagney at redhat dot com  2007-06-11 21:38 -------
This bug is refering to the command line options parser and how it maps GCC
style options onto ECJ options.


-- 

cagney at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|WONTFIX                     |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32247


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug java/32247] -Wall enables -Wunused enables -Wunused-parameter
  2007-06-07 16:33 [Bug java/32247] New: -Wall enables -Wunused enables -Wunused-parameter cagney at redhat dot com
  2007-06-10  1:56 ` [Bug java/32247] " pinskia at gcc dot gnu dot org
  2007-06-11 21:38 ` cagney at redhat dot com
@ 2007-06-11 21:40 ` pinskia at gcc dot gnu dot org
  2007-06-11 21:44 ` cagney at redhat dot com
                   ` (9 subsequent siblings)
  12 siblings, 0 replies; 15+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2007-06-11 21:40 UTC (permalink / raw)
  To: java-prs



------- Comment #3 from pinskia at gcc dot gnu dot org  2007-06-11 21:40 -------
ecj1 is not part of GCC.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32247


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug java/32247] -Wall enables -Wunused enables -Wunused-parameter
  2007-06-07 16:33 [Bug java/32247] New: -Wall enables -Wunused enables -Wunused-parameter cagney at redhat dot com
                   ` (2 preceding siblings ...)
  2007-06-11 21:40 ` pinskia at gcc dot gnu dot org
@ 2007-06-11 21:44 ` cagney at redhat dot com
  2007-06-11 21:47 ` pinskia at gcc dot gnu dot org
                   ` (8 subsequent siblings)
  12 siblings, 0 replies; 15+ messages in thread
From: cagney at redhat dot com @ 2007-06-11 21:44 UTC (permalink / raw)
  To: java-prs



------- Comment #4 from cagney at redhat dot com  2007-06-11 21:44 -------
This is a bug in the GCJ command line parser option parser, not in ECJ.


-- 

cagney at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|INVALID                     |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32247


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug java/32247] -Wall enables -Wunused enables -Wunused-parameter
  2007-06-07 16:33 [Bug java/32247] New: -Wall enables -Wunused enables -Wunused-parameter cagney at redhat dot com
                   ` (3 preceding siblings ...)
  2007-06-11 21:44 ` cagney at redhat dot com
@ 2007-06-11 21:47 ` pinskia at gcc dot gnu dot org
  2007-06-11 21:48 ` cagney at redhat dot com
                   ` (7 subsequent siblings)
  12 siblings, 0 replies; 15+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2007-06-11 21:47 UTC (permalink / raw)
  To: java-prs



------- Comment #5 from pinskia at gcc dot gnu dot org  2007-06-11 21:47 -------
(In reply to comment #4)
> This is a bug in the GCJ command line parser option parser, not in ECJ.

Well I say it is not a bug according to the documentation :).

Really you should use -Wno-unused-paramter if you don't want the warning.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |WONTFIX


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32247


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug java/32247] -Wall enables -Wunused enables -Wunused-parameter
  2007-06-07 16:33 [Bug java/32247] New: -Wall enables -Wunused enables -Wunused-parameter cagney at redhat dot com
                   ` (4 preceding siblings ...)
  2007-06-11 21:47 ` pinskia at gcc dot gnu dot org
@ 2007-06-11 21:48 ` cagney at redhat dot com
  2007-06-11 21:53 ` pinskia at gcc dot gnu dot org
                   ` (6 subsequent siblings)
  12 siblings, 0 replies; 15+ messages in thread
From: cagney at redhat dot com @ 2007-06-11 21:48 UTC (permalink / raw)
  To: java-prs



------- Comment #6 from cagney at redhat dot com  2007-06-11 21:48 -------
That is something for _java_ developers to decide.


-- 

cagney at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|WONTFIX                     |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32247


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug java/32247] -Wall enables -Wunused enables -Wunused-parameter
  2007-06-07 16:33 [Bug java/32247] New: -Wall enables -Wunused enables -Wunused-parameter cagney at redhat dot com
                   ` (5 preceding siblings ...)
  2007-06-11 21:48 ` cagney at redhat dot com
@ 2007-06-11 21:53 ` pinskia at gcc dot gnu dot org
  2007-06-11 23:44 ` tromey at gcc dot gnu dot org
                   ` (5 subsequent siblings)
  12 siblings, 0 replies; 15+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2007-06-11 21:53 UTC (permalink / raw)
  To: java-prs



------- Comment #7 from pinskia at gcc dot gnu dot org  2007-06-11 21:53 -------
Not really because this is a standard GCC option and having it different
between java and other languages is wrong.

http://gcc.gnu.org/onlinedocs/gcc-4.2.0/gcc/Warning-Options.html

Please read the documentation before really filing a bug, really an unused
parameter is wrong because it usually means either you have conditional code
(which case you).


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |WONTFIX


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32247


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug java/32247] -Wall enables -Wunused enables -Wunused-parameter
  2007-06-07 16:33 [Bug java/32247] New: -Wall enables -Wunused enables -Wunused-parameter cagney at redhat dot com
                   ` (6 preceding siblings ...)
  2007-06-11 21:53 ` pinskia at gcc dot gnu dot org
@ 2007-06-11 23:44 ` tromey at gcc dot gnu dot org
  2007-06-11 23:50 ` pinskia at gcc dot gnu dot org
                   ` (4 subsequent siblings)
  12 siblings, 0 replies; 15+ messages in thread
From: tromey at gcc dot gnu dot org @ 2007-06-11 23:44 UTC (permalink / raw)
  To: java-prs



------- Comment #8 from tromey at gcc dot gnu dot org  2007-06-11 23:44 -------
I'm reopening this.  Andrew P., please leave it open if you would.
We chose what goes into -Wall, and this is a bug in the
implementation of that choice.


-- 

tromey at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at gcc dot gnu dot
                   |                            |org
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|WONTFIX                     |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32247


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug java/32247] -Wall enables -Wunused enables -Wunused-parameter
  2007-06-07 16:33 [Bug java/32247] New: -Wall enables -Wunused enables -Wunused-parameter cagney at redhat dot com
                   ` (7 preceding siblings ...)
  2007-06-11 23:44 ` tromey at gcc dot gnu dot org
@ 2007-06-11 23:50 ` pinskia at gcc dot gnu dot org
  2007-06-15 14:07 ` manu at gcc dot gnu dot org
                   ` (3 subsequent siblings)
  12 siblings, 0 replies; 15+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2007-06-11 23:50 UTC (permalink / raw)
  To: java-prs

------- Comment #9 from pinskia at gcc dot gnu dot org  2007-06-11 23:50 -------
There were a couple of things wrong with the way this was reported, first it
was reported against 4.1 which actually still has a java source compiler but
then it was mentioned it was really for ecj connection.  

Can people actually report against what they are really using?  If they use a
modified version of GCC from redhat, please report to them first and not to us,
we don't always know what is going on with distro's compilers.  This is the
main reason why I closed it.  The second reason is because the documentation is
quiet clear, that this option is enable.  If you don't program OOP this way,
then you have the option of disabling the option, it is not like there is no
option.  

This is really a style issue.  I can tell you how many times even in Java code
this option is useful.

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|4.1.0                       |4.3.0

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32247

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug java/32247] -Wall enables -Wunused enables -Wunused-parameter
  2007-06-07 16:33 [Bug java/32247] New: -Wall enables -Wunused enables -Wunused-parameter cagney at redhat dot com
                   ` (8 preceding siblings ...)
  2007-06-11 23:50 ` pinskia at gcc dot gnu dot org
@ 2007-06-15 14:07 ` manu at gcc dot gnu dot org
  2008-03-14 21:14 ` gopi dot reddy at motorola dot com
                   ` (2 subsequent siblings)
  12 siblings, 0 replies; 15+ messages in thread
From: manu at gcc dot gnu dot org @ 2007-06-15 14:07 UTC (permalink / raw)
  To: java-prs



------- Comment #10 from manu at gcc dot gnu dot org  2007-06-15 14:07 -------
(In reply to comment #7)
> Not really because this is a standard GCC option and having it different
> between java and other languages is wrong.
> 
> http://gcc.gnu.org/onlinedocs/gcc-4.2.0/gcc/Warning-Options.html
> 
> Please read the documentation before really filing a bug, really an unused
> parameter is wrong because it usually means either you have conditional code
> (which case you).
> 

Actually neither -Wunused nor -Wall should enable -Wunused-parameter according
to the documentation. -Wunused-parameter is only enabled by:

1) -Wunused-parameter [+ anything]
2) -Wall -Wextra
3) -Wunused -Wextra

So either Java is doing something wrong or the documentation does not reflect
the actual behaviour (very likely as well).


-- 

manu at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |manu at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32247


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug java/32247] -Wall enables -Wunused enables -Wunused-parameter
  2007-06-07 16:33 [Bug java/32247] New: -Wall enables -Wunused enables -Wunused-parameter cagney at redhat dot com
                   ` (9 preceding siblings ...)
  2007-06-15 14:07 ` manu at gcc dot gnu dot org
@ 2008-03-14 21:14 ` gopi dot reddy at motorola dot com
  2008-03-18 17:03 ` tromey at gcc dot gnu dot org
  2008-08-07 15:22 ` manu at gcc dot gnu dot org
  12 siblings, 0 replies; 15+ messages in thread
From: gopi dot reddy at motorola dot com @ 2008-03-14 21:14 UTC (permalink / raw)
  To: java-prs



------- Comment #11 from gopi dot reddy at motorola dot com  2008-03-14 21:14 -------
(In reply to comment #3)
> ecj1 is not part of GCC.

Well, it should be. I just downloaded gcc4.3.0, compiled it, and tried to
compile a simple test program.

$ gcj --version
gcj (GCC) 4.3.0
Copyright (C) 2008 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

$ gcj Hello.java
gcj: error trying to exec 'ecj1': execvp: No such file or directory


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32247


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug java/32247] -Wall enables -Wunused enables -Wunused-parameter
  2007-06-07 16:33 [Bug java/32247] New: -Wall enables -Wunused enables -Wunused-parameter cagney at redhat dot com
                   ` (10 preceding siblings ...)
  2008-03-14 21:14 ` gopi dot reddy at motorola dot com
@ 2008-03-18 17:03 ` tromey at gcc dot gnu dot org
  2008-08-07 15:22 ` manu at gcc dot gnu dot org
  12 siblings, 0 replies; 15+ messages in thread
From: tromey at gcc dot gnu dot org @ 2008-03-18 17:03 UTC (permalink / raw)
  To: java-prs



------- Comment #12 from tromey at gcc dot gnu dot org  2008-03-18 17:03 -------
I agree we should probably change ecj1's interpretation of -Wall.

But, ecj1 can't be part of gcc.  That was already decided.
I believe the installation instructions have information on what
to download so that gcj will work properly.  If not, please let me
know and I will fix that.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32247


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [Bug java/32247] -Wall enables -Wunused enables -Wunused-parameter
  2007-06-07 16:33 [Bug java/32247] New: -Wall enables -Wunused enables -Wunused-parameter cagney at redhat dot com
                   ` (11 preceding siblings ...)
  2008-03-18 17:03 ` tromey at gcc dot gnu dot org
@ 2008-08-07 15:22 ` manu at gcc dot gnu dot org
  12 siblings, 0 replies; 15+ messages in thread
From: manu at gcc dot gnu dot org @ 2008-08-07 15:22 UTC (permalink / raw)
  To: java-prs



------- Comment #13 from manu at gcc dot gnu dot org  2008-08-07 15:22 -------
Unsubscribing: not sure what is to fix here.


-- 

manu at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|manu at gcc dot gnu dot org |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32247


^ permalink raw reply	[flat|nested] 15+ messages in thread

[parent not found: <bug-32247-8172@http.gcc.gnu.org/bugzilla/>]

* [Bug java/32247] -Wall enables -Wunused enables -Wunused-parameter
       [not found] <bug-32247-8172@http.gcc.gnu.org/bugzilla/>
@ 2013-03-19 23:50 ` fche at redhat dot com
  0 siblings, 0 replies; 15+ messages in thread
From: fche at redhat dot com @ 2013-03-19 23:50 UTC (permalink / raw)
  To: java-prs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32247

Frank Ch. Eigler <fche at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fche at redhat dot com

--- Comment #14 from Frank Ch. Eigler <fche at redhat dot com> 2013-03-19 23:50:18 UTC ---
no comment


^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2013-03-19 23:50 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-06-07 16:33 [Bug java/32247] New: -Wall enables -Wunused enables -Wunused-parameter cagney at redhat dot com
2007-06-10  1:56 ` [Bug java/32247] " pinskia at gcc dot gnu dot org
2007-06-11 21:38 ` cagney at redhat dot com
2007-06-11 21:40 ` pinskia at gcc dot gnu dot org
2007-06-11 21:44 ` cagney at redhat dot com
2007-06-11 21:47 ` pinskia at gcc dot gnu dot org
2007-06-11 21:48 ` cagney at redhat dot com
2007-06-11 21:53 ` pinskia at gcc dot gnu dot org
2007-06-11 23:44 ` tromey at gcc dot gnu dot org
2007-06-11 23:50 ` pinskia at gcc dot gnu dot org
2007-06-15 14:07 ` manu at gcc dot gnu dot org
2008-03-14 21:14 ` gopi dot reddy at motorola dot com
2008-03-18 17:03 ` tromey at gcc dot gnu dot org
2008-08-07 15:22 ` manu at gcc dot gnu dot org
     [not found] <bug-32247-8172@http.gcc.gnu.org/bugzilla/>
2013-03-19 23:50 ` fche at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).