From: David Malcolm <dmalcolm@redhat.com>
To: Trevor Saunders <tbsaunde@tbsaunde.org>
Cc: gcc-patches@gcc.gnu.org, jit@gcc.gnu.org
Subject: Re: [PATCH 3/3] jit: implement gcc_jit_rvalue_set_bool_require_tail_call
Date: Fri, 01 Jan 2016 00:00:00 -0000 [thread overview]
Message-ID: <1463771828.7319.3.camel@redhat.com> (raw)
In-Reply-To: <20160517224901.GB5705@ball>
On Tue, 2016-05-17 at 18:49 -0400, Trevor Saunders wrote:
> On Tue, May 17, 2016 at 06:01:32PM -0400, David Malcolm wrote:
> > This implements the libgccjit support for must-tail-call via
> > a new:
> > gcc_jit_rvalue_set_bool_require_tail_call
> > API entrypoint.
>
> It seems to me like that's not a great name, the rvalue and bool
> parts
> are just about the argument types, not what the function does.
> Wouldn't
> gcc_jit_set_call_requires_tail_call be better?
Maybe. I was thinking of it from the point of view of methods; it's
effectively a method on gcc_jit_rvalue. The "set_bool" is for
consistency with various gcc_jit_context_ entrypoints.
FWIW, I've committed the patch as-is; all of the must-tail-call patches
are now in trunk, as of r236531.
next prev parent reply other threads:[~2016-05-20 19:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-01 0:00 [PATCH 0/3] Support for mandatory tail calls David Malcolm
2016-01-01 0:00 ` [PATCH 2/3] Implement CALL_EXPR_MUST_TAIL_CALL David Malcolm
2016-01-01 0:00 ` Jeff Law
2016-01-01 0:00 ` Andreas Schwab
2016-01-01 0:00 ` Andreas Schwab
2016-01-01 0:00 ` [PATCH] Fixes to must-tail-call tests David Malcolm
2016-01-01 0:00 ` Rainer Orth
2016-01-01 0:00 ` Thomas Preudhomme
2016-01-01 0:00 ` David Malcolm
2016-01-01 0:00 ` Jeff Law
2016-01-01 0:00 ` [PATCH 1/3] Introduce can_implement_as_sibling_call_p David Malcolm
2016-01-01 0:00 ` Jeff Law
2016-01-01 0:00 ` Kyrill Tkachov
2016-01-01 0:00 ` [PATCH] calls.c: fix warning on targets without REG_PARM_STACK_SPACE David Malcolm
2016-01-01 0:00 ` [PATCH 3/3] jit: implement gcc_jit_rvalue_set_bool_require_tail_call David Malcolm
2016-01-01 0:00 ` Trevor Saunders
2016-01-01 0:00 ` David Malcolm [this message]
2016-01-01 0:00 ` [PATCH 0/3] Support for mandatory tail calls Jeff Law
2016-01-01 0:00 ` Basile Starynkevitch
2016-01-01 0:00 ` Jason Merrill
2016-01-01 0:00 ` Richard Biener
2016-01-01 0:00 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463771828.7319.3.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
--cc=tbsaunde@tbsaunde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).