From: David Malcolm <dmalcolm@redhat.com>
To: gcc-patches@gcc.gnu.org, jit@gcc.gnu.org,
Andreas Schwab <schwab@linux-m68k.org>
Cc: David Malcolm <dmalcolm@redhat.com>
Subject: [PATCH] Fixes to must-tail-call tests
Date: Fri, 01 Jan 2016 00:00:00 -0000 [thread overview]
Message-ID: <1464106264-58571-1-git-send-email-dmalcolm@redhat.com> (raw)
In-Reply-To: <m21t4vpxbv.fsf@linux-m68k.org>
The following fixes the known failures of the must-tail-call tests.
Tested with --target=
* aarch64-unknown-linux-gnu
* ia64-unknown-linux-gnu
* m68k-unknown-linux-gnu
* x86_64-pc-linux-gnu
OK for trunk?
gcc/testsuite/ChangeLog:
* gcc.dg/plugin/must-tail-call-2.c (test_2_caller): Generalize
expected error message to allow "argument must by passed by
copying".
(test_3): Generalize expected error message to allow for failure
of targetm.function_ok_for_sibcall.
(test_4): Likewise.
(test_5): Likewise.
---
gcc/testsuite/gcc.dg/plugin/must-tail-call-2.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/gcc/testsuite/gcc.dg/plugin/must-tail-call-2.c b/gcc/testsuite/gcc.dg/plugin/must-tail-call-2.c
index c5504f8..ca81b35 100644
--- a/gcc/testsuite/gcc.dg/plugin/must-tail-call-2.c
+++ b/gcc/testsuite/gcc.dg/plugin/must-tail-call-2.c
@@ -29,14 +29,14 @@ int __attribute__((noinline,noclone))
test_2_caller (int i)
{
struct box b;
- return test_2_callee (i + 1, b); /* { dg-error "cannot tail-call: callee required more stack slots than the caller" } */
+ return test_2_callee (i + 1, b); /* { dg-error "cannot tail-call: callee required more stack slots than the caller|argument must be passed by copying" } */
}
extern void setjmp (void);
void
test_3 (void)
{
- setjmp (); /* { dg-error "cannot tail-call: callee returns twice" } */
+ setjmp (); /* { dg-error "cannot tail-call: callee returns twice|target is not able to optimize the call into a sibling call" } */
}
void
@@ -45,7 +45,7 @@ test_4 (void)
void nested (void)
{
}
- nested (); /* { dg-error "cannot tail-call: nested function" } */
+ nested (); /* { dg-error "cannot tail-call: nested function|target is not able to optimize the call into a sibling call" } */
}
typedef void (fn_ptr_t) (void);
@@ -54,5 +54,5 @@ volatile fn_ptr_t fn_ptr;
void
test_5 (void)
{
- fn_ptr (); /* { dg-error "cannot tail-call: callee does not return" } */
+ fn_ptr (); /* { dg-error "cannot tail-call: callee does not return|target is not able to optimize the call into a sibling call" } */
}
--
1.8.5.3
next prev parent reply other threads:[~2016-05-24 15:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-01 0:00 [PATCH 0/3] Support for mandatory tail calls David Malcolm
2016-01-01 0:00 ` [PATCH 3/3] jit: implement gcc_jit_rvalue_set_bool_require_tail_call David Malcolm
2016-01-01 0:00 ` Trevor Saunders
2016-01-01 0:00 ` David Malcolm
2016-01-01 0:00 ` [PATCH 1/3] Introduce can_implement_as_sibling_call_p David Malcolm
2016-01-01 0:00 ` Jeff Law
2016-01-01 0:00 ` Kyrill Tkachov
2016-01-01 0:00 ` [PATCH] calls.c: fix warning on targets without REG_PARM_STACK_SPACE David Malcolm
2016-01-01 0:00 ` [PATCH 2/3] Implement CALL_EXPR_MUST_TAIL_CALL David Malcolm
2016-01-01 0:00 ` Andreas Schwab
2016-01-01 0:00 ` Andreas Schwab
2016-01-01 0:00 ` David Malcolm [this message]
2016-01-01 0:00 ` [PATCH] Fixes to must-tail-call tests Rainer Orth
2016-01-01 0:00 ` Thomas Preudhomme
2016-01-01 0:00 ` David Malcolm
2016-01-01 0:00 ` Jeff Law
2016-01-01 0:00 ` [PATCH 2/3] Implement CALL_EXPR_MUST_TAIL_CALL Jeff Law
2016-01-01 0:00 ` [PATCH 0/3] Support for mandatory tail calls Jeff Law
2016-01-01 0:00 ` Basile Starynkevitch
2016-01-01 0:00 ` Jason Merrill
2016-01-01 0:00 ` Richard Biener
2016-01-01 0:00 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464106264-58571-1-git-send-email-dmalcolm@redhat.com \
--to=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).