From: Andreas Schwab <schwab@linux-m68k.org>
To: David Malcolm <dmalcolm@redhat.com>
Cc: gcc-patches@gcc.gnu.org, jit@gcc.gnu.org
Subject: Re: [PATCH 2/3] Implement CALL_EXPR_MUST_TAIL_CALL
Date: Fri, 01 Jan 2016 00:00:00 -0000 [thread overview]
Message-ID: <m21t4vpxbv.fsf@linux-m68k.org> (raw)
In-Reply-To: <1463522492-43504-3-git-send-email-dmalcolm@redhat.com> (David Malcolm's message of "Tue, 17 May 2016 18:01:31 -0400")
David Malcolm <dmalcolm@redhat.com> writes:
> diff --git a/gcc/testsuite/gcc.dg/plugin/must-tail-call-2.c b/gcc/testsuite/gcc.dg/plugin/must-tail-call-2.c
> new file mode 100644
> index 0000000..c5504f8
> --- /dev/null
> +++ b/gcc/testsuite/gcc.dg/plugin/must-tail-call-2.c
> @@ -0,0 +1,58 @@
> +/* Allow nested functions. */
> +/* { dg-options "-Wno-pedantic" } */
> +
> +struct box { char field[64]; int i; };
> +
> +struct box __attribute__((noinline,noclone))
> +returns_struct (int i)
> +{
> + struct box b;
> + b.i = i * i;
> + return b;
> +}
> +
> +int __attribute__((noinline,noclone))
> +test_1 (int i)
> +{
> + return returns_struct (i * 5).i; /* { dg-error "cannot tail-call: callee returns a structure" } */
> +}
> +
> +int __attribute__((noinline,noclone))
> +test_2_callee (int i, struct box b)
> +{
> + if (b.field[0])
> + return 5;
> + return i * i;
> +}
> +
> +int __attribute__((noinline,noclone))
> +test_2_caller (int i)
> +{
> + struct box b;
> + return test_2_callee (i + 1, b); /* { dg-error "cannot tail-call: callee required more stack slots than the caller" } */
> +}
> +
> +extern void setjmp (void);
> +void
> +test_3 (void)
> +{
> + setjmp (); /* { dg-error "cannot tail-call: callee returns twice" } */
> +}
> +
> +void
> +test_4 (void)
> +{
> + void nested (void)
> + {
> + }
> + nested (); /* { dg-error "cannot tail-call: nested function" } */
> +}
> +
> +typedef void (fn_ptr_t) (void);
> +volatile fn_ptr_t fn_ptr;
> +
> +void
> +test_5 (void)
> +{
> + fn_ptr (); /* { dg-error "cannot tail-call: callee does not return" } */
> +}
On ia64:
FAIL: gcc.dg/plugin/must-tail-call-2.c -fplugin=./must_tail_call_plugin.so (test for errors, line 39)
FAIL: gcc.dg/plugin/must-tail-call-2.c -fplugin=./must_tail_call_plugin.so (test for errors, line 57)
FAIL: gcc.dg/plugin/must-tail-call-2.c -fplugin=./must_tail_call_plugin.so (test for excess errors)
Excess errors:
gcc.dg/plugin/must-tail-call-2.c:39:3: error: cannot tail-call: target is not able to optimize the call into a sibling call
gcc.dg/plugin/must-tail-call-2.c:57:3: error: cannot tail-call: target is not able to optimize the call into a sibling call
On m68k:
FAIL: gcc.dg/plugin/must-tail-call-2.c -fplugin=./must_tail_call_plugin.so (test for errors, line 48)
FAIL: gcc.dg/plugin/must-tail-call-2.c -fplugin=./must_tail_call_plugin.so (test for excess errors)
Excess errors:
gcc.dg/plugin/must-tail-call-2.c:48:3: error: cannot tail-call: target is not able to optimize the call into a sibling call
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2016-05-21 9:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-01 0:00 [PATCH 0/3] Support for mandatory tail calls David Malcolm
2016-01-01 0:00 ` Jeff Law
2016-01-01 0:00 ` Basile Starynkevitch
2016-01-01 0:00 ` Jason Merrill
2016-01-01 0:00 ` Richard Biener
2016-01-01 0:00 ` Jason Merrill
2016-01-01 0:00 ` [PATCH 1/3] Introduce can_implement_as_sibling_call_p David Malcolm
2016-01-01 0:00 ` Kyrill Tkachov
2016-01-01 0:00 ` [PATCH] calls.c: fix warning on targets without REG_PARM_STACK_SPACE David Malcolm
2016-01-01 0:00 ` [PATCH 1/3] Introduce can_implement_as_sibling_call_p Jeff Law
2016-01-01 0:00 ` [PATCH 3/3] jit: implement gcc_jit_rvalue_set_bool_require_tail_call David Malcolm
2016-01-01 0:00 ` Trevor Saunders
2016-01-01 0:00 ` David Malcolm
2016-01-01 0:00 ` [PATCH 2/3] Implement CALL_EXPR_MUST_TAIL_CALL David Malcolm
2016-01-01 0:00 ` Jeff Law
2016-01-01 0:00 ` Andreas Schwab [this message]
2016-01-01 0:00 ` [PATCH] Fixes to must-tail-call tests David Malcolm
2016-01-01 0:00 ` Rainer Orth
2016-01-01 0:00 ` Thomas Preudhomme
2016-01-01 0:00 ` David Malcolm
2016-01-01 0:00 ` Jeff Law
2016-01-01 0:00 ` [PATCH 2/3] Implement CALL_EXPR_MUST_TAIL_CALL Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m21t4vpxbv.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).