From: David Malcolm <dmalcolm@redhat.com>
To: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>,
gcc-patches@gcc.gnu.org, jit@gcc.gnu.org
Cc: David Malcolm <dmalcolm@redhat.com>
Subject: [PATCH] calls.c: fix warning on targets without REG_PARM_STACK_SPACE
Date: Fri, 01 Jan 2016 00:00:00 -0000 [thread overview]
Message-ID: <1463772137-9323-1-git-send-email-dmalcolm@redhat.com> (raw)
In-Reply-To: <573F4368.8090902@foss.arm.com>
On Fri, 2016-05-20 at 18:03 +0100, Kyrill Tkachov wrote:
[...snip...]
> REG_PARM_STACK_SPACE is not defined on arm, which makes
> reg_parm_stack_space
> unused in this function and so breaks bootstrap on arm.
> Can you please add an ATTRIBUTE_UNUSED to reg_parm_stack_space?
>
> Thanks,
> Kyrill
[...snip...]
Sorry about the breakage.
I manually verified that the following fixes the warning with
--target=arm-linux-gnueabi.
Successfully bootstrapped®rtested on x86_64-pc-linux-gnu.
Committed to trunk as r236527.
gcc/ChangeLog:
* calls.c (can_implement_as_sibling_call_p): Mark param
reg_parm_stack_space with ATTRIBUTE_UNUSED.
---
gcc/calls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/calls.c b/gcc/calls.c
index 1b12eca..587969f 100644
--- a/gcc/calls.c
+++ b/gcc/calls.c
@@ -2373,7 +2373,7 @@ static bool
can_implement_as_sibling_call_p (tree exp,
rtx structure_value_addr,
tree funtype,
- int reg_parm_stack_space,
+ int reg_parm_stack_space ATTRIBUTE_UNUSED,
tree fndecl,
int flags,
tree addr,
--
1.8.5.3
prev parent reply other threads:[~2016-05-20 18:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-01 0:00 [PATCH 0/3] Support for mandatory tail calls David Malcolm
2016-01-01 0:00 ` Jeff Law
2016-01-01 0:00 ` Basile Starynkevitch
2016-01-01 0:00 ` Jason Merrill
2016-01-01 0:00 ` Richard Biener
2016-01-01 0:00 ` Jason Merrill
2016-01-01 0:00 ` [PATCH 2/3] Implement CALL_EXPR_MUST_TAIL_CALL David Malcolm
2016-01-01 0:00 ` Jeff Law
2016-01-01 0:00 ` Andreas Schwab
2016-01-01 0:00 ` Andreas Schwab
2016-01-01 0:00 ` [PATCH] Fixes to must-tail-call tests David Malcolm
2016-01-01 0:00 ` Rainer Orth
2016-01-01 0:00 ` Thomas Preudhomme
2016-01-01 0:00 ` David Malcolm
2016-01-01 0:00 ` Jeff Law
2016-01-01 0:00 ` [PATCH 3/3] jit: implement gcc_jit_rvalue_set_bool_require_tail_call David Malcolm
2016-01-01 0:00 ` Trevor Saunders
2016-01-01 0:00 ` David Malcolm
2016-01-01 0:00 ` [PATCH 1/3] Introduce can_implement_as_sibling_call_p David Malcolm
2016-01-01 0:00 ` Jeff Law
2016-01-01 0:00 ` Kyrill Tkachov
2016-01-01 0:00 ` David Malcolm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463772137-9323-1-git-send-email-dmalcolm@redhat.com \
--to=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
--cc=kyrylo.tkachov@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).