From: Guillaume Gomez <guillaume1.gomez@gmail.com>
To: Antoni Boucher <bouanto@zoho.com>
Cc: gcc-patches@gcc.gnu.org, jit@gcc.gnu.org
Subject: Re: [PATCH] libgccjit: Fix a failing test
Date: Thu, 15 Dec 2022 08:34:33 +0100 [thread overview]
Message-ID: <CAAOQCfQEu+4D9n3QrL2Z2mic0JKUN0V9+PBqNLmkXqMaD7RV-g@mail.gmail.com> (raw)
In-Reply-To: <817e1aaf5f61ebeb2f607d9a7411ca0570e8213f.camel@zoho.com>
[-- Attachment #1.1: Type: text/plain, Size: 526 bytes --]
Forgot it indeed, thanks for notifying me!
I modified the commit message to add it and added it into this email.
Le mer. 14 déc. 2022 à 16:12, Antoni Boucher <bouanto@zoho.com> a écrit :
> Thanks!
>
> In your patch, you're missing this line at the end of the commit
> message:
>
> Signed-off-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
>
> On Wed, 2022-12-14 at 14:39 +0100, Guillaume Gomez via Jit wrote:
> > Hi,
> >
> > This fixes bug 107999.
> >
> > Thanks in advance for the review.
>
>
[-- Attachment #2: 0001-Fix-a-failing-test-by-updating-its-error-string.patch --]
[-- Type: text/x-patch, Size: 1079 bytes --]
From 30f049d4f39de392dbb3cff4b64779f2507fc914 Mon Sep 17 00:00:00 2001
From: Guillaume Gomez <guillaume1.gomez@gmail.com>
Date: Wed, 14 Dec 2022 14:28:22 +0100
Subject: [PATCH] Fix a failing test by updating its error string.
gcc/testsuite/ChangeLog:
* jit.dg/test-error-array-bounds.c: Update test.
Signed-off-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
---
gcc/testsuite/jit.dg/test-error-array-bounds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/testsuite/jit.dg/test-error-array-bounds.c b/gcc/testsuite/jit.dg/test-error-array-bounds.c
index b6c0ee526d4..a0dead13cb7 100644
--- a/gcc/testsuite/jit.dg/test-error-array-bounds.c
+++ b/gcc/testsuite/jit.dg/test-error-array-bounds.c
@@ -70,5 +70,5 @@ verify_code (gcc_jit_context *ctxt, gcc_jit_result *result)
/* ...and that the message was captured by the API. */
CHECK_STRING_VALUE (gcc_jit_context_get_first_error (ctxt),
"array subscript 10 is above array bounds of"
- " 'char[10]' [-Warray-bounds]");
+ " 'char[10]' [-Warray-bounds=]");
}
--
2.34.1
next prev parent reply other threads:[~2022-12-15 7:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 13:39 Guillaume Gomez
2022-12-14 15:12 ` Antoni Boucher
2022-12-15 7:34 ` Guillaume Gomez [this message]
2022-12-24 20:01 ` Guillaume Gomez
2023-01-05 22:37 ` Guillaume Gomez
2023-01-16 14:08 ` Guillaume Gomez
2023-03-02 19:41 ` Guillaume Gomez
2023-03-02 21:58 ` David Malcolm
2023-03-02 22:19 ` Guillaume Gomez
2023-03-02 22:29 ` Guillaume Gomez
2023-03-02 22:33 ` David Malcolm
2023-03-02 22:35 ` Guillaume Gomez
2023-03-02 22:54 ` David Malcolm
2023-03-03 9:31 ` Guillaume Gomez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAOQCfQEu+4D9n3QrL2Z2mic0JKUN0V9+PBqNLmkXqMaD7RV-g@mail.gmail.com \
--to=guillaume1.gomez@gmail.com \
--cc=bouanto@zoho.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).