public inbox for jit@gcc.gnu.org
 help / color / mirror / Atom feed
From: Guillaume Gomez <guillaume1.gomez@gmail.com>
To: David Malcolm <dmalcolm@redhat.com>
Cc: Antoni Boucher <bouanto@zoho.com>,
	gcc-patches@gcc.gnu.org, jit@gcc.gnu.org
Subject: Re: [PATCH] libgccjit: Fix a failing test
Date: Thu, 2 Mar 2023 23:29:21 +0100	[thread overview]
Message-ID: <CAAOQCfRhbPtox-wS+OdwGa4RKUCLBdEJCJLD7Hd3YcnHM0rDxg@mail.gmail.com> (raw)
In-Reply-To: <CAAOQCfR9gTkBb_xk0qP6Vdr5vKhgykzMppWUXV=r5v_Hua0NnA@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1331 bytes --]

Just realized I used whitespace and not a tab. Sorry about that. Here's the
fixed version...

Le jeu. 2 mars 2023 à 23:19, Guillaume Gomez <guillaume1.gomez@gmail.com> a
écrit :

> No problem, thanks for the explanations.
>
> I joined the patch with the fixed commit message.
>
> Le jeu. 2 mars 2023 à 22:58, David Malcolm <dmalcolm@redhat.com> a écrit :
>
>> On Thu, 2022-12-15 at 08:34 +0100, Guillaume Gomez via Jit wrote:
>> > Forgot it indeed, thanks for notifying me!
>> >
>> > I modified the commit message to add it and added it into this email.
>>
>> Sorry about the delay in reviewing this; for some reason I didn't see
>> the mail.
>>
>> The patch looks good for trunk, but please add a reference to
>>   PR jit/107999
>> to the subject line and ChangeLog message.
>>
>> Dave
>>
>> >
>> > Le mer. 14 déc. 2022 à 16:12, Antoni Boucher <bouanto@zoho.com> a
>> > écrit :
>> >
>> > > Thanks!
>> > >
>> > > In your patch, you're missing this line at the end of the commit
>> > > message:
>> > >
>> > >    Signed-off-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
>> > >
>> > > On Wed, 2022-12-14 at 14:39 +0100, Guillaume Gomez via Jit wrote:
>> > > > Hi,
>> > > >
>> > > > This fixes bug 107999.
>> > > >
>> > > > Thanks in advance for the review.
>> > >
>> > >
>>
>>

[-- Attachment #2: 0001-Fix-a-failing-test-by-updating-its-error-string.patch --]
[-- Type: text/x-patch, Size: 1112 bytes --]

From 0835c7ba8bdf4090c7fb102206e70c1ed235808e Mon Sep 17 00:00:00 2001
From: Guillaume Gomez <guillaume1.gomez@gmail.com>
Date: Wed, 14 Dec 2022 14:28:22 +0100
Subject: [PATCH] [PATCH] Fix a failing test by updating its error string
 [PR107999]

gcc/testsuite/ChangeLog:
	PR jit/107999
	* jit.dg/test-error-array-bounds.c: Update test.

Signed-off-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
---
 gcc/testsuite/jit.dg/test-error-array-bounds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/jit.dg/test-error-array-bounds.c b/gcc/testsuite/jit.dg/test-error-array-bounds.c
index b6c0ee526d4..a0dead13cb7 100644
--- a/gcc/testsuite/jit.dg/test-error-array-bounds.c
+++ b/gcc/testsuite/jit.dg/test-error-array-bounds.c
@@ -70,5 +70,5 @@ verify_code (gcc_jit_context *ctxt, gcc_jit_result *result)
   /* ...and that the message was captured by the API.  */
   CHECK_STRING_VALUE (gcc_jit_context_get_first_error (ctxt),
 		      "array subscript 10 is above array bounds of"
-		      " 'char[10]' [-Warray-bounds]");
+		      " 'char[10]' [-Warray-bounds=]");
 }
-- 
2.34.1


  reply	other threads:[~2023-03-02 22:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-14 13:39 Guillaume Gomez
2022-12-14 15:12 ` Antoni Boucher
2022-12-15  7:34   ` Guillaume Gomez
2022-12-24 20:01     ` Guillaume Gomez
2023-01-05 22:37       ` Guillaume Gomez
2023-01-16 14:08         ` Guillaume Gomez
2023-03-02 19:41           ` Guillaume Gomez
2023-03-02 21:58     ` David Malcolm
2023-03-02 22:19       ` Guillaume Gomez
2023-03-02 22:29         ` Guillaume Gomez [this message]
2023-03-02 22:33           ` David Malcolm
2023-03-02 22:35             ` Guillaume Gomez
2023-03-02 22:54               ` David Malcolm
2023-03-03  9:31                 ` Guillaume Gomez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAOQCfRhbPtox-wS+OdwGa4RKUCLBdEJCJLD7Hd3YcnHM0rDxg@mail.gmail.com \
    --to=guillaume1.gomez@gmail.com \
    --cc=bouanto@zoho.com \
    --cc=dmalcolm@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jit@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).