Re: [PATCH] libgccjit: Fix a failing test

[Guillaume Gomez <guillaume1.gomez@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1100 bytes --]

No problem, thanks for the explanations.

I joined the patch with the fixed commit message.

Le jeu. 2 mars 2023 à 22:58, David Malcolm <dmalcolm@redhat.com> a écrit :

> On Thu, 2022-12-15 at 08:34 +0100, Guillaume Gomez via Jit wrote:
> > Forgot it indeed, thanks for notifying me!
> >
> > I modified the commit message to add it and added it into this email.
>
> Sorry about the delay in reviewing this; for some reason I didn't see
> the mail.
>
> The patch looks good for trunk, but please add a reference to
>   PR jit/107999
> to the subject line and ChangeLog message.
>
> Dave
>
> >
> > Le mer. 14 déc. 2022 à 16:12, Antoni Boucher <bouanto@zoho.com> a
> > écrit :
> >
> > > Thanks!
> > >
> > > In your patch, you're missing this line at the end of the commit
> > > message:
> > >
> > >    Signed-off-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
> > >
> > > On Wed, 2022-12-14 at 14:39 +0100, Guillaume Gomez via Jit wrote:
> > > > Hi,
> > > >
> > > > This fixes bug 107999.
> > > >
> > > > Thanks in advance for the review.
> > >
> > >
>
>

[-- Attachment #2: 0001-Fix-a-failing-test-by-updating-its-error-string.patch --]
[-- Type: text/x-patch, Size: 1119 bytes --]

From 985228a76feecf16658b95a012e0b531e7e5c750 Mon Sep 17 00:00:00 2001
From: Guillaume Gomez <guillaume1.gomez@gmail.com>
Date: Wed, 14 Dec 2022 14:28:22 +0100
Subject: [PATCH] [PATCH] Fix a failing test by updating its error string
 [PR107999]

gcc/testsuite/ChangeLog:
        PR jit/107999
	* jit.dg/test-error-array-bounds.c: Update test.

Signed-off-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
---
 gcc/testsuite/jit.dg/test-error-array-bounds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/jit.dg/test-error-array-bounds.c b/gcc/testsuite/jit.dg/test-error-array-bounds.c
index b6c0ee526d4..a0dead13cb7 100644
--- a/gcc/testsuite/jit.dg/test-error-array-bounds.c
+++ b/gcc/testsuite/jit.dg/test-error-array-bounds.c
@@ -70,5 +70,5 @@ verify_code (gcc_jit_context *ctxt, gcc_jit_result *result)
   /* ...and that the message was captured by the API.  */
   CHECK_STRING_VALUE (gcc_jit_context_get_first_error (ctxt),
 		      "array subscript 10 is above array bounds of"
-		      " 'char[10]' [-Warray-bounds]");
+		      " 'char[10]' [-Warray-bounds=]");
 }
-- 
2.34.1