From: David Malcolm <dmalcolm@redhat.com>
To: Guillaume Gomez <guillaume1.gomez@gmail.com>,
Antoni Boucher <bouanto@zoho.com>
Cc: gcc-patches@gcc.gnu.org, jit@gcc.gnu.org
Subject: Re: [PATCH] libgccjit: Fix a failing test
Date: Thu, 02 Mar 2023 16:58:15 -0500 [thread overview]
Message-ID: <c0357ad1bee09066dbe535abd6b4e3fb1eaa0ded.camel@redhat.com> (raw)
In-Reply-To: <CAAOQCfQEu+4D9n3QrL2Z2mic0JKUN0V9+PBqNLmkXqMaD7RV-g@mail.gmail.com>
On Thu, 2022-12-15 at 08:34 +0100, Guillaume Gomez via Jit wrote:
> Forgot it indeed, thanks for notifying me!
>
> I modified the commit message to add it and added it into this email.
Sorry about the delay in reviewing this; for some reason I didn't see
the mail.
The patch looks good for trunk, but please add a reference to
PR jit/107999
to the subject line and ChangeLog message.
Dave
>
> Le mer. 14 déc. 2022 à 16:12, Antoni Boucher <bouanto@zoho.com> a
> écrit :
>
> > Thanks!
> >
> > In your patch, you're missing this line at the end of the commit
> > message:
> >
> > Signed-off-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
> >
> > On Wed, 2022-12-14 at 14:39 +0100, Guillaume Gomez via Jit wrote:
> > > Hi,
> > >
> > > This fixes bug 107999.
> > >
> > > Thanks in advance for the review.
> >
> >
next prev parent reply other threads:[~2023-03-02 21:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 13:39 Guillaume Gomez
2022-12-14 15:12 ` Antoni Boucher
2022-12-15 7:34 ` Guillaume Gomez
2022-12-24 20:01 ` Guillaume Gomez
2023-01-05 22:37 ` Guillaume Gomez
2023-01-16 14:08 ` Guillaume Gomez
2023-03-02 19:41 ` Guillaume Gomez
2023-03-02 21:58 ` David Malcolm [this message]
2023-03-02 22:19 ` Guillaume Gomez
2023-03-02 22:29 ` Guillaume Gomez
2023-03-02 22:33 ` David Malcolm
2023-03-02 22:35 ` Guillaume Gomez
2023-03-02 22:54 ` David Malcolm
2023-03-03 9:31 ` Guillaume Gomez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0357ad1bee09066dbe535abd6b4e3fb1eaa0ded.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=bouanto@zoho.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=guillaume1.gomez@gmail.com \
--cc=jit@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).