From: Mark Wielaard <mark@klomp.org>
To: Dodji Seketeli <dodji@seketeli.org>,
Thomas Schwinge <thomas@codesourcery.com>
Cc: libabigail@sourceware.org
Subject: Re: [PATCH] Replace use of deprecated Python 'imp' module with 'importlib'
Date: Tue, 21 Dec 2021 14:43:19 +0100 [thread overview]
Message-ID: <660b800832668cba9415c01d7cf5ab49438dba98.camel@klomp.org> (raw)
In-Reply-To: <87fsqm84ps.fsf@seketeli.org>
Hi,
On Tue, 2021-12-21 at 14:31 +0100, Dodji Seketeli wrote:
> Thomas Schwinge <thomas@codesourcery.com> a écrit:
>
> > In the test logs, I've found a number of:
> >
> > [...]/tests/mockfedabipkgdiff:42: DeprecationWarning: the imp
> > module is deprecated in favour of importlib; see the module's
> > documentation for alternative uses
> > import imp
> >
> > I've asked The Internet what to do about that, and this commit is
> > the result.
> > But beware: I'm not a Python wizard.
> >
> > * tests/mockfedabipkgdiff.in: Replace use of deprecated Python
> > 'imp' module with 'importlib'.
> >
> > CC: Chenxiong Qi <cqi@redhat.com>
> > Signed-off-by: Thomas Schwinge <thomas@codesourcery.com>
>
> Applied to master. Thanks!
The buildbot is a little slow being busy with elfutil commits:
https://builder.wildebeest.org/buildbot/#/pendingbuildrequests
But this seems to have broken something on centos7 x86_64:
https://builder.wildebeest.org/buildbot/#/changes/7273
File "/srv/buildbot/worker/libabigail-centos-
x86_64/build/tests/mockfedabipkgdiff", line 73, in <module>
fedabipkgdiff_mod =
importlib.machinery.SourceFileLoader('fedabipkgdiff',
FEDABIPKGDIFF).load_module()
AttributeError: 'module' object has no attribute 'machinery'
Cheers,
Mark
next prev parent reply other threads:[~2021-12-21 13:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 22:26 Thomas Schwinge
2021-12-21 13:31 ` Dodji Seketeli
2021-12-21 13:43 ` Mark Wielaard [this message]
2021-12-21 14:04 ` [PATCH] Replace Python 'import importlib' with 'import importlib.machinery' Thomas Schwinge
2021-12-21 15:06 ` Dodji Seketeli
2021-12-21 15:43 ` Mark Wielaard
2021-12-21 16:19 ` Thomas Schwinge
2021-12-21 19:41 ` [PATCH] Handle several variants of Python 'imp', 'importlib' modules Thomas Schwinge
2022-01-03 16:33 ` Dodji Seketeli
2022-01-05 15:32 ` Thomas Schwinge
2022-01-06 14:44 ` Dodji Seketeli
2022-01-04 14:51 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=660b800832668cba9415c01d7cf5ab49438dba98.camel@klomp.org \
--to=mark@klomp.org \
--cc=dodji@seketeli.org \
--cc=libabigail@sourceware.org \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).