From: Dodji Seketeli <dodji@seketeli.org>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: libabigail@sourceware.org, Mark Wielaard <mark@klomp.org>
Subject: Re: [PATCH] Handle several variants of Python 'imp', 'importlib' modules
Date: Mon, 03 Jan 2022 17:33:30 +0100 [thread overview]
Message-ID: <87ee5oeq3p.fsf@seketeli.org> (raw)
In-Reply-To: <20211221194117.2386192-1-thomas@codesourcery.com> (Thomas Schwinge's message of "Tue, 21 Dec 2021 20:41:17 +0100")
Hello Thomas,
Happy New Years!
Thomas Schwinge <thomas@codesourcery.com> a écrit:
> Fix-up for recent commit f0582fdbf1267f0f34bf3c3b6698b60026410146
> "Replace use of deprecated Python 'imp' module with 'importlib'", and
> commit cc1f38ffedb8d456d43fb52c369409037c5ca4a
> "Replace Python 'import importlib' with 'import importlib.machinery'",
> because... compatibility.
>
> Once more, I've asked The Internet what to do about that, and this commit is
> the result. But beware: I'm still not much of a Python wizard.
>
> * tests/mockfedabipkgdiff.in: Handle several variants of Python
> 'imp', 'importlib' modules.
The patch looks good to me.
However, it lacks the 'signed-of-by' mention.
[...]
Cheers,
--
Dodji
next prev parent reply other threads:[~2022-01-04 18:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 22:26 [PATCH] Replace use of deprecated Python 'imp' module with 'importlib' Thomas Schwinge
2021-12-21 13:31 ` Dodji Seketeli
2021-12-21 13:43 ` Mark Wielaard
2021-12-21 14:04 ` [PATCH] Replace Python 'import importlib' with 'import importlib.machinery' Thomas Schwinge
2021-12-21 15:06 ` Dodji Seketeli
2021-12-21 15:43 ` Mark Wielaard
2021-12-21 16:19 ` Thomas Schwinge
2021-12-21 19:41 ` [PATCH] Handle several variants of Python 'imp', 'importlib' modules Thomas Schwinge
2022-01-03 16:33 ` Dodji Seketeli [this message]
2022-01-05 15:32 ` Thomas Schwinge
2022-01-06 14:44 ` Dodji Seketeli
2022-01-04 14:51 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee5oeq3p.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=libabigail@sourceware.org \
--cc=mark@klomp.org \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).