Re: [PATCH] Replace Python 'import importlib' with 'import importlib.machinery'

[Mark Wielaard <mark@klomp.org>]

Hi,

On Tue, 2021-12-21 at 16:06 +0100, Dodji Seketeli wrote:
> Thomas Schwinge <thomas@codesourcery.com> a écrit:
> 
> > Fix-up for recent commit f0582fdbf1267f0f34bf3c3b6698b60026410146
> > "Replace use of deprecated Python 'imp' module with 'importlib'",
> > which...
> > 
> >     [...] seems to have broken something on centos7 x86_64:
> > 
> >     https://builder.wildebeest.org/buildbot/#/changes/7273
> > 
> >       File "/srv/buildbot/worker/libabigail-centos-
> > x86_64/build/tests/mockfedabipkgdiff", line 73, in <module>
> >         fedabipkgdiff_mod =
> > importlib.machinery.SourceFileLoader('fedabipkgdiff',
> > FEDABIPKGDIFF).load_module()
> >     AttributeError: 'module' object has no attribute 'machinery'
> > 
> > Again, I've asked The Internet what to do about that, and this
> > commit is the
> > result.  But beware: I'm still not a Python wizard.
> > 
> > 	* tests/mockfedabipkgdiff.in: Replace Python 'import importlib'
> > 	with 'import importlib.machinery'.
> 
> Applied to master.

Sadly still failing:
https://builder.wildebeest.org/buildbot/#/builders/8/builds/802

Note that this is a centos7 install with just python2 and there is no
python3-koji, only python2-koji, which is needed to run the
runtestfedabipkgdiff.py test.

Maybe this test should just be disabled for python2 only systems?

Cheers,

Mark