* [PATCH] elf-helpers: make sure config.h is included first
@ 2023-05-01 20:20 Dmitry V. Levin
2023-05-11 16:24 ` Dodji Seketeli
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry V. Levin @ 2023-05-01 20:20 UTC (permalink / raw)
To: libabigail
Before this change, verify-elf used to complain on x86 and armv7:
verify-elf: ERROR: ./usr/lib/libabigail.so.2.0.0: uses non-LFS functions: open
Include config.h in abg-elf-helpers.cc before other headers so that
AC_SYS_LARGEFILE applies to this file. This fully enables LFS
in those of 32-bit systems that do not enable it by default.
* src/abg-elf-helpers.cc: Include "config.h" first.
Fixes: 7bd69830520f ("Make Front Ends first class citizens")
Signed-off-by: Dmitry V. Levin <ldv@strace.io>
---
src/abg-elf-helpers.cc | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/abg-elf-helpers.cc b/src/abg-elf-helpers.cc
index d47c1c39..e05dccdc 100644
--- a/src/abg-elf-helpers.cc
+++ b/src/abg-elf-helpers.cc
@@ -6,6 +6,7 @@
/// @file
///
/// This contains the definitions of the ELF utilities for the dwarf reader.
+#include "config.h"
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
--
ldv
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] elf-helpers: make sure config.h is included first
2023-05-01 20:20 [PATCH] elf-helpers: make sure config.h is included first Dmitry V. Levin
@ 2023-05-11 16:24 ` Dodji Seketeli
0 siblings, 0 replies; 2+ messages in thread
From: Dodji Seketeli @ 2023-05-11 16:24 UTC (permalink / raw)
To: Dmitry V. Levin; +Cc: libabigail
Hello Dmitry,
"Dmitry V. Levin" <ldv@strace.io> a écrit:
> Before this change, verify-elf used to complain on x86 and armv7:
> verify-elf: ERROR: ./usr/lib/libabigail.so.2.0.0: uses non-LFS functions: open
>
> Include config.h in abg-elf-helpers.cc before other headers so that
> AC_SYS_LARGEFILE applies to this file. This fully enables LFS
> in those of 32-bit systems that do not enable it by default.
>
> * src/abg-elf-helpers.cc: Include "config.h" first.
>
> Fixes: 7bd69830520f ("Make Front Ends first class citizens")
> Signed-off-by: Dmitry V. Levin <ldv@strace.io>
This looks good to me so I have applied to patch to the master branch
upstream.
Thanks a lot for your contribution.
[...]
Cheers,
--
Dodji
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-12 8:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-01 20:20 [PATCH] elf-helpers: make sure config.h is included first Dmitry V. Levin
2023-05-11 16:24 ` Dodji Seketeli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).