* [PATCH] abg-ir.h: add declaration of operator<< for elf_symbol::visibility
@ 2021-07-07 10:22 Giuliano Procida
2021-07-07 12:47 ` Matthias Maennich
0 siblings, 1 reply; 3+ messages in thread
From: Giuliano Procida @ 2021-07-07 10:22 UTC (permalink / raw)
To: libabigail; +Cc: dodji, kernel-team, gprocida, maennich
There is a formatted output operator for elf_symbol::visibility in
abg-ir.cc. However, it had no visibile declaration and was not usable
by library users. This commit adds the declaration.
* include/abg-ir.h (operator<<(elf_symbol::visibility): Add
declaration.
Signed-off-by: Giuliano Procida <gprocida@google.com>
---
include/abg-ir.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/abg-ir.h b/include/abg-ir.h
index da43727f..641ce514 100644
--- a/include/abg-ir.h
+++ b/include/abg-ir.h
@@ -1107,6 +1107,9 @@ operator<<(std::ostream& o, elf_symbol::type t);
std::ostream&
operator<<(std::ostream& o, elf_symbol::binding t);
+std::ostream&
+operator<<(std::ostream& o, elf_symbol::visibility t);
+
bool
string_to_elf_symbol_type(const string&, elf_symbol::type&);
--
2.32.0.93.g670b81a890-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] abg-ir.h: add declaration of operator<< for elf_symbol::visibility
2021-07-07 10:22 [PATCH] abg-ir.h: add declaration of operator<< for elf_symbol::visibility Giuliano Procida
@ 2021-07-07 12:47 ` Matthias Maennich
2021-07-16 15:45 ` [PATCH, applied] " Dodji Seketeli
0 siblings, 1 reply; 3+ messages in thread
From: Matthias Maennich @ 2021-07-07 12:47 UTC (permalink / raw)
To: Giuliano Procida; +Cc: libabigail, dodji, kernel-team
On Wed, Jul 07, 2021 at 11:22:22AM +0100, Giuliano Procida wrote:
>There is a formatted output operator for elf_symbol::visibility in
>abg-ir.cc. However, it had no visibile declaration and was not usable
>by library users. This commit adds the declaration.
>
> * include/abg-ir.h (operator<<(elf_symbol::visibility): Add
> declaration.
>
>Signed-off-by: Giuliano Procida <gprocida@google.com>
Reviewed-by: Matthias Maennich <maennich@google.com>
Cheers,
Matthias
>---
> include/abg-ir.h | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/include/abg-ir.h b/include/abg-ir.h
>index da43727f..641ce514 100644
>--- a/include/abg-ir.h
>+++ b/include/abg-ir.h
>@@ -1107,6 +1107,9 @@ operator<<(std::ostream& o, elf_symbol::type t);
> std::ostream&
> operator<<(std::ostream& o, elf_symbol::binding t);
>
>+std::ostream&
>+operator<<(std::ostream& o, elf_symbol::visibility t);
>+
> bool
> string_to_elf_symbol_type(const string&, elf_symbol::type&);
>
>--
>2.32.0.93.g670b81a890-goog
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH, applied] abg-ir.h: add declaration of operator<< for elf_symbol::visibility
2021-07-07 12:47 ` Matthias Maennich
@ 2021-07-16 15:45 ` Dodji Seketeli
0 siblings, 0 replies; 3+ messages in thread
From: Dodji Seketeli @ 2021-07-16 15:45 UTC (permalink / raw)
To: Matthias Maennich; +Cc: Giuliano Procida, libabigail, kernel-team
Matthias Maennich <maennich@google.com> a écrit:
> On Wed, Jul 07, 2021 at 11:22:22AM +0100, Giuliano Procida wrote:
>>There is a formatted output operator for elf_symbol::visibility in
>>abg-ir.cc. However, it had no visibile declaration and was not usable
>>by library users. This commit adds the declaration.
>>
>> * include/abg-ir.h (operator<<(elf_symbol::visibility): Add
>> declaration.
>>
>>Signed-off-by: Giuliano Procida <gprocida@google.com>
>
> Reviewed-by: Matthias Maennich <maennich@google.com>
Applied to master, thanks!
[...]
Cheers,
--
Dodji
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-16 15:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-07 10:22 [PATCH] abg-ir.h: add declaration of operator<< for elf_symbol::visibility Giuliano Procida
2021-07-07 12:47 ` Matthias Maennich
2021-07-16 15:45 ` [PATCH, applied] " Dodji Seketeli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).