[Bug default/26571] New: get_vmlinux_path_from_kernel_dist contains useless code

[Bug default/26571] New: get_vmlinux_path_from_kernel_dist contains useless code

[gprocida+abigail at google dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26571

            Bug ID: 26571
           Summary: get_vmlinux_path_from_kernel_dist contains useless
                    code
           Product: libabigail
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: gprocida+abigail at google dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

get_vmlinux_path_from_kernel_dist has the following statement:

  if (dir_exists(dist_root + "/lib/modules"))
    dist_root + "/lib/modules";

It should probably read:

  if (dir_exists(dist_root + "/lib/modules"))
    dist_root += "/lib/modules";

However, I don't know if the existing behaviour is now relied on by anything.

There is also a confusing (copy/paste?) comment referring to "/usr/lib/debug".

(This bug report was brought to you with the assistance of clang-tidy which
flagged that "dist_root" was an unnecessary copy of "from".)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26571] get_vmlinux_path_from_kernel_dist contains useless code

[gprocida+abigail at google dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26571

--- Comment #1 from Giuliano Procida <gprocida+abigail at google dot com> ---
The code indentation in the function is also wrong in a couple of places.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26571] get_vmlinux_path_from_kernel_dist contains useless code

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26571

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from dodji at redhat dot com ---
Right, this is a thinko, of course, and it ought to be fixed.

Thank you for spotting this.

The obvious fix has been applied to master at
https://sourceware.org/git/?p=libabigail.git;a=commit;h=a434894e4dbff278d651b6dd5875fc9b4bfec1bf

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.