From: "gprocida+abigail at google dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/26646] unexpectedly declaration-only types
Date: Wed, 07 Oct 2020 09:33:22 +0000 [thread overview]
Message-ID: <bug-26646-9487-BXOvEE5NUJ@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-26646-9487@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=26646
--- Comment #3 from Giuliano Procida <gprocida+abigail at google dot com> ---
I'd recommend doing the following.
build/tools/abidw --no-comp-dir-path --no-show-locs --type-id-style hash
vmlinux mainline.xml.master
cherry-pick the patch
https://sourceware.org/pipermail/libabigail/2020q3/002679.html
and rebuild
build/tools/abidw --no-comp-dir-path --no-show-locs --type-id-style hash
vmlinux mainline.xml.ordered
Despite the abidw options given, it's a bit much to try to diff these by hand
as there are thousands of differences. Analysis shows 168 fewer
declaration-only (only) types in the latter XML.
*Assuming* both XML files are in some sense valid, abidiff can illustrate other
potential problems. It would make sense to open separate Bugzilla issues, if
confirmed.
Do 4 abidiffs (with / without --harmless, with / without --leaf-changes-only)
between mainline.xml.master and mainline.xml.ordered.
abidiff - shows lots of stuff being filtered out (hmmm)
abidiff --harmless - shows diffs like the following (bug?)
type changed from:
union {snd_info_entry_text text; const snd_info_entry_ops* ops;}
to:
union {snd_info_entry_text text; const snd_info_entry_ops* ops;}
abidiff --leaf-changes-only - shows some type changes filtered out
abidiff --leaf-changes-only --harmless - shows there's at least one bug in
reporting (perhaps due to the same anonymous union issue?)
Lastly, some of these abidiff runs take a long time (up to 7 minutes on a fast
machine), but that may be expected given the large XML differences.
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2020-10-07 9:33 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 11:35 [Bug default/26646] New: " gprocida+abigail at google dot com
2020-09-22 12:15 ` [Bug default/26646] " dodji at redhat dot com
2020-10-06 21:02 ` gprocida+abigail at google dot com
2020-10-07 9:33 ` gprocida+abigail at google dot com [this message]
2020-11-23 17:06 ` gprocida+abigail at google dot com
2022-01-17 17:46 ` gprocida at google dot com
2022-01-18 9:37 ` gprocida at google dot com
2022-01-18 11:20 ` gprocida at google dot com
2022-01-18 11:20 ` gprocida at google dot com
2022-01-18 11:32 ` gprocida at google dot com
2022-01-24 15:07 ` dodji at redhat dot com
2022-01-24 17:29 ` gprocida at google dot com
2022-02-07 10:40 ` gprocida at google dot com
2022-02-07 11:19 ` dodji at redhat dot com
2022-02-07 17:10 ` [Bug default/26646] unexpected " dodji at redhat dot com
2022-02-07 17:47 ` gprocida at google dot com
2022-02-07 21:15 ` gprocida at google dot com
2022-02-10 16:45 ` dodji at redhat dot com
2022-02-10 16:46 ` gprocida at google dot com
2022-02-10 17:21 ` gprocida at google dot com
2022-02-10 17:33 ` dodji at redhat dot com
2022-02-10 17:36 ` dodji at redhat dot com
2022-02-10 18:53 ` gprocida at google dot com
2022-02-11 12:51 ` gprocida at google dot com
2022-02-11 13:00 ` gprocida at google dot com
2022-02-24 11:09 ` dodji at redhat dot com
2022-02-24 12:16 ` gprocida at google dot com
2022-02-24 15:54 ` dodji at redhat dot com
2022-02-24 16:05 ` gprocida at google dot com
2022-02-28 9:59 ` dodji at redhat dot com
2022-02-28 10:01 ` dodji at redhat dot com
2022-03-01 14:34 ` gprocida at google dot com
2022-03-01 14:40 ` gprocida at google dot com
2022-03-02 13:34 ` Dodji Seketeli
2022-03-02 13:34 ` dodji at seketeli dot org
2022-03-02 22:36 ` gprocida at google dot com
2022-03-03 11:43 ` dodji at seketeli dot org
2022-03-03 13:32 ` gprocida at google dot com
2022-06-08 15:43 ` gprocida at google dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-26646-9487-BXOvEE5NUJ@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).