From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: caiyinyu <caiyinyu@loongson.cn>,
libc-alpha@sourceware.org, joseph_myers@mentor.com,
carlos@redhat.com, i.swmail@xen0n.name
Subject: Re: [PATCH v7 00/13] GLIBC LoongArch PATCHES
Date: Wed, 20 Jul 2022 14:19:30 -0300 [thread overview]
Message-ID: <087092dc-2e2f-bb3e-74b9-a3462cff5763@linaro.org> (raw)
In-Reply-To: <20220719012056.1461897-1-caiyinyu@loongson.cn>
On 18/07/22 22:20, caiyinyu wrote:
> Hello, these are LoongArch patches v7, and we really need your futher suggestions:
>
> There are 6 parts in total.
>
> 1. HISTORY:
> LoongArch patches v1: https://sourceware.org/pipermail/libc-alpha/2021-August/130262.html
> LoongArch patches v2: https://sourceware.org/pipermail/libc-alpha/2021-December/134811.html
> LoongArch patches v3: https://sourceware.org/pipermail/libc-alpha/2022-April/137888.html
> LoongArch patches v4: https://sourceware.org/pipermail/libc-alpha/2022-May/subject.html
> LoongArch patches v5: https://sourceware.org/pipermail/libc-alpha/2022-June/139262.html
> LoongArch patches v6: https://sourceware.org/pipermail/libc-alpha/2022-July/140446.html
>
> 2. LoongArch-Doc: https://github.com/loongson/LoongArch-Documentation
>
> We add new section: procedure calling convention.
> https://loongson.github.io/LoongArch-Documentation/LoongArch-ELF-ABI-EN.html#_procedure_calling_convention
>
>
> 3. Linux kernel, GCC and Binutils Loongarch parts have been into GNU Open Source community.
>
>
> 4. From Adhemerval Zanella Netto:
>> I finished my review for the port and it looks ok in general, however there
>> some pieces that would require a v7:
>>
>> 1. Add R_LARCH_NONE handling on bootstrap, binutils 2.38 does generated it
>> and from previous discussion it should be considered a missed
>> optimizations instead of a linker error.
>
> R_LARCH_NONE handling has been added on bootstrap.
>>
>> 2. Remove the __loongarch_soft_float parts, since there is no support for
>> soft floating-point.
>
> All __loongarch_soft_float removed.
>>
>> 3. Remove sysdeps/unix/sysv/linux/loongarch/ldconfig.h, this file is not
>> required.
>
> This file has been removed.
>>
>> 4. Some minor style issues.
>
> See previous emails.
> https://sourceware.org/pipermail/libc-alpha/2022-July/thread.html
>>
>> 5. Either remove HAVE_GETTIMEOFDAY_VSYSCALL or add a gettimeofday ifunc
>> optimization.
>
> Removed now.
>>
>> The only part really prevent port inclusion is 1. I am also assuming ifunc
>> is support (at least you have added support on the Linux ABI part) with
>> binutils 2.38. If not, you will need to remove support until you fix it on
>> binutils.
>>
>> And also, you need to check and report the test results using the expected
>> defined release branches, using out-of-tree branches are not acceptable for
>> inclusion.
>
> 5. There are some new changes:
This version looks good to me, everything I have pointed out in previous release
was addressed, build-many-glibcs.py and make check does not trigger any issue,
and some qemu tests show that the generated loader and binaries are corrected
generated.
If you want, I can push it upstream. Carlos is ok to install it?
next prev parent reply other threads:[~2022-07-20 17:19 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 1:20 caiyinyu
2022-07-19 1:20 ` [PATCH v7 01/13] LoongArch: Add LoongArch entries to config.h.in caiyinyu
2022-07-21 21:02 ` Adhemerval Zanella Netto
2022-07-19 1:20 ` [PATCH v7 02/13] LoongArch: Add relocations and ELF flags to elf.h and scripts/glibcelf.py caiyinyu
2022-07-21 21:02 ` Adhemerval Zanella Netto
2022-07-19 1:20 ` [PATCH v7 03/13] LoongArch: ABI Implementation caiyinyu
2022-07-20 12:29 ` Adhemerval Zanella Netto
2022-07-19 1:20 ` [PATCH v7 04/13] LoongArch: Thread-Local Storage Support caiyinyu
2022-07-20 14:34 ` Adhemerval Zanella Netto
2022-07-19 1:20 ` [PATCH v7 05/13] LoongArch: Generic <math.h> and soft-fp Routines caiyinyu
2022-07-20 13:04 ` Adhemerval Zanella Netto
2022-07-19 1:20 ` [PATCH v7 06/13] LoongArch: Atomic and Locking Routines caiyinyu
2022-07-20 14:32 ` Adhemerval Zanella Netto
2022-07-19 1:20 ` [PATCH v7 07/13] LoongArch: Linux Syscall Interface caiyinyu
2022-07-20 14:35 ` Adhemerval Zanella Netto
2022-07-27 5:27 ` WANG Xuerui
2022-07-27 5:32 ` WANG Xuerui
2022-07-27 11:16 ` Adhemerval Zanella Netto
2022-07-27 13:01 ` WANG Xuerui
2022-07-27 19:22 ` Adhemerval Zanella Netto
2022-07-19 1:20 ` [PATCH v7 08/13] LoongArch: Linux ABI caiyinyu
2022-07-20 16:37 ` Adhemerval Zanella Netto
2022-07-20 17:19 ` Adhemerval Zanella Netto [this message]
2022-07-21 2:44 ` [PATCH v7 00/13] GLIBC LoongArch PATCHES caiyinyu
2022-07-24 9:49 ` WANG Xuerui
2022-07-24 11:51 ` Xi Ruoyao
2022-07-24 12:02 ` WANG Xuerui
2022-07-25 8:21 ` caiyinyu
2022-07-25 8:28 ` Xi Ruoyao
2022-07-25 1:58 ` 刘振松
2022-07-25 8:01 ` Xi Ruoyao
2022-07-25 13:27 ` Adhemerval Zanella Netto
2022-07-25 14:14 ` caiyinyu
2022-07-26 12:35 ` caiyinyu
2022-07-26 12:42 ` Adhemerval Zanella Netto
2022-07-26 14:00 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=087092dc-2e2f-bb3e-74b9-a3462cff5763@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=caiyinyu@loongson.cn \
--cc=carlos@redhat.com \
--cc=i.swmail@xen0n.name \
--cc=joseph_myers@mentor.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).