From: Xi Ruoyao <xry111@xry111.site>
To: 刘振松 <liuzhensong@loongson.cn>
Cc: WANG Xuerui <i.swmail@xen0n.name>,
caiyinyu <caiyinyu@loongson.cn>,
adhemerval.zanella@linaro.org, libc-alpha@sourceware.org,
joseph_myers@mentor.com, carlos@redhat.com
Subject: Re: Re: [PATCH v7 00/13] GLIBC LoongArch PATCHES
Date: Mon, 25 Jul 2022 16:01:07 +0800 [thread overview]
Message-ID: <887137f5f1aada4363e6106a1eacdf17449155fc.camel@xry111.site> (raw)
In-Reply-To: <6e4016e7.8a14.1823313f163.Coremail.liuzhensong@loongson.cn>
On Mon, 2022-07-25 at 09:58 +0800, 刘振松 wrote:
> > +Zhensong: is there any possibility to merge this patch for binutils
> > master and 2.39 release branch (including 2.38 release branch would be
> > even better) so at least glibc ifunc tests will be happy?
>
> This patch alone has not been fully tested， some ifunc implementations rely on new modifications.
> If there is no problem with the tests, it can be merged into other branchs.
Binutils tests OK with the change.
I had to introduce "alt_got" and "alt_off" (not in your original patch)
when I extracted the patch out of the series, with changes like:
- bfd_put_NN (output_bfd, relocation, got->contents + off);
+ bfd_put_NN (output_bfd, relocation, alt_got->contents + alt_off);
It's because if something is not in .got section, referring it with
got->contents + off will cause a heap buffer overflow even if off is
correct. If the full series of your patch is applied, this seems not
happening. But with only this patch, we need to prevent it.
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2022-07-25 8:01 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 1:20 caiyinyu
2022-07-19 1:20 ` [PATCH v7 01/13] LoongArch: Add LoongArch entries to config.h.in caiyinyu
2022-07-21 21:02 ` Adhemerval Zanella Netto
2022-07-19 1:20 ` [PATCH v7 02/13] LoongArch: Add relocations and ELF flags to elf.h and scripts/glibcelf.py caiyinyu
2022-07-21 21:02 ` Adhemerval Zanella Netto
2022-07-19 1:20 ` [PATCH v7 03/13] LoongArch: ABI Implementation caiyinyu
2022-07-20 12:29 ` Adhemerval Zanella Netto
2022-07-19 1:20 ` [PATCH v7 04/13] LoongArch: Thread-Local Storage Support caiyinyu
2022-07-20 14:34 ` Adhemerval Zanella Netto
2022-07-19 1:20 ` [PATCH v7 05/13] LoongArch: Generic <math.h> and soft-fp Routines caiyinyu
2022-07-20 13:04 ` Adhemerval Zanella Netto
2022-07-19 1:20 ` [PATCH v7 06/13] LoongArch: Atomic and Locking Routines caiyinyu
2022-07-20 14:32 ` Adhemerval Zanella Netto
2022-07-19 1:20 ` [PATCH v7 07/13] LoongArch: Linux Syscall Interface caiyinyu
2022-07-20 14:35 ` Adhemerval Zanella Netto
2022-07-27 5:27 ` WANG Xuerui
2022-07-27 5:32 ` WANG Xuerui
2022-07-27 11:16 ` Adhemerval Zanella Netto
2022-07-27 13:01 ` WANG Xuerui
2022-07-27 19:22 ` Adhemerval Zanella Netto
2022-07-19 1:20 ` [PATCH v7 08/13] LoongArch: Linux ABI caiyinyu
2022-07-20 16:37 ` Adhemerval Zanella Netto
2022-07-20 17:19 ` [PATCH v7 00/13] GLIBC LoongArch PATCHES Adhemerval Zanella Netto
2022-07-21 2:44 ` caiyinyu
2022-07-24 9:49 ` WANG Xuerui
2022-07-24 11:51 ` Xi Ruoyao
2022-07-24 12:02 ` WANG Xuerui
2022-07-25 8:21 ` caiyinyu
2022-07-25 8:28 ` Xi Ruoyao
2022-07-25 1:58 ` 刘振松
2022-07-25 8:01 ` Xi Ruoyao [this message]
2022-07-25 13:27 ` Adhemerval Zanella Netto
2022-07-25 14:14 ` caiyinyu
2022-07-26 12:35 ` caiyinyu
2022-07-26 12:42 ` Adhemerval Zanella Netto
2022-07-26 14:00 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=887137f5f1aada4363e6106a1eacdf17449155fc.camel@xry111.site \
--to=xry111@xry111.site \
--cc=adhemerval.zanella@linaro.org \
--cc=caiyinyu@loongson.cn \
--cc=carlos@redhat.com \
--cc=i.swmail@xen0n.name \
--cc=joseph_myers@mentor.com \
--cc=libc-alpha@sourceware.org \
--cc=liuzhensong@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).